Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-10-03 Thread Baptiste Jonglez
Hi, Thanks a lot for fixing this! Can you backport it to openwrt-19.07? ath79 is also affected there. Regards, Baptiste On 21-09-20, Chuanhong Guo wrote: > reg accesses on integrated ar8229 sometimes fails. As a result, phy read > got incorrect port status and wan link goes down and up

Re: [PATCH v4 1/4] ipq806x: add support for Linksys E8350 v1

2020-10-03 Thread Chuanhong Guo
Hi! On Tue, Sep 29, 2020 at 2:00 AM Todor Colov wrote: > --- a/target/linux/ipq806x/image/Makefile > +++ b/target/linux/ipq806x/image/Makefile > @@ -13,6 +13,17 @@ define Build/buffalo-rootfs-cksum > ) >> $@ > endef > > +# tune addpattern for Linksys E8350-V1 fw pattern generation >

Re: Someone working on kernel 5.9?

2020-10-03 Thread Robert Marko
On Sat, 3 Oct 2020 at 17:20, Ansuel Smith wrote: > > > > > Hi folks, > > > > is anybody working on 5.9, already? > > I'd like to do some testing with io_uring on ath79 devices, > > but the features needed require a version > 5.7. > > Please let me know! > > > > Best, > > > > Vincent > > It's

[PATCH uci 1/4] file: use size_t for position and pointer

2020-10-03 Thread Hauke Mehrtens
The bufsz variable is used to store the size of the buf memory region and pos is used to index a position in this memory. Use size_t for these variables in the internal handling instaed of int to not break with big files. Signed-off-by: Hauke Mehrtens --- file.c | 14 +++---

[PATCH uci 2/4] file: Check buffer size after strtok()

2020-10-03 Thread Hauke Mehrtens
This fixes a heap overflow in the parsing of the uci line. The line which is parsed and put into pctx->buf is null terminated and stored on the heap. In the uci_parse_line() function we use strtok() to split this string in multiple parts after divided by a space or tab. strtok() replaces these

[PATCH uci 0/4] uci: Fix multiple bugs

2020-10-03 Thread Hauke Mehrtens
This is based on Petr's "[PATCH uci 0/6] fixes and improvements" patches. This fixes an additional heap read overflow and some other problems I discovered by analyzing and fixing the problem. Hauke Mehrtens (4): file: use size_t for position and pointer file: Check buffer size after

[PATCH uci 4/4] Replace malloc() + memset() with calloc()

2020-10-03 Thread Hauke Mehrtens
Instead of manually clearing the memory with memset() use calloc(). Signed-off-by: Hauke Mehrtens --- cli.c| 3 +-- libuci.c | 3 +-- ucimap.c | 6 ++ util.c | 3 +-- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/cli.c b/cli.c index 6ba97ea..267437d 100644 ---

[PATCH uci 3/4] ucimap: Check return of malloc()

2020-10-03 Thread Hauke Mehrtens
Check the return value of malloc() before accessing it. Signed-off-by: Hauke Mehrtens --- ucimap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ucimap.c b/ucimap.c index 7c2b043..c46cf45 100644 --- a/ucimap.c +++ b/ucimap.c @@ -893,14 +893,16 @@ ucimap_parse(struct

Re: ath79: move 8/32 boards to tiny subtarget

2020-10-03 Thread Paul Oranje
> Op 21 sep. 2020, om 20:42 heeft Sven Roederer het > volgende geschreven: > > Fernando, > > I'm only talking on the boards having 32MB RAM. This includes 4MB / 8MB flash > boards. > I'm not having the 8/64 boards in mind. They are fine and should work for > some > furture releases

Re: Someone working on kernel 5.9?

2020-10-03 Thread Ansuel Smith
> > Hi folks, > > is anybody working on 5.9, already? > I'd like to do some testing with io_uring on ath79 devices, > but the features needed require a version > 5.7. > Please let me know! > > Best, > > Vincent It's still in rc stage and openwrt still needs to chose the next kernel version...

Someone working on kernel 5.9?

2020-10-03 Thread Vincent Wiemann
Hi folks, is anybody working on 5.9, already? I'd like to do some testing with io_uring on ath79 devices, but the features needed require a version > 5.7. Please let me know! Best, Vincent ___ openwrt-devel mailing list

[PATCH uci 6/6] file: uci_file_commit: fix memory leak

2020-10-03 Thread Petr Štetiar
Fixes following memory leak: 26 bytes in 1 blocks are definitely lost in loss record 1 of 1 at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x52DA68F: vasprintf (vasprintf.c:73) by 0x52B71D3: asprintf (asprintf.c:35) by 0x4E40F67: uci_file_commit

[PATCH uci 0/6] fixes and improvements

2020-10-03 Thread Petr Štetiar
Hi, this patch series fixes some issues, adds more tests and fuzzing focused mainly on uci_import feature. Cheers, Petr Petr Štetiar (6): tests: add libFuzzer based fuzzing file: uci_parse_package: fix heap use after free cmake: add uci-san cli built with clang sanitizers tests: cram:

[PATCH uci 3/6] cmake: add uci-san cli built with clang sanitizers

2020-10-03 Thread Petr Štetiar
Will be used for testing. Signed-off-by: Petr Štetiar --- CMakeLists.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index da4ac68c0139..560ed6597adc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -56,6 +56,21 @@ ENDIF()

[PATCH uci 1/6] tests: add libFuzzer based fuzzing

2020-10-03 Thread Petr Štetiar
LibFuzzer is in-process, coverage-guided, evolutionary fuzzing engine. LibFuzzer is linked with the library under test, and feeds fuzzed inputs to the library via a specific fuzzing entrypoint (aka "target function"); the fuzzer then tracks which areas of the code are reached, and generates

[PATCH uci 2/6] file: uci_parse_package: fix heap use after free

2020-10-03 Thread Petr Štetiar
Fixes following issue which is caused by usage of pointer which pointed to a reallocated address: ERROR: AddressSanitizer: heap-use-after-free on address 0x61900087 at pc 0x00509aa7 bp 0x7ffd6b9c3c40 sp 0x7ffd6b9c3400 READ of size 2 at 0x61900087 thread T0 #0 0x509aa6 in

[PATCH uci 5/6] uci: silence UBSAN error by using offsetof macro from compiler

2020-10-03 Thread Petr Štetiar
Fixes following ubdefined-behavior as reported by clang version 10.0.0-4ubuntu1~18.04.2: delta.c:139:52: runtime error: member access within null pointer of type 'struct uci_element' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior delta.c:139:52 Signed-off-by: Petr Štetiar ---

[PATCH uci 4/6] tests: cram: add uci import testing on fuzzer corpus

2020-10-03 Thread Petr Štetiar
Use valgrind and uci cli compiled with undefined, address and leak sanitizers. Signed-off-by: Petr Štetiar --- tests/cram/CMakeLists.txt| 7 ++- tests/cram/test-san_uci_import.t | 15 +++ tests/cram/test_uci_import.t | 15 +++ 3 files changed, 36