Re: [RFC PATCH] openssl: make the patches QUILT-friendly

2021-03-26 Thread Eneas U de Queiroz
On Fri, Mar 26, 2021 at 7:35 PM Kevin 'ldir' Darbyshire-Bryant wrote: > > ... I was also frustrated that there was patch fuzz in the tree on a fairly > core package - that really shouldn’t be the case. My apologies. I work in a clone of the openssl git repo, rebasing the changes on top of the

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Eneas U de Queiroz
On Fri, Mar 26, 2021 at 6:57 PM Felix Fietkau wrote: > I fully agree with Eneas here (though I don't like his patch for this > issue either). This is the first time I wrote a patch I do NOT want to be applied. I just want to keep the status quo. > Here's a way to fix this: > >

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Rosen Penev
On Fri, Mar 26, 2021 at 2:57 PM Felix Fietkau wrote: > > > On 2021-03-26 22:39, Eneas U de Queiroz wrote: > > On Fri, Mar 26, 2021 at 4:28 PM Rosen Penev wrote: > >> > >> On Fri, Mar 26, 2021 at 5:55 AM Eneas U de Queiroz > >> wrote: > >> > > >> > On Fri, Mar 26, 2021 at 6:26 AM Rosen Penev

Re: [RFC PATCH] openssl: make the patches QUILT-friendly

2021-03-26 Thread Kevin 'ldir' Darbyshire-Bryant
> On 26 Mar 2021, at 18:55, Eneas U de Queiroz wrote: > > The patches in this package are all made by git format-patches. If one > were to run 'make package/openssl/{refresh,update}', then things will > not work as expected, because quilt QUILT does not deal well with > patches that rename

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Felix Fietkau
On 2021-03-26 22:39, Eneas U de Queiroz wrote: > On Fri, Mar 26, 2021 at 4:28 PM Rosen Penev wrote: >> >> On Fri, Mar 26, 2021 at 5:55 AM Eneas U de Queiroz >> wrote: >> > >> > On Fri, Mar 26, 2021 at 6:26 AM Rosen Penev wrote: >> > > +ifeq ($(QUILT),) >> > > + mv

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Eneas U de Queiroz
On Fri, Mar 26, 2021 at 4:28 PM Rosen Penev wrote: > > On Fri, Mar 26, 2021 at 5:55 AM Eneas U de Queiroz > wrote: > > > > On Fri, Mar 26, 2021 at 6:26 AM Rosen Penev wrote: > > > +ifeq ($(QUILT),) > > > + mv $(PKG_BUILD_DIR)/crypto/engine/eng_devcrypto.c > > >

Re: [RFC PATCH] openssl: make the patches QUILT-friendly

2021-03-26 Thread Rosen Penev
On Fri, Mar 26, 2021 at 11:56 AM Eneas U de Queiroz wrote: > > The patches in this package are all made by git format-patches. If one > were to run 'make package/openssl/{refresh,update}', then things will > not work as expected, because quilt QUILT does not deal well with > patches that rename

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Rosen Penev
On Fri, Mar 26, 2021 at 5:55 AM Eneas U de Queiroz wrote: > > Hi Rosen > > This patch does not apply as is, but don't write a v2 yet. > I'm testing the bump to 1.1.1k, and I'll handle it from there, by > using --no-renames with git format-patch. I'm maintaining the patches > at

[RFC PATCH] openssl: make the patches QUILT-friendly

2021-03-26 Thread Eneas U de Queiroz
The patches in this package are all made by git format-patches. If one were to run 'make package/openssl/{refresh,update}', then things will not work as expected, because quilt QUILT does not deal well with patches that rename files. For openssl, the problematic patch is

[PATCH] openssl: bump to 1.1.1k

2021-03-26 Thread Eneas U de Queiroz
This version fixes 2 security vulnerabilities, among other changes: - CVE-2021-3450: problem with verifying a certificate chain when using the X509_V_FLAG_X509_STRICT flag. - CVE-2021-3449: OpenSSL TLS server may crash if sent a maliciously crafted renegotiation ClientHello message from

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Eneas U de Queiroz
Hi Rosen This patch does not apply as is, but don't write a v2 yet. I'm testing the bump to 1.1.1k, and I'll handle it from there, by using --no-renames with git format-patch. I'm maintaining the patches at https://github.com/cotequeiroz/openssl, and refreshing backports with git is much easier

Re: ujail: bug or feature ?

2021-03-26 Thread Daniel Golle
On Fri, Mar 26, 2021 at 01:06:33PM +0100, e9hack wrote: > Am 26.03.2021 um 12:09 schrieb Daniel Golle: > > > > On Fri, Mar 26, 2021 at 10:54:32AM +0100, e9hack wrote: > > > Am 26.03.2021 um 10:17 schrieb Daniel Golle: > > > > On Fri, Mar 26, 2021 at 09:32:33AM +0100, e9hack wrote: > > > > > Hi, >

Re: ujail: bug or feature ?

2021-03-26 Thread e9hack
Am 26.03.2021 um 12:09 schrieb Daniel Golle: On Fri, Mar 26, 2021 at 10:54:32AM +0100, e9hack wrote: Am 26.03.2021 um 10:17 schrieb Daniel Golle: On Fri, Mar 26, 2021 at 09:32:33AM +0100, e9hack wrote: Hi, a program run by ujail gets a PID of 1. The real PID is different. If such a program

Re: ujail: bug or feature ?

2021-03-26 Thread Daniel Golle
On Fri, Mar 26, 2021 at 10:54:32AM +0100, e9hack wrote: > Am 26.03.2021 um 10:17 schrieb Daniel Golle: > > On Fri, Mar 26, 2021 at 09:32:33AM +0100, e9hack wrote: > > > Hi, > > > > > > a program run by ujail gets a PID of 1. The real PID is different. If > > > such a program generates a PID

Re: ujail: bug or feature ?

2021-03-26 Thread e9hack
Am 26.03.2021 um 10:17 schrieb Daniel Golle: On Fri, Mar 26, 2021 at 09:32:33AM +0100, e9hack wrote: Hi, a program run by ujail gets a PID of 1. The real PID is different. If such a program generates a PID file by its own and the PID from that file is used by a script that is not run by

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Martin Schiller
On 2021-03-26 10:44, Felix Fietkau wrote: On 2021-03-26 09:55, Martin Schiller wrote: On 2021-03-26 09:42, Felix Fietkau wrote: On 2021-03-26 09:34, Martin Schiller wrote: On 2020-07-24 19:13, Felix Fietkau wrote: On 2020-07-24 18:44, Jo-Philipp Wich wrote: Hi Felix, [...] For a simple

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Felix Fietkau
On 2021-03-26 09:55, Martin Schiller wrote: > On 2021-03-26 09:42, Felix Fietkau wrote: >> On 2021-03-26 09:34, Martin Schiller wrote: >>> On 2020-07-24 19:13, Felix Fietkau wrote: On 2020-07-24 18:44, Jo-Philipp Wich wrote: > Hi Felix, > >> [...] >> >> For a simple

[PATCH 2/2] lua5.3: refresh patches

2021-03-26 Thread Rosen Penev
Renamed doc files in Build/Prepare instead of patches as quilt cannot handle renames in patches. Signed-off-by: Rosen Penev --- package/utils/lua5.3/Makefile | 8 +++ .../patches/001-include-version-number.patch | 8 --- .../lua5.3/patches/020-shared_liblua.patch| 60

[PATCH 1/2] lua: refresh patches

2021-03-26 Thread Rosen Penev
Renamed doc files in Build/Prepare instead of patches as quilt cannot handle renames in patches. Signed-off-by: Rosen Penev --- package/utils/lua/Makefile| 8 .../lua/patches/001-include-version-number.patch | 10 +-

Re: [PATCH] build: remove GCC7 support

2021-03-26 Thread Paul Spooren
On Fr, Mär 26, 2021 at 02:28, Rosen Penev wrote: On Fri, Mar 26, 2021 at 1:49 AM Paul Spooren wrote: Since we recently branched a new release which already ships with GCC7, version 6 could be considered obsolete. version 6? Subject is right, body is wrong. So it's about removing

Re: [PATCH] build: remove GCC7 support

2021-03-26 Thread Rosen Penev
On Fri, Mar 26, 2021 at 1:49 AM Paul Spooren wrote: > > Since we recently branched a new release which already ships with GCC7, > version 6 could be considered obsolete. version 6? Could also mention GCC7 does not support std::filesystem , which is needed by some programs such as gerbera in the

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Martin Schiller
On 2021-03-26 09:55, Martin Schiller wrote: On 2021-03-26 09:42, Felix Fietkau wrote: On 2021-03-26 09:34, Martin Schiller wrote: On 2020-07-24 19:13, Felix Fietkau wrote: On 2020-07-24 18:44, Jo-Philipp Wich wrote: Hi Felix, [...] For a simple default config, you could have this: #

[PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Rosen Penev
quilt cannot handle file renames and ends up duplicating the file. Instead of doing that, handle the renaming in the Makefile so that the upstream file can change. Signed-off-by: Rosen Penev --- package/libs/openssl/Makefile |7 +

Re: ujail: bug or feature ?

2021-03-26 Thread Daniel Golle
On Fri, Mar 26, 2021 at 09:32:33AM +0100, e9hack wrote: > Hi, > > a program run by ujail gets a PID of 1. The real PID is different. If such a > program generates a PID file by its own and the PID from that file is used by > a script that is not run by ujail, then any operation will be

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Martin Schiller
On 2021-03-26 09:42, Felix Fietkau wrote: On 2021-03-26 09:34, Martin Schiller wrote: On 2020-07-24 19:13, Felix Fietkau wrote: On 2020-07-24 18:44, Jo-Philipp Wich wrote: Hi Felix, [...] For a simple default config, you could have this: # network config device option type bridge

[PATCH] build: remove GCC7 support

2021-03-26 Thread Paul Spooren
Since we recently branched a new release which already ships with GCC7, version 6 could be considered obsolete. Signed-off-by: Paul Spooren --- toolchain/gcc/Config.in | 4 - toolchain/gcc/Config.version | 10 - toolchain/gcc/common.mk

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Felix Fietkau
On 2021-03-26 09:34, Martin Schiller wrote: > On 2020-07-24 19:13, Felix Fietkau wrote: >> On 2020-07-24 18:44, Jo-Philipp Wich wrote: >>> Hi Felix, >>> [...] For a simple default config, you could have this: # network config device >>> option type bridge

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Martin Schiller
On 2020-07-24 19:13, Felix Fietkau wrote: On 2020-07-24 18:44, Jo-Philipp Wich wrote: Hi Felix, [...] For a simple default config, you could have this: # network config device option type bridge # I assume this is needed as well option name switch0 Correct. config

ujail: bug or feature ?

2021-03-26 Thread e9hack
Hi, a program run by ujail gets a PID of 1. The real PID is different. If such a program generates a PID file by its own and the PID from that file is used by a script that is not run by ujail, then any operation will be performed with the wrong PID, which is the PID of /sbin/procd in the

[PATCH] ramips: mt7620: ralink-i2s: fix modpost error

2021-03-26 Thread Ilya Lipnitskiy
Fixes the following error when building without CONFIG_MODULE_STRIPPED: FATAL: modpost: sound/soc/ralink/snd-soc-ralink-i2s: struct of_device_id is not terminated with a NULL entry! Signed-off-by: Ilya Lipnitskiy --- .../ramips/patches-5.10/835-asoc-add-mt7620-support.patch | 3 ++- 1