[PATCH v2] imagebuilder, sdk: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archives

2021-04-24 Thread Sven Roederer
Using these config-options to customize the folders used at build-time makes these folder settings appear in generated archives. This causes the archives to be not portable, as they going to use the build-time folders on the new systems. Errors look like for the imagebuilder: mkdir: cannot

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Daniel Golle
On Sat, Apr 24, 2021 at 09:05:58PM +0530, Gaurav Pathak wrote: > As Daniel mentioned, this change is for providing the capability to container > environment to be able to login using PTY. > Also, there can be a case when console option is not passed to kernel command > line, > in that case we

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Gaurav Pathak
As Daniel mentioned, this change is for providing the capability to container environment to be able to login using PTY. Also, there can be a case when console option is not passed to kernel command line, in that case we should try and check for the presence of /dev/console character device

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Daniel Golle
On Sat, Apr 24, 2021 at 03:39:51AM -1000, Paul Spooren wrote: > > On 4/24/21 1:01 AM, Gaurav Pathak wrote: > > Modified inittab.c to use "/dev/console" as preferred console if exists. > > > > Signed-off-by: Gaurav Pathak > > --- > > Could you please elaborate why this is useful? Container

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Paul Spooren
On 4/24/21 1:01 AM, Gaurav Pathak wrote: Modified inittab.c to use "/dev/console" as preferred console if exists. Signed-off-by: Gaurav Pathak --- Could you please elaborate why this is useful? Edited inittab.c to check and use "/dev/console" as the first console device before parsing

Re: [PATCH] ipq40xx: add support for GL.iNet GL-B2200-EMMC

2021-04-24 Thread Daniel Golle
Hi Li, On Fri, Apr 16, 2021 at 12:05:24PM +0800, Li Zhang wrote: > This patch adds supports for GL-B2200-EMMC. > > ... > diff --git a/target/linux/ipq40xx/image/gen_sdcard_img.sh > b/target/linux/ipq40xx/image/gen_sdcard_img.sh > new file mode 100755 > index 000..628ba24 > --- /dev/null >

RE: [PATCH] ipq40xx: add support for GL.iNet GL-B2200-EMMC

2021-04-24 Thread Adrian Schmutzler
Hi, just some selective feedback below: > diff --git a/package/firmware/ipq-wifi/Makefile b/package/firmware/ipq- > wifi/Makefile > index 7703604..7d592d9 100644 > --- a/package/firmware/ipq-wifi/Makefile > +++ b/package/firmware/ipq-wifi/Makefile > @@ -40,6 +40,7 @@ ALLWIFIBOARDS:= \ >

[RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Gaurav Pathak
Modified inittab.c to use "/dev/console" as preferred console if exists. Signed-off-by: Gaurav Pathak --- Edited inittab.c to check and use "/dev/console" as the first console device before parsing "/sys/class/tty/console/active". inittab.c | 8 +++- 1 file changed, 7 insertions(+), 1