Re: [PATCH] scripts: gen_image_generic: allow FAT fs on kernel partition for non-GPT targets

2024-03-29 Thread Elliott Mitchell
On Fri, Mar 29, 2024 at 04:32:18PM +0100, Paul D wrote: > Recommend avoiding -a and -o params. > > Use instead e.g. > > [ -n "$GUID" ] || [ "$KERNELPARTTYPE" = "6" ] || [ "$KERNELPARTTYPE" = "c" ] > > https://www.shellcheck.net/wiki/SC2166 The examples pointed to amounted to "be careful with

Re: [PATCH] kernel: kmod-phy-smsc: add dependency on crc16

2024-03-29 Thread Elliott Mitchell
On Fri, Mar 29, 2024 at 09:57:04AM +0100, Robert Marko wrote: > On Thu, 28 Mar 2024 at 18:03, Tomasz Maciej Nowak wrote: > > > > From: Tomasz Maciej Nowak > > > > Introduced WoL feature needs CRC16 support. > > > > Signed-off-by: Tomasz Maciej Nowak > > --- > >

Merged: kernel: kmod-phy-smsc: add dependency on crc16

2024-03-29 Thread Robert Marko
Merged. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

uci bug

2024-03-29 Thread Paul D
When running uci from the command line, it parses files in /etc/config If other 'config' type files exist in this path, uci emits: uci: Entry not found to stderr for each non-uci type encountered. This can be confusing. Additionally, for every line printed to stderr in this process, it

Re: [PATCH] scripts: gen_image_generic: allow FAT fs on kernel partition for non-GPT targets

2024-03-29 Thread Paul D
Recommend avoiding -a and -o params. Use instead e.g. [ -n "$GUID" ] || [ "$KERNELPARTTYPE" = "6" ] || [ "$KERNELPARTTYPE" = "c" ] https://www.shellcheck.net/wiki/SC2166 On 2024-03-28 18:00, Tomasz Maciej Nowak wrote: From: Tomasz Maciej Nowak Some old or proprietary bootloader recognize

Re: [PATCH] kernel: kmod-phy-smsc: add dependency on crc16

2024-03-29 Thread Tomasz Maciej Nowak
W dniu 29.03.2024 o 09:57, Robert Marko pisze: > On Thu, 28 Mar 2024 at 18:03, Tomasz Maciej Nowak wrote: >> >> From: Tomasz Maciej Nowak >> >> Introduced WoL feature needs CRC16 support. >> >> Signed-off-by: Tomasz Maciej Nowak >> --- >> package/kernel/linux/modules/netdevices.mk | 2 +- >> 1

[PATCH v2] kernel: kmod-phy-smsc: add dependency on crc16

2024-03-29 Thread Tomasz Maciej Nowak
From: Tomasz Maciej Nowak Introduced WoL feature needs CRC16 support. Signed-off-by: Tomasz Maciej Nowak --- v1 -> v2 - strictly depend on 6.6 version package/kernel/linux/modules/netdevices.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] kernel: kmod-phy-smsc: add dependency on crc16

2024-03-29 Thread Robert Marko
On Thu, 28 Mar 2024 at 18:03, Tomasz Maciej Nowak wrote: > > From: Tomasz Maciej Nowak > > Introduced WoL feature needs CRC16 support. > > Signed-off-by: Tomasz Maciej Nowak > --- > package/kernel/linux/modules/netdevices.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff