Re: [PATCH] base-files: reduce IPv6 ULA prefix generation to a single call

2024-04-02 Thread Elliott Mitchell
On Wed, Apr 03, 2024 at 12:50:50AM +0200, Paul D wrote: > On 2024-04-02 23:00, Elliott Mitchell wrote: > > Second, appears the ${parameter:offset:length} may not be POSIX. I > > dislike this, but do not object since OpenWRT's shell is built with this > > functionality enab

Re: [PATCH] base-files: reduce IPv6 ULA prefix generation to a single call

2024-04-02 Thread Elliott Mitchell
On Tue, Apr 02, 2024 at 02:36:36PM +0200, Paul Donald wrote: > Tested on: 23.05.3 > > Signed-off-by: Paul Donald > --- > .../files/etc/uci-defaults/12_network-generate-ula | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git >

Re: Conclusions from CVE-2024-3094 (libxz disaster)

2024-03-30 Thread Elliott Mitchell
Reordering since I want to respond to different bits in a different order... On Sat, Mar 30, 2024 at 03:30:49PM +, Daniel Golle wrote: > > Hiding a malicious change in a commit is infinitely harder than hiding > it in a tarball. Yet most of the exploit/payload found so far was in commits,

Re: [PATCH] scripts: gen_image_generic: allow FAT fs on kernel partition for non-GPT targets

2024-03-29 Thread Elliott Mitchell
On Fri, Mar 29, 2024 at 04:32:18PM +0100, Paul D wrote: > Recommend avoiding -a and -o params. > > Use instead e.g. > > [ -n "$GUID" ] || [ "$KERNELPARTTYPE" = "6" ] || [ "$KERNELPARTTYPE" = "c" ] > > https://www.shellcheck.net/wiki/SC2166 The examples pointed to amounted to "be careful with

Re: [PATCH] kernel: kmod-phy-smsc: add dependency on crc16

2024-03-29 Thread Elliott Mitchell
On Fri, Mar 29, 2024 at 09:57:04AM +0100, Robert Marko wrote: > On Thu, 28 Mar 2024 at 18:03, Tomasz Maciej Nowak wrote: > > > > From: Tomasz Maciej Nowak > > > > Introduced WoL feature needs CRC16 support. > > > > Signed-off-by: Tomasz Maciej Nowak > > --- > >

Re: [PATCH] scripts: create kernel configuration upgrade script

2024-03-24 Thread Elliott Mitchell
On Sat, Mar 23, 2024 at 07:56:01PM +0100, Stijn Segers wrote: > > Op zondag 3 maart 2024 om 15:24:50 -08:00:00 schreef Elliott Mitchell > : > > Date: Tue, 6 Feb 2024 17:16:41 -0800 > > > > Create a script for automating kernel version changes. This > > genera

Re: Purpose of openwrt-devel?

2024-03-23 Thread Elliott Mitchell
On Sat, Mar 23, 2024 at 10:02:39PM +0100, Olliver Schinagl wrote: > On 23-03-2024 18:51, Elliott Mitchell wrote: > > On Sat, Mar 23, 2024 at 03:15:44AM +0100, Olliver Schinagl wrote: > > > >>> Odd thing about what you put in parentheses. I've been trying to get a &

Re: Purpose of openwrt-devel?

2024-03-23 Thread Elliott Mitchell
On Sat, Mar 23, 2024 at 03:15:44AM +0100, Olliver Schinagl wrote: > > On March 21, 2024 10:28:29 p.m. GMT+01:00, Elliott Mitchell > wrote: > >On Thu, Mar 21, 2024 at 10:00:46AM +0100, Olliver Schinagl wrote: > >> On 20-03-2024 01:34, Elliott Mitchell wrote: > >>

Re: Purpose of openwrt-devel?

2024-03-21 Thread Elliott Mitchell
On Thu, Mar 21, 2024 at 10:00:46AM +0100, Olliver Schinagl wrote: > On 20-03-2024 01:34, Elliott Mitchell wrote: > > On Mon, Mar 18, 2024 at 10:53:12AM +0100, Olliver Schinagl wrote: > >> I expect this to be done very rarely and by users that know what they > >> are

Re: Purpose of openwrt-devel?

2024-03-19 Thread Elliott Mitchell
On Mon, Mar 18, 2024 at 10:53:12AM +0100, Olliver Schinagl wrote: > I expect this to be done very rarely and by users that know what they > are doing, but just "automating" a few logical git commands. > > Performance is not a key-driver here. It's too rarely used. True, though being faster is

Re: Purpose of openwrt-devel?

2024-03-17 Thread Elliott Mitchell
On Sat, Mar 16, 2024 at 02:19:27PM +0800, Chuanhong Guo wrote: > > On Sat, Mar 16, 2024 at 11:41 AM Elliott Mitchell > wrote: > > > > Since `git fast-import` is a direct interface to Git's back-end, the > > > > working tree doesn't need to be modified to opera

Re: Purpose of openwrt-devel?

2024-03-17 Thread Elliott Mitchell
On Sun, Mar 17, 2024 at 11:44:45AM +0100, p...@oranjevos.nl wrote: > Op 16 mrt. 2024, om 07:46 heeft Elliott Mitchell het > volgende geschreven: > > On Sat, Mar 16, 2024 at 02:19:27PM +0800, Chuanhong Guo wrote: > >> > >> And more comments on the perl

Re: Purpose of openwrt-devel?

2024-03-16 Thread Elliott Mitchell
On Sat, Mar 16, 2024 at 02:19:27PM +0800, Chuanhong Guo wrote: > > On Sat, Mar 16, 2024 at 11:41 AM Elliott Mitchell > wrote: > > > > Anyone needing to figure out how the scripts work will need a fair bit > > of familiarity with Git. Being able to get good result

Re: Purpose of openwrt-devel?

2024-03-16 Thread Elliott Mitchell
On Sat, Mar 16, 2024 at 01:47:38PM +0800, Chuanhong Guo wrote: > On Sat, Mar 16, 2024 at 11:51 AM Elliott Mitchell > wrote: > > > > On Tue, Mar 12, 2024 at 09:11:23PM -0700, Elliott Mitchell wrote: > > > On Wed, Mar 13, 2024 at 01:55:07AM +0100, Robert Marko wrote:

Re: Purpose of openwrt-devel?

2024-03-15 Thread Elliott Mitchell
On Tue, Mar 12, 2024 at 09:11:23PM -0700, Elliott Mitchell wrote: > On Wed, Mar 13, 2024 at 01:55:07AM +0100, Robert Marko wrote: > > On Wed, 13 Mar 2024 at 01:36, Elliott Mitchell wrote: > > > > > > Then there is technical discussion. > > > > > > A r

Re: Purpose of openwrt-devel?

2024-03-15 Thread Elliott Mitchell
On Thu, Mar 14, 2024 at 11:35:15PM +0100, Olliver Schinagl wrote: > On 14-03-2024 01:50, Elliott Mitchell wrote: > > On Wed, Mar 13, 2024 at 09:43:06AM +0100, Olliver Schinagl wrote: > >> > >> The actual code of course has nothing to do with the perl script, as you

Re: Purpose of openwrt-devel?

2024-03-13 Thread Elliott Mitchell
On Wed, Mar 13, 2024 at 09:43:06AM +0100, Olliver Schinagl wrote: > On 13-03-2024 08:46, Felix Baumann wrote: > > Am 13. März 2024 05:11:23 MEZ schrieb Elliott > > Mitchell: > >> I must challenge this. If patches via the mailing list were accepted, > >&g

Re: Purpose of openwrt-devel?

2024-03-12 Thread Elliott Mitchell
On Wed, Mar 13, 2024 at 01:55:07AM +0100, Robert Marko wrote: > On Wed, 13 Mar 2024 at 01:36, Elliott Mitchell wrote: > > > > Well, what purpose does the openwrt-devel mailing list serve? > > > > As near as I can tell it looks suspiciously like it is a method to diver

Purpose of openwrt-devel?

2024-03-12 Thread Elliott Mitchell
Well, what purpose does the openwrt-devel mailing list serve? As near as I can tell it looks suspiciously like it is a method to divert developers from where everything is done. There isn't too much review activity. Anything which does get a positive review tends to simply disappear unless it

[PATCH] scripts: create kernel configuration upgrade script

2024-03-03 Thread Elliott Mitchell
for routine use. This also updates *everything*, which greatly simplifies rebasing patches which effect multiple devices. Credit to Christian Marangi who knew of the technique: <https://lists.openwrt.org/pipermail/openwrt-devel/2023-October/041672.html> Signed-off-by: Elliott Mitchell

Re: [PATCH v2] scripts: create kernel configuration upgrade script

2024-02-14 Thread Elliott Mitchell
On Wed, Feb 14, 2024 at 10:03:00AM +0100, Rafał Miłecki wrote: > On 7.02.2024 02:16, Elliott Mitchell wrote: > > diff --git a/scripts/kernel_upgrade.pl b/scripts/kernel_upgrade.pl > > new file mode 100755 > > index 00..b9fe5882a3 > > --- /dev/null > >

Re: [PATCH v2] scripts: create kernel configuration upgrade script

2024-02-13 Thread Elliott Mitchell
On Tue, Feb 06, 2024 at 05:16:41PM -0800, Elliott Mitchell wrote: > Create a script for automating kernel version changes. This > generates a pair of commits which cause history to remain attached to > all versioned configuration files. > > Crucially this makes `git blame` work

[PATCH v2] scripts: create kernel configuration upgrade script

2024-02-07 Thread Elliott Mitchell
*everything*, which greatly simplifies rebasing patches which effect multiple devices. Signed-off-by: Elliott Mitchell --- v2: Major tweaking. No longer try to do `git merge --ff-only `, but instead advise user to do so. Add usage message. Add statement about strategy. Adjust commit messages

Re: [PATCH 1/1] scripts: create kernel configuration upgrade script

2024-02-07 Thread Elliott Mitchell
On Wed, Feb 07, 2024 at 11:53:55AM +0100, Jonas Gorski wrote: > On Wed, 7 Feb 2024 at 02:48, Elliott Mitchell wrote: > > > > Create a script for automating kernel version changes. This > > generates a pair of commits which cause history to remain attached > > to all ve

[PATCH 1/1] scripts: create kernel configuration upgrade script

2024-02-06 Thread Elliott Mitchell
Create a script for automating kernel version changes. This generates a pair of commits which cause history to remain attached to all versioned configuration files. Signed-off-by: Elliott Mitchell --- scripts/kernel_upgrade.pl | 191 ++ 1 file changed, 191

Re: Linux kernel 6.1 or 6.6 for OpenWrt 24.x release?

2024-02-06 Thread Elliott Mitchell
On Sat, Feb 03, 2024 at 11:21:45AM -0800, Elliott Mitchell wrote: > On Sat, Feb 03, 2024 at 01:06:13PM +0100, Hauke Mehrtens wrote: > > > > Which kernel should we use for the next major OpenWrt release? > > We have two options and I would like to get some feedback on these:

Re: Linux kernel 6.1 or 6.6 for OpenWrt 24.x release?

2024-02-03 Thread Elliott Mitchell
On Sat, Feb 03, 2024 at 01:06:13PM +0100, Hauke Mehrtens wrote: > > Which kernel should we use for the next major OpenWrt release? > We have two options and I would like to get some feedback on these: Unless it turns out there is a pattern of people in favor of 6.1 needing longer to respond,

Re: [PATCH 1/1] kernel/x86: merge "generic" into "legacy"

2024-01-03 Thread Elliott Mitchell
On Tue, Jan 02, 2024 at 04:44:04PM -0800, Elliott Mitchell wrote: > There is a desire to reduce the time spent on x86 OpenWRT platforms. > "generic" is most suitable for removal. The few systems which could > use "generic" must now opt for "legacy" (or fo

[PATCH 1/1] kernel/x86: merge "generic" into "legacy"

2024-01-02 Thread Elliott Mitchell
There is a desire to reduce the time spent on x86 OpenWRT platforms. "generic" is most suitable for removal. The few systems which could use "generic" must now opt for "legacy" (or for a lucky few "64"). Signed-off-by: Elliott Mitchell --- target/linu

[PATCH 0/1] Nuking x86 "generic"

2024-01-02 Thread Elliott Mitchell
popular due to power consumption and poor performance. Elliott Mitchell (1): kernel/x86: merge "generic" into "legacy" target/linux/x86/Makefile | 2 +- target/linux/x86/generic/config-6.1 | 508 -- target/linux/x86/generic/target.mk

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2024-01-01 Thread Elliott Mitchell
On Sat, Nov 25, 2023 at 07:08:20AM +0100, Felix Fietkau wrote: > On 25.11.23 03:28, Elliott Mitchell wrote: > > > > All of these are plausible. I think modules selected in device > > configurations should get built and installed into the root filesystem. > > Otherw

Re: [PATCH RESEND 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"

2023-12-14 Thread Elliott Mitchell
On Thu, Dec 14, 2023 at 10:38:34AM +0100, Jonas Gorski wrote: > On Wed, 13 Dec 2023 at 23:55, Elliott Mitchell wrote: > > > > If my belief no one is using CONFIG_PINCTRL on a Geode platform is > > correct, then the original patch is correct. From examination of the >

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-12-13 Thread Elliott Mitchell
On Sat, Nov 25, 2023 at 09:36:33AM -0800, Elliott Mitchell wrote: > On Sat, Nov 25, 2023 at 07:08:20AM +0100, Felix Fietkau wrote: > > On 25.11.23 03:28, Elliott Mitchell wrote: > > > > Since there is no perfect solution, there are always some trade-offs > > involv

Re: [PATCH RESEND 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"

2023-12-13 Thread Elliott Mitchell
On Wed, Dec 13, 2023 at 01:59:07PM +0100, Martin Schiller wrote: > On 2023-12-13 02:45, Elliott Mitchell wrote: > > > > No idea, I wasn't able to find very much information when I looked at > > this. > > > > I did find: > > https://lists.openwrt.org/pip

Re: [PATCH RESEND 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"

2023-12-12 Thread Elliott Mitchell
On Tue, Dec 12, 2023 at 04:54:05PM +0100, Jonas Gorski wrote: > > On Sun, 10 Dec 2023 at 18:51, Elliott Mitchell wrote: > > > > Date: Fri, 3 Nov 2023 22:57:43 -0700 > > > > Enabling an Intel chipset feature on a platform originally made by > > National S

Re: [PATCH RESEND 02/11] kernel/generic: remove CONFIG_FB_NOTIFY

2023-12-12 Thread Elliott Mitchell
On Tue, Dec 12, 2023 at 04:48:32PM +0100, Jonas Gorski wrote: > > On Sun, 10 Dec 2023 at 18:49, Elliott Mitchell wrote: > > > > Date: Tue, 25 Apr 2023 16:23:20 -0700 > > > > This option is automatically enabled by CONFIG_FB=y. There is no > > reason to specif

[PATCH RESEND 11/11] kernel/x86: isolate board-specific files to associated architecture

2023-12-10 Thread Elliott Mitchell
Split the board.d files to isolate their data to associated architectures. Seems wasteful to include all board-specific data with every single build. Signed-off-by: Elliott Mitchell --- .../{ => 64}/base-files/etc/board.d/01_leds | 5 - .../base-files/etc/board.d/02_network |

[PATCH RESEND 09/11] kernel/x86: remove CONFIG_M686 from common configuration

2023-12-10 Thread Elliott Mitchell
Date: Mon, 17 Apr 2023 08:21:26 -0700 All of the sublevels choose their own values, so there is no point in the common file having anything. This also removes a warning from the kernel build process. Signed-off-by: Elliott Mitchell Reviewed-by: Philip Prindeville 04/2023 --- target/linux/x86

[PATCH RESEND 10/11] packages/x86: detect architecture, not x86/64 target

2023-12-10 Thread Elliott Mitchell
Date: Mon, 27 Feb 2023 17:24:27 -0800 These spots should be detecting the amd64 architecture, not the specific target name. If additional amd64 targets were added, or the target was renamed, these would fail to build. Signed-off-by: Elliott Mitchell --- package/firmware/intel-microcode

[PATCH RESEND 05/11] kernel/x86: remove CONFIG_HDMI

2023-12-10 Thread Elliott Mitchell
Date: Tue, 31 Oct 2023 11:06:58 -0700 This is an internal boolean value. The value routinely gets overriden and should never be overtly set. Signed-off-by: Elliott Mitchell --- target/linux/x86/64/config-5.15 | 1 - target/linux/x86/64/config-6.1 | 1 - target/linux/x86/generic

[PATCH RESEND 07/11] kernel/x86: move Geode HW random from generic to geode

2023-12-10 Thread Elliott Mitchell
Date: Wed, 19 Apr 2023 14:07:47 -0700 Quite reasonable to have support for the Geode HW random number generator. On the Geode kernel. Signed-off-by: Elliott Mitchell --- target/linux/x86/config-5.15 | 1 - target/linux/x86/config-6.1| 1 - target/linux/x86/geode/config-5.15 | 1

[PATCH RESEND 08/11] kernel/x86: move SCx200 support from generic to geode

2023-12-10 Thread Elliott Mitchell
Date: Thu, 13 Apr 2023 17:07:20 -0700 The SCx200 is part of the Geode platform. As such generic x86 doesn't need the driver, but Geode does. Signed-off-by: Elliott Mitchell Reviewed-by: Philip Prindeville 04/2023 --- target/linux/x86/config-5.15 | 5 + target/linux/x86/config-6.1

[PATCH RESEND 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"

2023-12-10 Thread Elliott Mitchell
Date: Fri, 3 Nov 2023 22:57:43 -0700 Enabling an Intel chipset feature on a platform originally made by National Semiconductor and later bought by AMD. Could we cut the Intel enthusiasm? This reverts commit 4eda2fddf2995c8ade2b1e0faddc8ce1f1e0ec5f. Signed-off-by: Elliott Mitchell --- target

[PATCH RESEND 04/11] kernel: remove ext2 support from kernel

2023-12-10 Thread Elliott Mitchell
Date: Tue, 9 May 2023 13:57:31 -0700 While functional and small during its time, ext2 support should no longer be enabled by default. For most purposes aside from memory footprint, ext4 is rather superior. Time to play Taps. Signed-off-by: Elliott Mitchell --- I haven't done builds

[PATCH RESEND 03/11] kernel: purge CONFIG_FS_MBCACHE

2023-12-10 Thread Elliott Mitchell
Date: Tue, 9 May 2023 14:36:00 -0700 There is no point in attempting to set CONFIG_FS_MBCACHE. The way the Kconfig files are setup, your choice will be overridden. As such there isn't any point in documenting a default. Signed-off-by: Elliott Mitchell --- target/linux/archs38/config-5.15

[PATCH RESEND 01/11] kernel: change CONFIG_HW_RANDOM default to y

2023-12-10 Thread Elliott Mitchell
Date: Sat, 22 Apr 2023 10:46:30 -0700 Many devices do not have hardware random number generators. Yet more do than don't, and they are becoming more common. Signed-off-by: Elliott Mitchell --- v2: As requested, since there is a dislike of =n even though it works fine with all tools

[PATCH RESEND 00/11] Misc kernel config cleanup and small adjustments

2023-12-10 Thread Elliott Mitchell
of cleanup done sooner, rather than later would be helpful. Elliott Mitchell (11): kernel: change CONFIG_HW_RANDOM default to y kernel/generic: remove CONFIG_FB_NOTIFY kernel: purge CONFIG_FS_MBCACHE kernel: remove ext2 support from kernel kernel/x86: remove CONFIG_HDMI Revert "x86/

[PATCH RESEND 02/11] kernel/generic: remove CONFIG_FB_NOTIFY

2023-12-10 Thread Elliott Mitchell
Date: Tue, 25 Apr 2023 16:23:20 -0700 This option is automatically enabled by CONFIG_FB=y. There is no reason to specifically enable it. Signed-off-by: Elliott Mitchell Reviewed-by: Philip Prindeville 04/2023 --- target/linux/generic/config-5.15 | 1 - target/linux/generic/config-6.1 | 1

Re: [PATCH] ipq95xx: Add support for IPQ9574 RDP433

2023-12-08 Thread Elliott Mitchell
On Fri, Dec 08, 2023 at 06:53:31PM +0100, Thibaut wrote: > > > Le 8 déc. 2023 à 16:39, Elliott Mitchell a écrit : > > > > On Fri, Dec 08, 2023 at 11:14:38AM +0100, Robert Marko wrote: > >> On Fri, 8 Dec 2023 at 11:13, Piotr Dymacz wrote: > >>> &g

Re: [PATCH] ipq95xx: Add support for IPQ9574 RDP433

2023-12-08 Thread Elliott Mitchell
On Fri, Dec 08, 2023 at 11:14:38AM +0100, Robert Marko wrote: > On Fri, 8 Dec 2023 at 11:13, Piotr Dymacz wrote: > > > > On 8.12.2023 11:02, Robert Marko wrote: > > > On Fri, 8 Dec 2023 at 11:01, Piotr Dymacz wrote: > > >> > > >> Would it make sense to rename qualcommax to qualcomm and make

[PATCH 5/5] build: remove shell.sh

2023-12-04 Thread Elliott Mitchell
Handling common shell usage may have been valuable in the past. Yet now this is almost unused, so inline the single remaining use. Then delete the old file. Signed-off-by: Elliott Mitchell --- I've tried to test the removal. I'm unsure I actually achieved coverage, so a careful look

[PATCH 4/5] scripts/kconfig.pl: consistently call parse_expr() with 2 args

2023-12-04 Thread Elliott Mitchell
The inconsistent calling had already been noticed. Now the trap has been spotted, so clean this up. Signed-off-by: Elliott Mitchell --- scripts/kconfig.pl | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/kconfig.pl b/scripts/kconfig.pl index 5a53e2154b

[PATCH 3/5] scripts/kconfig.pl: switch to using function references/hash for operators

2023-12-04 Thread Elliott Mitchell
Ah, the wonders of pointers. Simplifies the configuration parsing as all these cases are otherwise identical. Signed-off-by: Elliott Mitchell --- Oy vey. I only spotted passing the second arg to parse_expr() *just* before I was initially planning to send this. That is quite the boody trap

[PATCH 2/5] scripts/kconfig.pl: modify config_and()/config_sub() to match other ops

2023-12-04 Thread Elliott Mitchell
Having all operator-handling functions match the same prototype has advantages. Signed-off-by: Elliott Mitchell --- scripts/kconfig.pl | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/kconfig.pl b/scripts/kconfig.pl index f7b3814cdd..dd286479b3 100755

[PATCH 0/5] Scripting tweaks

2023-12-04 Thread Elliott Mitchell
, this is what spam has done to e-mail. It used to be rather faster and more reliable than letters, yet now. Elliott Mitchell (5): scripts/kconfig.pl: fixup subroutine style scripts/kconfig.pl: modify config_and()/config_sub() to match other ops scripts/kconfig.pl: switch to using

[PATCH 1/5] scripts/kconfig.pl: fixup subroutine style

2023-12-04 Thread Elliott Mitchell
Match usual Perl style to make the operation of the script easier to understand for future developers. Signed-off-by: Elliott Mitchell --- scripts/kconfig.pl | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/scripts/kconfig.pl b/scripts/kconfig.pl

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-11-25 Thread Elliott Mitchell
On Sat, Nov 25, 2023 at 07:08:20AM +0100, Felix Fietkau wrote: > On 25.11.23 03:28, Elliott Mitchell wrote: > > On Fri, Nov 24, 2023 at 01:53:01PM +0100, Jonas Gorski wrote: > >> > > I'm fine with the cp -l change, but I think adding all remaining > >> &

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-11-24 Thread Elliott Mitchell
On Fri, Nov 24, 2023 at 01:53:01PM +0100, Jonas Gorski wrote: > > On Mon, 20 Nov 2023 at 02:37, Elliott Mitchell wrote: > > > > On Sat, Nov 18, 2023 at 07:57:35AM +0100, Felix Fietkau wrote: > > > On 17.11.23 22:31, Elliott Mitchell wrote: > > > > On Fri,

Re: [PATCH 11/20] [WIP] package/target: update to get modules from $(LINUX_OBJ_DIR)

2023-11-19 Thread Elliott Mitchell
On Sat, Nov 11, 2023 at 10:51:08PM -0800, Elliott Mitchell wrote: > Modules built from kernel source will now be in $(LINUX_OBJ_DIR). > > Signed-off-by: Elliott Mitchell > --- > package/kernel/linux/modules/block.mk| 106 +++ > package/kernel/linux/modules/can

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-11-19 Thread Elliott Mitchell
On Sat, Nov 18, 2023 at 07:57:35AM +0100, Felix Fietkau wrote: > On 17.11.23 22:31, Elliott Mitchell wrote: > > On Fri, Nov 17, 2023 at 05:20:33PM +0100, Felix Fietkau wrote: > >> On 11.11.23 01:21, Elliott Mitchell wrote: > >> > This removes the requirement for to cr

Re: Adding a new x86 image or related packages to the default x86 image

2023-11-17 Thread Elliott Mitchell
On Tue, Nov 14, 2023 at 03:44:57AM +, Daniel Golle wrote: > On Mon, Nov 13, 2023 at 06:26:04PM -0800, Elliott Mitchell wrote: > > > > Each hypervisor will have a small set of drivers guaranteed to be > > present. These though will be completely different between hyp

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-11-17 Thread Elliott Mitchell
On Fri, Nov 17, 2023 at 05:20:33PM +0100, Felix Fietkau wrote: > On 11.11.23 01:21, Elliott Mitchell wrote: > > This removes the requirement for to create a package for all modules. > > Now devices can simply specify in-tree drivers/other to be built as > > modules and

Re: [PATCH 20/20] [TEST] TESTING: try separating build from sources

2023-11-16 Thread Elliott Mitchell
4\_|_/___/5445 >From f646cfb21288df884534d60ed17a075d9661e9b9 Mon Sep 17 00:00:00 2001 Message-Id: From: Elliott Mitchell Date: Thu, 16 Nov 2023 14:16:01 -0800 Subject: [PATCH] kernel/generic: fix lzma addition patch When including directories, the full path must be used. Otherwise the compiler

Xen VM Configuration example

2023-11-16 Thread Elliott Mitchell
I'm sending this to the list to provide another approach to this type of installation. I feel this is better adapted to the situation than the currently visible examples. Feel free to use this information in the OpenWRT wiki. Hopefully this is also a better example of a real world OpenWRT in VM

Re: [PATCH 06/20] kernel: remove drivers marked as modules

2023-11-15 Thread Elliott Mitchell
On Wed, Nov 15, 2023 at 11:29:23AM +0100, Bjørn Mork wrote: > Elliott Mitchell writes: > > > Previously these would get built, then simply omitted from the > > resultant image. > > A kernel image built with a config symbol set to 'm' is sometimes > deliberately diff

Re: [PATCH 11/11] kernel/x86: enable x32 support for amd64

2023-11-15 Thread Elliott Mitchell
On Wed, Nov 15, 2023 at 10:36:21AM +0100, Stefan Lippers-Hollmann wrote: > > On 2023-11-14, Elliott Mitchell wrote: > > > I don't know the future, but enabling kernel support is the first step. > > If you wanted to add it to Debian (with working a multi-arch > implem

Re: [PATCH 11/11] kernel/x86: enable x32 support for amd64

2023-11-14 Thread Elliott Mitchell
On Wed, Nov 15, 2023 at 05:35:11AM +0100, Stefan Lippers-Hollmann wrote: > > On 2023-11-14, Elliott Mitchell wrote: > > Date: Thu, 30 Mar 2023 16:30:49 -0700 > > > > Full amd64 support isn't really appropriate for most situations > > OpenWRT is deployed. W

Re: [PATCH 08/11] kernel/x86: move SCx200 support from generic to geode

2023-11-14 Thread Elliott Mitchell
On Wed, Nov 15, 2023 at 05:05:00AM +0100, Stefan Lippers-Hollmann wrote: > > On 2023-11-14, Elliott Mitchell wrote: > > Date: Thu, 13 Apr 2023 17:07:20 -0700 > > > > The SCx200 is part of the Geode platform. As such generic x86 > > doesn't need the driver, but

[PATCH 20/20] [TEST] TESTING: try separating build from sources

2023-11-14 Thread Elliott Mitchell
Check whether all the spots have been handled. This hasn't been tried in a long while, I doubt I've got everything right. Signed-off-by: Elliott Mitchell --- include/kernel.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/kernel.mk b/include/kernel.mk index

[PATCH 19/20] [WIP] build: point remainder at $(LINUX_SRC_DIR)

2023-11-14 Thread Elliott Mitchell
These appear to need the kernel source, but my confidence is less than certain on several spots. Signed-off-by: Elliott Mitchell --- include/kernel-defaults.mk | 6 +++--- package/kernel/cryptodev-linux/Makefile | 2 +- package/kernel/linux/modules/w1.mk | 4 ++-- package

[PATCH 18/20] [WIP] build: point remaining obvious cases at $(LINUX_SRC_DIR)

2023-11-14 Thread Elliott Mitchell
make -C is most often needs the kernel source. The copyright files come from the kernel source. Signed-off-by: Elliott Mitchell --- I'm running out of steam on this. These seem fairly clear, but I'm less than 100% certain. --- package/devel/kselftests-bpf/Makefile | 2 +- package/kernel

[PATCH 17/20] [WIP] build: split kernel object directory from kernel source directory

2023-11-14 Thread Elliott Mitchell
Allows for reusing a kernel source directory for multiple builds. Alternatively allows cleaning out an old kernel build without needing to delete source files. Signed-off-by: Elliott Mitchell --- I'll confess I'm less than certain about several of these. From looking I *think* they need

[PATCH 16/20] [WIP] build: point kernel build tasks at $(LINUX_OBJ_DIR)

2023-11-14 Thread Elliott Mitchell
This points uses of .config, .modules, and vmlinux at the correct place. This is one portion of the source/build split. Signed-off-by: Elliott Mitchell --- Note for reviewers. It is easy to miss the `mkdir` added to Kernel/Configure/Default. That was needed since the directory might not have

[PATCH 15/20] [WIP] package: update packages with explicit make flags

2023-11-14 Thread Elliott Mitchell
Identifying which variable to substitute in appropriate places is a bit interesting here. Since these set their own make flags, they need to reference both. Signed-off-by: Elliott Mitchell --- I'm less than certain about perf. I *hope* this matches the requirements, but I'm worried about

[PATCH 14/20] [WIP] build: update quilt references to use $(LINUX_SRC_DIR)

2023-11-14 Thread Elliott Mitchell
Quilt is for handling patches, therefore needs to modify $(LINUX_SRC_DIR). Signed-off-by: Elliott Mitchell --- include/kernel-build.mk| 2 +- include/kernel-defaults.mk | 2 +- include/quilt.mk | 16 3 files changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH 13/20] [WIP] build: point user_headers at $(LINUX_OBJ_DIR)

2023-11-14 Thread Elliott Mitchell
These may be regenerated with every build. As such they seem appropriate for the object directory, rather than source. Signed-off-by: Elliott Mitchell --- include/kernel-defaults.mk | 6 +++--- package/devel/strace/Makefile| 2 +- package/network/config/swconfig

[PATCH 12/20] [WIP] build: adjust include paths to use LINUX_SRC_DIR/LINUX_OBJ_DIR

2023-11-14 Thread Elliott Mitchell
Most headers come out of the source. Some spots also reference the kernel build directory. Signed-off-by: Elliott Mitchell --- include/image.mk | 3 ++- include/kernel.mk| 2 +- package/devel/perf/Makefile | 2

[PATCH 10/20] [WIP] build: use dtc from $(LINUX_OBJ_DIR)

2023-11-14 Thread Elliott Mitchell
As an executable built from source, the Device-Tree Compiler lives in the object directory. Update references to point there. Signed-off-by: Elliott Mitchell --- include/image-commands.mk | 6 +++--- include/image.mk| 2 +- include/trusted

[PATCH 09/20] [WIP] build: split $(DTB_DIR) off of $(DTS_DIR)

2023-11-14 Thread Elliott Mitchell
This has an issue similar to $(LINUX_DIR), $(DTS_DIR) was being used for both source and compiled. Create $(DTB_DIR) for the compiled binaries. Signed-off-by: Elliott Mitchell --- Issue with this commit is I'm unsure I've gotten everything and unsure I've gotten the ones I found correct

[PATCH 08/20] build: add make variables for kernel source and object directories

2023-11-14 Thread Elliott Mitchell
Precursor to splitting the two apart. Linux kernel sources can be reused for multiple kernel builds with different configurations. The object directory cannot be reused. Signed-off-by: Elliott Mitchell --- include/kernel.mk | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

[PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-11-14 Thread Elliott Mitchell
This removes the requirement for to create a package for all modules. Now devices can simply specify in-tree drivers/other to be built as modules and they will be present in the resultant image. Signed-off-by: Elliott Mitchell --- I'm pretty sure this is the right general approach. Why build

[PATCH 06/20] kernel: remove drivers marked as modules

2023-11-14 Thread Elliott Mitchell
Previously these would get built, then simply omitted from the resultant image. This behavior is expected to change in the future, so remove these to avoid changing installed modules. Signed-off-by: Elliott Mitchell --- target/linux/armsr/armv8/config-6.1 | 2 +- target/linux/ixp4xx

[PATCH 05/20] build: merge Kernel/Prepare steps together

2023-11-14 Thread Elliott Mitchell
Date: Mon, 30 Oct 2023 14:46:24 -0700 The two Kernel/Prepare/Default implementations had become identical. As such merge the identical sections together, and only have the extra piece be conditional. Signed-off-by: Elliott Mitchell --- include/kernel-defaults.mk | 12 1 file

[PATCH 04/20] patch: always backup files

2023-11-14 Thread Elliott Mitchell
Date: Thu, 26 Oct 2023 18:44:33 -0700 Avoiding modification of the original files allows their reuse. This is a first step towards being able to reuse unpacked kernel (or other) source. Signed-off-by: Elliott Mitchell --- include/autotools.mk| 2 +- scripts/patch-kernel.sh | 2 +- 2 files

[PATCH 03/20] bcm27xx: fix device-tree support patch for split source/build dirs

2023-11-14 Thread Elliott Mitchell
The kernel source directory needs to be in the include path for compilation. This fixes separated build snd source directory functioning. Signed-off-by: Elliott Mitchell --- This is really meant as a PoC fix. This works, but doesn't seem to quite match the existing style. I'm also unsure

[PATCH 02/20] package/lantiq: use make -C instead of `cd;`

2023-11-14 Thread Elliott Mitchell
The effect is the same, but this reduces work by the shell. This is generally preferred unless multiple commands need to be run in the target directory. Signed-off-by: Elliott Mitchell --- package/kernel/lantiq/ltq-adsl-mei/Makefile | 5 ++--- package/kernel/lantiq/ltq-atm/Makefile | 5

[PATCH 00/20] Kernel build fixups, split object directory off (partial WIP)

2023-11-14 Thread Elliott Mitchell
the instances of where $(LINUX_DIR) used to be used. The earlier ones are more likely to be right, the later ones I'm rather unsure of. These need a lot of checking. Patch #20 is simply a test case for people to check things with. Elliott Mitchell (20): ppp: make copy of compiler_types.h unconditional

[PATCH 01/20] ppp: make copy of compiler_types.h unconditional

2023-11-14 Thread Elliott Mitchell
04cb1e0fd2 was implemented to avoid failures with kernels before 4.14.9. At this point OpenWRT no longer supports earlier kernels, so make the copy fail if compiler_types.h doesn't exist. Updates: 04cb1e0fd2 ("ppp: fix build with kernel 4.14.9+") Signed-off-by: Elliott Mitchell --

[PATCH 10/11] packages/x86: detect architecture, not x86/64 target

2023-11-14 Thread Elliott Mitchell
Date: Mon, 27 Feb 2023 17:24:27 -0800 These spots should be detecting the amd64 architecture, not the specific target name. If additional amd64 targets were added, or the target was renamed, these would fail to build. Signed-off-by: Elliott Mitchell --- package/firmware/intel-microcode

[PATCH 11/11] kernel/x86: enable x32 support for amd64

2023-11-14 Thread Elliott Mitchell
the kernel build breaks. Signed-off-by: Elliott Mitchell --- I suggest OpenWRT should place some effort towards x86-x32. x86-x32 seems a rather superior generic target for OpenWRT. Only issue is it could be valuable to have at least minimal amd64 userland support alongside the x86-x32 version

[PATCH 09/11] kernel/x86: remove CONFIG_M686 from common configuration

2023-11-14 Thread Elliott Mitchell
Date: Mon, 17 Apr 2023 08:21:26 -0700 All of the sublevels choose their own values, so there is no point in the common file having anything. This also removes a warning from the kernel build process. Signed-off-by: Elliott Mitchell Reviewed-by: Philip Prindeville 04/2023 --- target/linux/x86

[PATCH 08/11] kernel/x86: move SCx200 support from generic to geode

2023-11-14 Thread Elliott Mitchell
Date: Thu, 13 Apr 2023 17:07:20 -0700 The SCx200 is part of the Geode platform. As such generic x86 doesn't need the driver, but Geode does. Signed-off-by: Elliott Mitchell Reviewed-by: Philip Prindeville 04/2023 --- target/linux/x86/config-5.15 | 5 + target/linux/x86/config-6.1

[PATCH 07/11] kernel/x86: move Geode HW random from generic to geode

2023-11-14 Thread Elliott Mitchell
Date: Wed, 19 Apr 2023 14:07:47 -0700 Quite reasonable to have support for the Geode HW random number generator. On the Geode kernel. Signed-off-by: Elliott Mitchell --- target/linux/x86/config-5.15 | 1 - target/linux/x86/config-6.1| 1 - target/linux/x86/geode/config-5.15 | 1

[PATCH 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"

2023-11-14 Thread Elliott Mitchell
Enabling an Intel chipset feature on a platform originally made by National Semiconductor and later bought by AMD. Could we cut the Intel enthusiasm? This reverts commit 4eda2fddf2995c8ade2b1e0faddc8ce1f1e0ec5f. Signed-off-by: Elliott Mitchell --- target/linux/x86/geode/config-5.15 | 18

[PATCH 05/11] kernel/x86: remove CONFIG_HDMI

2023-11-14 Thread Elliott Mitchell
Date: Tue, 31 Oct 2023 11:06:58 -0700 This is an internal boolean value. The value routinely gets overriden and should never be overtly set. Signed-off-by: Elliott Mitchell --- target/linux/x86/64/config-5.15 | 1 - target/linux/x86/64/config-6.1 | 1 - target/linux/x86/generic

[PATCH 04/11] kernel: remove ext2 support from kernel

2023-11-14 Thread Elliott Mitchell
Date: Tue, 9 May 2023 13:57:31 -0700 While functional and small during its time, ext2 support should no longer be enabled by default. For most purposes aside from memory footprint, ext4 is rather superior. Time to play Taps. Signed-off-by: Elliott Mitchell --- I haven't done builds

[PATCH 03/11] kernel: purge CONFIG_FS_MBCACHE

2023-11-14 Thread Elliott Mitchell
Date: Tue, 9 May 2023 14:36:00 -0700 There is no point in attempting to set CONFIG_FS_MBCACHE. The way the Kconfig files are setup, your choice will be overridden. As such there isn't any point in documenting a default. Signed-off-by: Elliott Mitchell --- target/linux/archs38/config-5.15

[PATCH 01/11] kernel: change CONFIG_HW_RANDOM default to y

2023-11-14 Thread Elliott Mitchell
Date: Sat, 22 Apr 2023 10:46:30 -0700 Many devices do not have hardware random number generators. Yet more do than don't, and they are becoming more common. Signed-off-by: Elliott Mitchell --- v2: As requested, since there is a dislike of =n even though it works fine with all tools

[PATCH 02/11] kernel/generic: remove CONFIG_FB_NOTIFY

2023-11-14 Thread Elliott Mitchell
Date: Tue, 25 Apr 2023 16:23:20 -0700 This option is automatically enabled by CONFIG_FB=y. There is no reason to specifically enable it. Signed-off-by: Elliott Mitchell Reviewed-by: Philip Prindeville 04/2023 --- target/linux/generic/config-5.15 | 1 - target/linux/generic/config-6.1 | 1

[PATCH 00/11] Misc kernel config cleanup and small adjustments

2023-11-14 Thread Elliott Mitchell
. In exchange I found two pieces of Geode hardware whose drivers were being included in every x86 kernel. There is x32 which could have value. I would like to setup an experimental build. This may be too buggy for general consumption, but having a test build for experimentation would be good. Elliott

  1   2   >