Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Josh Bendavid
wrote: > > > > On 23. Jul 2020, at 13:44, Josh Bendavid wrote: > > > > "1. Have VLAN devices on top of vlan-enabled bridges to define hotplug > > ops where applicable, so LAN could be a plain VLAN interface switch0.1 > > instead of its own bridge.&qu

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Josh Bendavid
"1. Have VLAN devices on top of vlan-enabled bridges to define hotplug ops where applicable, so LAN could be a plain VLAN interface switch0.1 instead of its own bridge." By this you mean that the creation of the switch0.1 device will trigger automatically through the hotplug op "bridge vlan add

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Josh Bendavid
Another option, as long as the standard method is to attach a wireless interface to a bridge though the "option network" in the wifi-ifaces, would be to add a corresponding "option pvid" to wifi-ifaces which could then be propagated to the bridge when the wifi interface is added. On Thu, 23 Jul

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Josh Bendavid
Ok sure, but the documentation currently says "As WLAN interface names may be dynamic or unpredictable, it is strongly recommended that they be assigned to bridges using the network option in UCI wireless configuration" This is referring to the list of interfaces for the bridge, but presumably

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Josh Bendavid
Ok thanks, I agree this makes much more sense. As Luiz mentioned earlier, this exposes more explicitly the awkwardness of the "network" option for wifi-iface pointing to an interface rather than a device. Related to this, is it possible to add a wireless interface to a bridge specifying a

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-22 Thread Josh Bendavid
One thing which is a bit awkward as long as the bridge itself is configured as an interface, is that as far as I have understood, creating a tagged interface to the bridge requires first setting up an interface for the bridge, e.g. with protocol Unmanaged, and then setting up one or more vlan

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Josh Bendavid
I guess the vlan_default_pvid setting would fit into the config device block in this scheme? On Wed, 15 Jul 2020 at 09:59, Jo-Philipp Wich wrote: > > Hi, > > > Changes: > > - The device is created as a netifd bridge > > - Bridge vlan sections should always refer to the bridge instead of > >

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-14 Thread Josh Bendavid
Ok thanks. I think my main point was not that this belongs in interface per-se, but that it makes sense for the configuration of vlan tagging to apply to bridges in general (and to have as little as possible special handling of dsa in uci, since the logic is that it should be possible to configure

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-14 Thread Josh Bendavid
Hi, I have a somewhat radical comment on this. As far as I understand, the vlan filtering support in the linux bridge subsystem is not specific to dsa, but can equally be configured for a pure software bridge. The fact that the switch supports dsa/switchdev then simply allows this to be

[OpenWrt-Devel] [PATCH 1/3] ipq806x: add support for TP-Link Archer C2600 to makefiles, configs, scripts and device tree

2016-01-03 Thread Josh Bendavid
build does not boot currently. Not tested: Hardware buttons. Signed-off-by: Josh Bendavid <joshbenda...@gmail.com> --- .../linux/ipq806x/base-files/etc/board.d/01_leds | 7 + .../ipq806x/base-files/etc/board.d/02_network | 3 +- .../etc/hotplug.d/firmware/11-ath10k-caldata

[OpenWrt-Devel] [PATCH 2/3] firmware-utils: add support for TP-Link Archer C2600 to tplink-safeloader

2016-01-03 Thread Josh Bendavid
Add support for TP-Link Archer C2600 to tplink-safeloader including partition table and additional SupportList strings. Both factory and sysupgrade images are supported. Signed-off-by: Josh Bendavid <joshbenda...@gmail.com> --- tools/firmware-utils/src/tplink-safeloader.c

[OpenWrt-Devel] [PATCH] mac80211: bypass otp check in ath10k initialization (needed for TP-Link Archer C2600)

2015-12-25 Thread Josh Bendavid
: http://lists.infradead.org/pipermail/ath10k/2015-November/006489.html. This has also been discussed a bit further on the ath10k list here: http://lists.infradead.org/pipermail/ath10k/2015-December/006613.html. Signed-off-by: Josh Bendavid <joshbenda...@gmail.com> --- .../kernel/ma

[OpenWrt-Devel] [PATCH 1/3] ipq806x: add support for TP-Link Archer C2600 image building and ath10k initialization

2015-12-24 Thread Josh Bendavid
: wireless status led's (these are not controlled through gpio, but rather through the QCA9980 pcie chips). Also there is no way to set the wan led to orange, which is possible in the stock firmware. Kernel 4.1 build does not boot currently. Not tested: Hardware buttons. Signed-off-by: Josh Bendavid

[OpenWrt-Devel] [PATCH 2/3] ipq806x: add device tree for TP-Link Archer C2600

2015-12-24 Thread Josh Bendavid
The device tree file is similar to the current ap148 dts, with sata and nand removed, and buttons/led's added. Signed-off-by: Josh Bendavid <joshbenda...@gmail.com> --- ...qcom-add-TP-Link-Archer-C2600-device-tree.patch | 300 + ...qcom-add-TP-Link-Archer-C2600-

[OpenWrt-Devel] [PATCH 2/3] initial support for TP-Link Archer C2600

2015-12-17 Thread Josh Bendavid
The device tree file is similar to the current ap148 dts, with sata and nand removed, and buttons/led's added. Signed-off-by: Josh Bendavid <joshbenda...@gmail.com> --- ...qcom-add-TP-Link-Archer-C2600-device-tree.patch | 300 + ...qcom-add-TP-Link-Archer-C2600-

[OpenWrt-Devel] [PATCH 1/3] initial support for TP-Link Archer C2600

2015-12-17 Thread Josh Bendavid
build does not boot currently. Not tested: Hardware buttons. Signed-off-by: Josh Bendavid <joshbenda...@gmail.com> --- include/image.mk | 11 .../linux/ipq806x/base-files/etc/board.d/01_leds | 7 +++ .../ipq806x/base-files/etc/board.d/02_network

[OpenWrt-Devel] [PATCH 3/3] initial support for TP-Link Archer C2600

2015-12-17 Thread Josh Bendavid
-off-by: Josh Bendavid <joshbenda...@gmail.com> --- .../mac80211/patches/941-ath10k_skip_otp_check.patch | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 package/kernel/mac80211/patches/941-ath10k_skip_otp_check.patch diff --git a/package/kernel/mac80211/p

Re: [OpenWrt-Devel] [PATCH 1/3] initial support for TP-Link Archer C2600

2015-12-17 Thread Josh Bendavid
(Sorry, missed the changes to tplink-safeloader in firmware tools here, have submitted a separate patch with just those) On 17 December 2015 at 13:34, Josh Bendavid <joshbenda...@gmail.com> wrote: > Add initial support for Archer C2600 to Makefiles and profiles along with > needed m

[OpenWrt-Devel] [PATCH] support for TP-Link Archer C2600 for tplink-safeloader

2015-12-17 Thread Josh Bendavid
Needed modifications to tplink-safeloader to builder Archer C2600 images. Adds partition table and support list strings and properly uses them. Signed-off-by: Josh Bendavid <joshbenda...@gmail.com> --- tools/firmware-utils/src/tplink-safeloader.c | 114 ++-

[OpenWrt-Devel] [PATCH] [ipq806x] Add initial support for TP-Link Archer C2600

2015-12-13 Thread Josh Bendavid
From: Josh Bendavid <joshbenda...@gmail.com> Add initial support for Archer C2600 to Makefiles and profiles along with needed modifications to tplink-safeloader in firmware-tools. The device tree file is similar to the current ap148 dts, with sata and nand removed, and buttons/led's

[OpenWrt-Devel] [PATCH] [ipq806x] initial support for TP-Link Archer C2600

2015-12-13 Thread Josh Bendavid
From: Josh Bendavid <joshbenda...@gmail.com> Add initial support for Archer C2600 to Makefiles and profiles along with needed modifications to tplink-safeloader in firmware-tools. The device tree file is similar to the current ap148 dts, with sata and nand removed, and buttons/led's

Re: [OpenWrt-Devel] [PATCH] [ipq806x] Add initial support for TP-Link Archer C2600

2015-12-07 Thread Josh Bendavid
(the vlan configuration inherited from the AP148 is working, which implies that the connections and port mapping are the same) On 7 December 2015 at 16:57, Josh Bendavid <josh.benda...@cern.ch> wrote: > Ok thanks, > Will clean up the white space + board name and resubmit

Re: [OpenWrt-Devel] [PATCH] [ipq806x] Add initial support for TP-Link Archer C2600

2015-12-07 Thread Josh Bendavid
; On Sun, Dec 6, 2015 at 3:20 PM, Josh Bendavid <josh.benda...@cern.ch> > wrote: > > From: Josh Bendavid <joshbenda...@gmail.com> > > > > Add initial support for Archer C2600 to Makefiles and profiles. This is > > sufficient to build a working factory image. S

Re: [OpenWrt-Devel] [PATCH] [ipq806x] Add initial support for TP-Link Archer C2600

2015-12-06 Thread Josh Bendavid
From: Josh Bendavid <joshbenda...@gmail.com> Add initial support for Archer C2600 to Makefiles and profiles. This is sufficient to build a working factory image. Sysupgrade image is not implemented yet. Currently wired network is working, but LED's/buttons/wireless are not. Updated to

[OpenWrt-Devel] [PATCH] [tools] firmware-utils: Add Archer C2600 support to tplink-safeloader

2015-12-04 Thread Josh Bendavid
From: Josh Bendavid <joshbenda...@gmail.com> Add support for Archer C2600 to tplink-safeloader by adding needed partition table, and vendor information plus support list strings. Additional string C2600 is enabled for the -B option. Signed-off-by: Josh Bendavid <joshbenda...@gmail.com&g

[OpenWrt-Devel] [PATCH] [ipq806x] Add initial support for TP-Link Archer C2600

2015-12-04 Thread Josh Bendavid
From: Josh Bendavid <joshbenda...@gmail.com> Add initial support for Archer C2600 to Makefiles and profiles. This is sufficient to build a working factory image. Sysupgrade image is not implemented yet. Currently wired network is working, but LED's/buttons/wireless are not. Sign