Re: [OpenWrt-Devel] [PATCH] uqmi: add timeout parameter

Hi Zefir, On 19.11.2019 11:34, Zefir Kurtisi wrote: [...] We don't know whether this is a device FW issue (we use the latest EM12GPAR01A15M4G) or whether the device enters some undocumented power-save mode after idling for some time. Could you share this firmware version, is that a generic

Re: [OpenWrt-Devel] [PATCH 0/2] introduce label_mac into hostname and SSID

Hi Adrian, On 17.11.2019 00:23, m...@adrianschmutzler.de wrote: Hi Piotr, Thank you for providing extensive feedback on this topic. -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Piotr Dymacz Sent: Samstag, 16. November 2019 16:32

Re: [OpenWrt-Devel] [PATCH 1/2] base-files: indicate initial setup by uci system config option

Hi Adrian, On 17.11.2019 00:36, m...@adrianschmutzler.de wrote: Hi Piotr, -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Piotr Dymacz Sent: Samstag, 16. November 2019 16:50 To: Adrian Schmutzler ; openwrt- de...@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH 1/2] base-files: indicate initial setup by uci system config option

Hi Adrian, On 08.11.2019 13:05, Adrian Schmutzler wrote: This provides a uci system config setting that will be set only during initial setup. This can be used by uci-defaults script to determine whether they are run during initial setup or after a sysupgrade. Since the setting is removed

Re: [OpenWrt-Devel] ath79: Force usb host mode for ar9331

Hi Micke, On 08.11.2019 13:30, Micke Prag wrote: Den 11/8/19 kl. 11:01 AM, skrev Piotr Dymacz: Hi Micke, On 08.11.2019 08:36, Micke Prag wrote: In commit 00ea16557d [1] the way usb is initiated was changed. Instead of initiate both ehci-platform and ci_hdrc the bootstrap status register

Re: [OpenWrt-Devel] [PATCH 0/2] introduce label_mac into hostname and SSID

Hi Adrian, On 08.11.2019 12:48, Adrian Schmutzler wrote: This patchset will introduce the label MAC address into the _default_ hostname and SSID of OpenWrt devices. Devices installed after these commits (or upgraded with sysupgrade -n) will have their hostname and SSID set to OpenWrt-ddeeff

Re: [OpenWrt-Devel] [PATCH] uqmi: add timeout parameter

Hi Zefir, On 07.11.2019 12:54, Zefir Kurtisi wrote: Working with Quectel EM12 LTE-module, we observe regular stalls of the QMI interface which cause a request issued by uqmi to hang forever. Most reproducibly this happens after the device has been power-cycled and left untouched for a while (~

Re: [OpenWrt-Devel] [PATCH v2] ath79: use gpio_hog instead of gpio-export

Hi Adrian, Sorry for a late reply. On 06.11.2019 16:47, Adrian Schmutzler wrote: Hi, Wouldn't it make more sense to spend time now on implementing future-proof solution and switch to it when it's ready? Obviously, yes. But for the meantime, I'd like to have a less-arbitrary status quo.

Re: [OpenWrt-Devel] [PATCH] ath79: enable all space on Netgear ar9344-based WNDR routers

Hi Michal, On 12.11.2019 14:02, Michal Cieslakiewicz wrote: Netgear WNDR routers (AR9344 models) like WNDR4300 have 128 MiB of flash memory but only first 32 MiB are used now - both by vendor's firmware and OpenWrt. This patch concatenates two regions of flash memory: ubi part of firmware

Re: [OpenWrt-Devel] wlan factory defaults

Hi Ivan, On 11.11.2019 20:33, Ivan Baktsheev wrote: Piotr, On 11 Nov 2019, at 21:35, Piotr Dymacz wrote: Hi Ivan, On 11.11.2019 19:09, Ivan Baktsheev wrote: Hi, I want to add new device, but as of now I can upload firmware wirelessly and then I need to connect using wired connection

Re: [OpenWrt-Devel] wlan factory defaults

Hi Ivan, On 11.11.2019 19:09, Ivan Baktsheev wrote: Hi, I want to add new device, but as of now I can upload firmware wirelessly and then I need to connect using wired connection, because in stock OpenWrt image wireless is disabled. For my router (and probably many others) default WiFi SSID

Re: [OpenWrt-Devel] ath79: Force usb host mode for ar9331

Hi Micke, On 08.11.2019 08:36, Micke Prag wrote: In commit 00ea16557d [1] the way usb is initiated was changed. Instead of initiate both ehci-platform and ci_hdrc the bootstrap status register is checked and used to determine which platform to initiate. There were other changes later, see for

Re: [OpenWrt-Devel] [PATCH v2] ath79: use gpio_hog instead of gpio-export

Hi Adrian, On 06.11.2019 00:14, m...@adrianschmutzler.de wrote: Hi, TL;DR: 1. We should find an agreement that can be used coherently at least for new device support submissions. I believe the major issue here is that there is no 'in place' replacement for 'gpio-export' (or I'm just not

Re: [OpenWrt-Devel] [PATCH v2] ath79: use gpio_hog instead of gpio-export

Hi Adrian, On 05.11.2019 22:19, m...@adrianschmutzler.de wrote: Hi, -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Adrian Schmutzler Sent: Dienstag, 5. November 2019 16:12 To: openwrt-devel@lists.openwrt.org Cc: Birger Koblitz

Re: [OpenWrt-Devel] v5.4 as next kernel

Hi Hauke, John, On 30.10.2019 16:54, Hauke Mehrtens wrote: On 10/29/19 6:37 AM, John Crispin wrote: Hi, should we use v5.4 as our next kernel ? John I also agree to have kernel 5.4 as the next kernel, it will be finally released in about 1 months and it is a long term kernel. If we are

Re: [OpenWrt-Devel] ath79/qca9533rev2: Help needed on missing GPIO on ath9k-phy0

Hi Adrian, On 30.10.2019 15:30, Adrian Schmutzler wrote: Hi, we are still working on broken WiFi on CPE210v2/v3 (ath79, QCA9533 rev. 2) and have found that on ath79 a GPIO is missing compared to ar71xx (where WIFI is working): It's not missing, it's there, just not controlled by the ath9k

Re: [OpenWrt-Devel] [PATCH 2/3] ipq40xx: mtd m25p80: fix hang on device shutdown

Hi Daniel, On 30.10.2019 12:27, Daniel Danzberger wrote: Signed-off-by: Daniel Danzberger --- .../401-mtd-m25p80-fix-shutdown-hang.patch| 21 +++ 1 file changed, 21 insertions(+) create mode 100644

Re: [OpenWrt-Devel] [PATCH] ramips: use gpio_hog instead of gpio-export

Hi Mathias, Birger, On 11.08.2019 11:36, Mathias Kresin wrote: 02/08/2019 11:58, Birger Koblitz: ramips: use gpio_hog instead of gpio-export The `gpio-export` functionality is a hack for missing kernel functionality, which was rejected in upstream kernel long time ago, for details see this

Re: [OpenWrt-Devel] [PATCH] phytool: add phytool utility

Hi Christian, On 16.06.2019 20:50, Christian Lamparter wrote: Hello Piotr, On Sun, Jun 16, 2019 at 7:08 PM Piotr Dymacz wrote: Hi Christian, On 16.06.2019 13:56, Christian Lamparter wrote: > From the README.md: > > phytool is a Linux MDIO register access utility. Is there a

Re: [OpenWrt-Devel] [PATCH] phytool: add phytool utility

Hi Christian, On 16.06.2019 13:56, Christian Lamparter wrote: From the README.md: phytool is a Linux MDIO register access utility. Is there any reason to keep it inside the main code base rather than in packages feed? -- Cheers, Piotr Usage: phytool read IFACE/ADDR/REG phytool write

Re: [OpenWrt-Devel] QCA953x usb mode / chipidea

about that. I'm not sure about default (internal) values. Maybe keeping that I/O floating is the reason. -- Cheers, Piotr On Thu, Mar 14, 2019 at 7:51 PM Piotr Dymacz <mailto:pep...@gmail.com>> wrote: Hi Arvid, On 14.03.2019 19:38, Arvid Picciani wrote:

Re: [OpenWrt-Devel] QCA953x usb mode / chipidea

Hi Arvid, On 14.03.2019 19:38, Arvid Picciani wrote: Hi, i'm trying to bring up the ZBT WE826-Q,  but usb wont come up. After much digging, deleting patches-4.14/920-usb-chipidea-AR933x-platform-support.patch solves the issue. How is this supposed to work with other boards? You should

Re: [OpenWrt-Devel] ipq40xx: backport I2C QUP changes from 4.17

Hi Christian, On 04.03.2019 13:16, Christian Lamparter wrote: Hello, On Sunday, March 3, 2019 8:57:03 PM CET Piotr Dymacz wrote: I'm observing various I2C related issues on ALFA Network AP120C-AC board with AT97SC3205T TPM module. As there was a major update of the I2C QUP driver in 4.17, I

[OpenWrt-Devel] ipq40xx: backport I2C QUP changes from 4.17

Hi, I'm observing various I2C related issues on ALFA Network AP120C-AC board with AT97SC3205T TPM module. As there was a major update of the I2C QUP driver in 4.17, I decided to backport whole series [1]. I have patch ready in my staging tree [2] and would like to get feedback from others,

Re: [OpenWrt-Devel] [PATCH] ath79: Add GL.iNet GL-AR300M Family to /etc/board.d/01_leds

Hi Jeff, On 02.03.2019 18:01, Jeff Kletsky wrote: From: Jeff Kletsky Previously missing, add the three variants; -nand, -nor, -lite to the definitions in 01_leds -Lite variant uses language-independent Ethernet as its single port may be configured as WAN or LAN, depending use case. This

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

Hello Zefir, On 25.02.2019 16:06, Zefir Kurtisi wrote: [snip] Hm, I gave an example in the commit message and if it helps, I can post the related log-output to prove my claim. But you might mean something else? But the 'qcawifi' is not part of the kernel and OpenWrt project. The QSDK [1]

Re: [OpenWrt-Devel] [PATCH] base-files: move kmodloader below uci_apply_defaults

Hello Zefir, On 25.02.2019 15:08, Zefir Kurtisi wrote: re-post, missed CC On 2/25/19 2:52 PM, Bjørn Mork wrote: Zefir Kurtisi writes: Some kernel modules have colliding symbol naming This is not true. Bjørn Hm, I gave an example in the commit message and if it helps, I can post the

[OpenWrt-Devel] [PATCH] build: add helpers for generating QSDK sysupgrade compatible images

pq-factory-nand Build/qsdk-ipq-factory-nor Example usage for board with UBI in NAND: IMAGE/nand-factory.bin := append-ubi | qsdk-ipq-factory-nand Signed-off-by: Piotr Dymacz --- include/image-commands.mk | 14 scripts/mkits-qsdk-ipq-image.sh | 59 +++

Re: [OpenWrt-Devel] [PATCH] ath79: align GL-AR750S boardname to other GL.iNet devices

Hi Christian, On 01.01.2019 18:23, Christian Lamparter wrote: On Tuesday, January 1, 2019 1:03:22 PM CET Christoph Krapp via openwrt-devel wrote: The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate

Re: [OpenWrt-Devel] [PATCH] ath79: add support for GL.iNet GL-AR750S

Hi Tom, On 30.12.2018 15:15, Tom Psyborg wrote: On 30/12/2018, Piotr Dymacz wrote: Hi Tom, On 30.12.2018 15:03, Tom Psyborg wrote: [...] If it's possible to update from the stock firmware via a webinterface, it's fine. If not, the way via u-boot works as well. Mathias Aren't you

Re: [OpenWrt-Devel] [PATCH] ath79: add support for GL.iNet GL-AR750S

Hi Tom, On 30.12.2018 15:03, Tom Psyborg wrote: [...] If it's possible to update from the stock firmware via a webinterface, it's fine. If not, the way via u-boot works as well. Mathias Aren't you embarrassed being such a hypocrite liar? Prove your point or troll somewhere else.

Re: [OpenWrt-Devel] [PATCH 1/8] kernel: add DT binding support to the fit parser

Hi Christian, On 11.12.2018 02:10, Christian Lamparter wrote: On Monday, December 10, 2018 10:28:22 PM CET John Crispin wrote: On 10/12/2018 16:47, Piotr Dymacz wrote: > Hi Christian, > > On 09.12.2018 16:34, Christian Lamparter wrote: >> It allows specifying default and

Re: [OpenWrt-Devel] [PATCH] ath79: add support for GL.iNet GL-AR750S

Hi Christoph, On 30.12.2018 10:54, Christoph Krapp via openwrt-devel wrote: This patch adds supports for GL-AR750S. Specification: - SOC: QCA9563 (775MHz) - Flash: 16 MiB (W25Q128FVSG) This device comes with SPI NOR + NAND combination. You should at least mention that in your patch and let

Re: [OpenWrt-Devel] [PATCH 1/8] kernel: add DT binding support to the fit parser

Hi Christian, On 09.12.2018 16:34, Christian Lamparter wrote: It allows specifying default and Netgear parsers directly in the DT. Signed-off-by: Christian Lamparter --- .../linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_fit.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [OpenWrt-Devel] [RFC] stop accepting 4/32M board patches

Hi Mathias, On 05.12.2018 09:56, Mathias Kresin wrote: Hey all, I would like to start to reject patches for adding boards with only 32 MByte of RAM and 4 MByte of flash [0]. These boards barely work with todays OpenWrt default builds and require quite some modifications to be useful at all

Re: [OpenWrt-Devel] ar71xx Vs ath79 -- sysupgrade

Hi Henrique, On 04.12.2018 17:08, Henrique de Moraes Holschuh wrote: Another aspect was the LED configuration, as LED naming is very inconsistent and often differs from ar71xx. Some LEDs are now not included in UCI configuration. > So you either need to delete (and recreate) them ore just dump

Re: [OpenWrt-Devel] [PATCH v3] uqmi: allow matching IMSI for qmi networks

Hi Daniel, On 05.11.2018 00:46, Daniel Golle wrote: Introduce 'imsi' configuration option for proto 'qmi' network interfaces. Setting it makes sure the configuration only gets used on the intended SIM card. In this way, one can have many configurations for different SIM cards selected

Re: [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

Hi Etienne, On 19.01.2018 13:09, Etienne Champetier wrote: Hi Piotr, 2018-01-19 9:54 GMT+01:00 Piotr Dymacz <pep...@gmail.com>: Hi Etienne, On 18.01.2018 22:59, Etienne Champetier wrote: Hi All, Could someone enable this https://github.com/integration/dco on the whole OpenWrt gith

Re: [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

Hi Etienne, On 18.01.2018 22:59, Etienne Champetier wrote: Hi All, Could someone enable this https://github.com/integration/dco on the whole OpenWrt github org? (or at least on the packages repo) I think that packages repository already uses Travis CI which checks for such thing like a

Re: [OpenWrt-Devel] patchwork

Hi, On 18.01.2018 09:44, Jo-Philipp Wich wrote: Hi John, Alex, I have no problem with closing / autorejecting open tickets in patchwork as long as they somehow remain available for future reference. ACK. Would it be possible to send the author short message why the patch was auto

Re: [OpenWrt-Devel] merge: add OpenWrt branding

Hello Zoltan, Hauke, Just one, small comment, inline below. On 24.10.2017 13:46, Zoltan HERPAI wrote: [...] diff --git a/include/image-commands.mk b/include/image-commands.mk index aaece70..3507578 100644 --- a/include/image-commands.mk +++ b/include/image-commands.mk @@ -7,7 +7,7 @@ define

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH 9/9] ar71xx: add support for Comfast E214N V2 Outdoor CPE

Hello Zoltan, On 22.10.2017 22:21, Zoltan HERPAI wrote: Based on Robert Budde's patch, with additional reworks. https://github.com/openwrt/openwrt/pull/390 Signed-off-by: Zoltan HERPAI --- target/linux/ar71xx/base-files/etc/board.d/01_leds | 10 ++

Re: [OpenWrt-Devel] openwrt and lede - remerge proposal V3

On 29.05.2017 09:03, John Crispin wrote: (resend, this time as plain text) Hi, here is a V3 of the remerge proposal, I tried to fold all the comments people made into it, if anything is missing let me know. Please remeber that post remerge anything can be voted on, so cluttering the proposal

Re: [OpenWrt-Devel] Introducing the LEDE project

Hello, 2016-05-03 22:19 GMT+02:00 Bruno Randolf : > On 03/05/16 18:59, Jo-Philipp Wich wrote: >> we'd like to introduce LEDE, a reboot of the OpenWrt community >> ... >> Jo-Philipp Wich, >> John Crispin, >> Daniel Golle, >> Felix Fietkau, >> Hauke Mehrtens >> John Crispin >>

Re: [OpenWrt-Devel] [PATCHv10] ramips: Add support for SamKnows Whitebox 8

Hello Andrew, Just two comments. Your patch changelog should go below "---" after the Signed-off-by line, so that it won't get included in commit message. It's common to include just a small description about the hardware the patch adds support for, examples: [1], [2], [3]. Cheers, Piotr [1]

Re: [OpenWrt-Devel] [PATCH] ramips: add support for Planex MZK-EX750NP.

here is access in the UART. >> Looking for a good way. I'm thinking. >> >> >> On 2016/04/28 19:24, Piotr Dymacz wrote: >>> >>> Hello YuheiOKAWA, >>> >>> Just small question. >>> How the user can access the device if it doesn't have

Re: [OpenWrt-Devel] [PATCH] ramips: add support for Planex MZK-EX750NP.

Hello YuheiOKAWA, Just small question. How the user can access the device if it doesn't have Ethernet and the WiFi is disabled by default in OpenWrt? Cheers, Piotr 2016-04-28 11:49 GMT+02:00 YuheiOKAWA : > add support for Planex MZK-EX750NP. > MZK-EX750NP is MT7620A

Re: [OpenWrt-Devel] [PATCH 4/4] ramips: HLK-RM04 - Enable GPIO14 for WPS button

Hello John, 2016-01-22 21:56 GMT+01:00 John Clark : >>>Also note that target/linux/ramips/dts/WT1520.dtsi is for the "Nexx >>> WT1520" and should be named "WT1520.dts" instead. I will send that change >>> through as a different patch. The dtsi file contains common definitions

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R add led support for wrtnode platform

Hello, Small comment inline, below. Plus: 1. This patch is not for trunk, so you should add "CC" prefix in the subject. 2. Both models are very similar, my suggestion is to use common dtsi (ex. Lenovo Y1). Cheers, Piotr 2015-12-24 9:56 GMT+01:00 xzmu : > Signed-off-by: xzmu

Re: [OpenWrt-Devel] [PATCH v2] ramips:Fix support for PBR-M1 board

Hello, See inline, below. Cheers, Piotr 2015-12-04 14:50 GMT+01:00 GuoGuo : > The PBR-M1 support in current OpenWrt is for the early demo board and it > doesn't work on the final board.This patch fixes the support for it. > The LED called pbr-m1:buzzer is a beeper

Re: [OpenWrt-Devel] [PATCH v3] Add support for Ubuquiti EdgeRouter X (UBNT-ERX)

Hello, Small comments from me below. Cheers, Piotr 2015-12-03 0:46 GMT+01:00 Nikolay Martynov : [snip] > diff --git a/target/linux/ramips/mt7621/profiles/ubnt-erx.mk > b/target/linux/ramips/mt7621/profiles/ubnt-erx.mk Please, follow general convention and keep all board

Re: [OpenWrt-Devel] [PATCH] ramips:Fix support for PBR-M1 board

Hello, See my comments inline, below. Cheers, Piotr 2015-11-29 3:52 GMT+01:00 GuoGuo : > The PBR-M1 support in current OpenWrt is for the early demo board and it > doesn't work on the final board.This patch fixes the support for it. What with users with "early demo

Re: [OpenWrt-Devel] [PATCH] ramips: Add initial support for WiTi Board

Hello, some small comments from me, inline below. Cheers, Piotr 2015-11-19 13:10 GMT+01:00 Srdjan Rosic : > From: Sebastian Careba > > WITI.dts is based on PBR-M1.DTS > > Signed-off-by: Sebastian Careba > --- >

Re: [OpenWrt-Devel] [PATCH] x86: add a subtarget for PCEngines APU

2015-11-08 13:07 GMT+01:00 Russell Senior : >> "Felix" == Felix Fietkau writes: > > Felix> On 2015-11-08 07:24, Russell Senior wrote: >>> >>> Reworked from patch by Ben Pfountz Builds and >>> boots. >>> >>> Signed-off-by: Russell

Re: [OpenWrt-Devel] [PATCH] ramips: add support for ZBT WG2626

Hello Daniel, I have this device on my desk (-4G version, with dedicated SIM slot and place for additional 2 antennas for modem, in enclosure). I'm looking for some description of pin headers available on the PCB (I have already asked manufacturer, but I got only "PIN number J1, J9, J10, J11 are

Re: [OpenWrt-Devel] [PATCH] ramips: add support for the Asus RP-N53 in the "02_network" boot script

Hello Alberto, Two comments: 1. Your patch breaks alphabetical order. 2. If you look more deeply into the file, you will easily find there other boards with exactly the same configuration: asl26555 and re6500. Please, don't add unnecessary code and use what's already there. Cheers, Piotr

Re: [OpenWrt-Devel] [PATCH] ramips: add support for the Asus RP-N53 in the "02_network" boot script

data mer 28 ottobre 2015 19:46:50, Piotr Dymacz ha scritto: >> Hello Alberto, >> >> Two comments: >> 1. Your patch breaks alphabetical order. >> 2. If you look more deeply into the file, you will easily find there >> other boards with exactly the same configuratio

[OpenWrt-Devel] [PATCH 1/2] ramips: rt305x: update kernel config symbols

Signed-off-by: Piotr Dymacz <pep...@gmail.com> --- target/linux/ramips/rt305x/config-3.18 | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/linux/ramips/rt305x/config-3.18 b/target/linux/ramips/rt305x/config-3.18 index 9c03767..c7ad9d1 100644 --- a/target

[OpenWrt-Devel] Weird problem with WLAN on RT3662F+RT5392L and iwinfo crash

Hello, I'm working on support for for Jensen AL3000DG v2 device (ramips target, currently build on r47048). The device is similar (but not exactly the same) to Edimax R-6475ND and Asus RT-N56U. Short specification: - RT3662F (for 5 GHz radio) - RT5392L (for 2,4 GHz radio) - RTL8367R Gbps switch

Re: [OpenWrt-Devel] openwrt-devel Digest, Vol 118, Issue 11

Hello hackru, 2015-10-03 13:03 GMT+02:00 hackru : > > On 03 Oct 2015, at 03:00, openwrt-devel-requ...@lists.openwrt.org wrote: > > > For #2, I can write the wiki page, though it is would be complicated. > HiWiFi provides an "official" way to unlock the U-Boot now, at the cost

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

Hello, 2015-10-02 15:53 GMT+02:00 康 : > > Hi, Merging 3 dts into one dtsi has been done in patch V3 , Sorry, I missed that. > Sorry I don't quite understand your question , do you mean how to flash on > those devices? Yes and I got the answer from your mail to Yousong: > For

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

gt; > On Tue, Sep 29, 2015 at 4:31 AM, Piotr Dymacz <pep...@gmail.com> wrote: >> >> Hello, >> >> Just some small, cosmetic things... see inline, below. >> >> BTW. >> I see that these models are very similar (most of the dts files are >> just

Re: [OpenWrt-Devel] [PATCH 2/3] ramips: Add base-files for HiWiFi HC5x61 models

ng helper functions "find_mtd_index" and "mtd_get_mac_ascii"? > V2 is uploaded, please take a look. Thanks again~ Thanks for all fixes! I will take a look at v2 and send my comments, if any, soon. Cheers, Piotr > > 在 15/9/28 下午7:48，“Piotr Dymacz”<pep...@gma

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

Hello, Just some small, cosmetic things... see inline, below. BTW. I see that these models are very similar (most of the dts files are just copy). Maybe it would be better to make for them one, common dtsi file and separated dts files per model (take Lenovo Y1/Y1S as example). Cheers, Piotr

Re: [OpenWrt-Devel] [PATCH V2 3/3] ramips: Add build files for HiWiFi HC5x61 models

Hello, Just three comments: 1. Please, use tabs as in all other profile files (I didn't spot that before, sorry). 2. Keep two empty lines between different boards profiles definitions, take target/linux/ramips/rt305x/profiles/d-link.mk as example. 3. You have selected a lot of external packages.

Re: [OpenWrt-Devel] [PATCH 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

Hello, Please, take a look at other dts files in ramips target and follow the general convention, like: - use only model name for dts filename - keep empty lines between nodes and between nodes and properties (ex. [1]) [1]

Re: [OpenWrt-Devel] [PATCH 2/3] ramips: Add base-files for HiWiFi HC5x61 models

Hello, Please, see my comments inline, below. PS. Sorry for being so pedantic :) Cheers, Piotr 2015-09-28 12:46 GMT+02:00 Comman Kang : > HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com. > These models have similar hardware specs(MT7620A + 128M DDR2 +

Re: [OpenWrt-Devel] [PATCH 3/3] ramips: Add build files for HiWiFi HC5x61 models

Hello, Please, follow the general convention and keep profiles for different boards from same manufacturer in one file named "manufacturer.mk". Cheers, Piotr 2015-09-28 12:46 GMT+02:00 Comman Kang : > HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com >

Re: [OpenWrt-Devel] [PATCH] ramips: Added WIZnet WizFi630A Platform based on Ralink RT5350

Hello Tobias, Thanks for all fixes, but I'm afraid that there are still some problems with new version of your patch (only cosmetic). Please, see my (this time just a few) comments inline, below. Cheers, Piotr 2015-08-27 19:39 GMT+02:00 Tobias Welz t...@wiznet.eu: This patch is to add the

Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

+08:00 Piotr Dymacz pep...@gmail.com: 2015-08-17 8:28 GMT+02:00 John Crispin blo...@openwrt.org: Hi, just merged the whole lot. thanks a lot. what do you want to do next lantiq or ar71xx ? :) personally i would prefer ar71xx ;) [...] Hello John, It seems that there are some people who don't

Re: [OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

), but they don't have enough courage to use their real name and post their comments on the list. I will back with answers for your and Michael Heimpold (I'm sorry, I didn't spot your e-mail before!) questions in few days. Now I'm really busy with other things. Cheers, Piotr Dymacz --- 2015-08-17 13:05

Re: [OpenWrt-Devel] [PATCH v2] ramips: add support for Planex DB-WRT01

Hello, Please, see my comments inline. 2015-08-17 19:20 GMT+02:00 YuheiOKAWA tochiro.srch...@gmail.com: This patch add support for Planex DB-WRT01. DANBOARD route on the MT7620A SoC with two Ethernet port and a 802.11n 2.4 GHz radio. DANBOARD is Cartoon character. Signed-off-by:

[OpenWrt-Devel] [PATCH v2 00/25] ramips: massive code cleanups

convention for LED naming * more fixes in dts{,i} files * patches are now ordered more logically * patches are now better described * additional fixes related with devices names * big patches related with particular devices are not combined together, for easy review Piotr Dymacz (25

[OpenWrt-Devel] [PATCH v2 02/25] ramips: fix Zbtlink ZBT-WR8305RT board name

There is another Zbtlink board (ZBT-WA05) supported in ramips target, so use the same naming scheme for ZBT-WR8305RT board and its dts file. Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/etc/board.d/01_leds | 8 +- .../linux/ramips/base-files/etc/board.d

[OpenWrt-Devel] [PATCH v2 03/25] ramips: fix Asus WL-330N{, 3G} boards names

There are other Asus boards supported in ramips target, so use the same naming scheme for WL-330N{,3G} boards and their dts files. Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/dts/WL-330N.dts | 100 +++ target/linux/ramips/dts/WL-330N3G.dts

[OpenWrt-Devel] [PATCH v2 04/25] ramips: fix Asus RP-N53 and Lenovo Y1{, S} image names

This patch: * fixes typo (rp_n53 - rp-n53) in Asus RP-N53 image name * removes manufacturer from image names for Lenovo Y1{,S} devices Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/image/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[OpenWrt-Devel] [PATCH v2 07/25] ramips: fix Asus RT-N56U dts filename

Other Asus RT-N dts files are named RT-N... (not RTN...), so use the same for RT-N56U. Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/dts/RT-N56U.dts | 151 target/linux/ramips/dts/RTN56U.dts | 151

[OpenWrt-Devel] [PATCH v2 06/25] ramips: fix UPVEL model names

Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/lib/ramips.sh | 4 ++-- target/linux/ramips/dts/UR-326N4G.dts| 2 +- target/linux/ramips/dts/UR-336UN.dts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/linux/ramips/base

[OpenWrt-Devel] [PATCH v2 05/25] ramips: fix Xiaomi MiWiFi Mini board, image and profile names

The following patch: * changes board name from xiaomi-miwifi-mini to miwifi-mini * changes filenames of dts and profile * fixes LED names in dts file and base-files scripts * removes manufacturer name from image filename for Xiaomi MiWiFi Mini device. Signed-off-by: Piotr Dymacz pep

[OpenWrt-Devel] [PATCH v2 08/25] ramips: fix Belkin F7C027 image name

This patch removes manufacturer from Belkin F7C027 image name (belkinf7c027 - f7c027). Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/image/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/ramips/image/Makefile b/target/linux

[OpenWrt-Devel] [PATCH v2 09/25] ramips: fix Argus ATP-52B board and image names

The following patch: * changes board name from argus-atp52b to atp-52b * changes dts filename * fixes LED names in dts file and base-files scripts * removes manufacturer name from image filename for Argus ATP-52B device. Signed-off-by: Piotr Dymacz pep...@gmail.com --- .../linux/ramips/base

[OpenWrt-Devel] [PATCH v2 13/25] ramips: fix Tenda W150M model name

Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/dts/W150M.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ramips/dts/W150M.dts b/target/linux/ramips/dts/W150M.dts index 5f4d0e3..2309df6 100644 --- a/target/linux/ramips/dts/W150M.dts

[OpenWrt-Devel] [PATCH v2 12/25] ramips: fix Aigale Ai-BR100 dts and profile names

The following patch changes dts filename and profile name for Aigale Ai-BR100 (for consistency). Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/dts/AI-BR100.dts | 109 ++ target/linux/ramips/dts/AIBR100.dts | 109

[OpenWrt-Devel] [PATCH v2 10/25] ramips: fix Sitecom WL-341v3 board and image names

The following patch changes: * board name from wl341v3 to wl-341v3 * dts filename * LED names in dts file for Sitecom WL-341v3 device. Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/lib/ramips.sh | 2 +- .../ramips/base-files/lib/upgrade/platform.sh

[OpenWrt-Devel] [PATCH v2 14/25] ramips: fix Edimax BR-6425 board name

Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/etc/board.d/01_leds | 2 +- target/linux/ramips/base-files/etc/diag.sh | 2 +- target/linux/ramips/base-files/lib/ramips.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target

[OpenWrt-Devel] [PATCH v2 11/25] ramips: fix Olimex models, images and profiles names

for Olimex RT5350F-OLinuXino{,-EVB} devices. Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/lib/ramips.sh | 8 +- .../ramips/base-files/lib/upgrade/platform.sh | 4 +- target/linux/ramips/dts/OLINUXINO-RT5350F-EVB.dts | 102

[OpenWrt-Devel] [PATCH v2 15/25] ramips: fix Omnima models, images and profiles names

Official names for supported Omnima products are (as on website): * Omnima HPM * Omnima MiniEMBWiFi * Omnima MiniEMBPlug This patch changes: * board names * dts filenames * profile names * image filenames * LED names for Omnima devices, for consistency. Signed-off-by: Piotr Dymacz pep

[OpenWrt-Devel] [PATCH v2 17/25] ramips: fix 7Links PX-4885 dts{, i}, board, image and profile names

The following patch changes 7Links PX-4885 dts{,i} filenames, board, image and profile names from PX4885 to PX-4885 (for consistency). Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/etc/board.d/01_leds | 6 +-- target/linux/ramips/base-files/etc/diag.sh

[OpenWrt-Devel] [PATCH v2 18/25] ramips: remove old code for Edimax BR-6524N

It seems that support for Edimax BR-6524N was dropped long time ago (dts file for this device is missing). This patch removes remaining code. Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/etc/board.d/01_leds| 3 --- target/linux/ramips/base-files/etc

[OpenWrt-Devel] [PATCH v2 16/25] ramips: fix Buffalo WMR-300 dts, board, image and profile names

The following patch changes Buffalo WMR-300 dts filename, board, image and profile names from WMR300 to WMR-300 (for consistency). Signed-off-by: Piotr Dymacz pep...@gmail.com --- .../linux/ramips/base-files/etc/board.d/02_network | 2 +- target/linux/ramips/base-files/etc/diag.sh

[OpenWrt-Devel] [PATCH v2 20/25] ramips: remove leading spaces, sort boards and optimize base-files/lib/ramips.sh

was tested after above changes with simple script, which: * takes model string from dts{,i} file (model = ...) * provides this value as case input ($machine) * returns output ($name) Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/lib/ramips.sh | 434

[OpenWrt-Devel] [PATCH v2 24/25] ramips: use consistent naming scheme for LEDs

in 01_leds) Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/etc/board.d/01_leds | 520 +++-- target/linux/ramips/base-files/etc/diag.sh | 252 ++ target/linux/ramips/dts/3G-6200N.dts | 6 +- target/linux/ramips/dts/3G

[OpenWrt-Devel] [PATCH v2 23/25] ramips: remove unnecessary LED declaration for WT1520 in diag.sh

This device doesn't have defined LEDs in its dts file. Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/base-files/etc/diag.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/linux/ramips/base-files/etc/diag.sh b/target/linux/ramips/base-files/etc/diag.sh index

[OpenWrt-Devel] [PATCH v2 22/25] ramips: fix indentation, case statements structure and optimize base-files/etc/board.d/02_network

untouched: freestation5 board is listed twice in case statement, in ramips_setup_macs(). Signed-off-by: Piotr Dymacz pep...@gmail.com --- .../linux/ramips/base-files/etc/board.d/02_network | 390 + 1 file changed, 170 insertions(+), 220 deletions(-) diff --git a/target/linux

[OpenWrt-Devel] [PATCH v2 21/25] ramips: be consistent with case statement in base-files/lib/upgrade/platform.sh

Always use |\ (without spaces) and keep boards in alphabetical order. Signed-off-by: Piotr Dymacz pep...@gmail.com --- .../ramips/base-files/lib/upgrade/platform.sh | 234 ++--- 1 file changed, 117 insertions(+), 117 deletions(-) diff --git a/target/linux/ramips/base-files

[OpenWrt-Devel] [PATCH v2 25/25] ramips: base-files: optimize etc/diag.sh and etc/board.d/01_leds scripts

[...] The above approach allows to shrink size of code in base-files/etc/board.d/01_leds and base-files/etc/diag.sh scripts dramatically. One thing to keep in mind here is that we assume to use proper and consistent LED naming scheme (device:color:led-name). Signed-off-by: Piotr Dymacz pep

[OpenWrt-Devel] [PATCH v2 19/25] ramips: fix various mistakes in subtargets *.mk profiles

profile files structure (keep the same convention as in other targets, ex. ar71xx) in various .mk profiles, in ramips target. Signed-off-by: Piotr Dymacz pep...@gmail.com --- target/linux/ramips/mt7620/profiles/mediatek.mk| 2 +- target/linux/ramips/mt7620/profiles/microduino.mk | 16

Re: [OpenWrt-Devel] [PATCH 00/13] ramips: massive code cleanups

2015-07-30 14:24 GMT+02:00 John Crispin blo...@openwrt.org: [...] big diff stat. i like it. can you do the same for lantiq ? :) Maybe... and ar71xx too? ;) i will stop merging new board to ramips target untilt his series is in the tree to save you having to rebase too often. OK. when can

Re: [OpenWrt-Devel] [PATCH 04/13] ramips: sort boards alphabetically and optimize base-files/etc/{diag.sh, board.d/*} scripts

2015-07-27 11:37 GMT+02:00 Michael Bastian mbast...@netcologne.de: diff --git a/target/linux/ramips/base-files/etc/board.d/02_network b/target/linux/ramips/base-files/etc/board.d/02_network index 334e889..a781f46 100755 [...] + re6500) + ucidef_set_interface_lan eth0.1 + ucidef_add_switch

Re: [OpenWrt-Devel] [PATCH 05/13] ramips: use consistent naming scheme for LEDs, for various manufacturers

2015-07-26 23:59 GMT+02:00 Jonas Gorski j...@openwrt.org: On Sun, Jul 26, 2015 at 9:34 PM, Piotr Dymacz pep...@gmail.com wrote: 2015-07-26 21:16 GMT+02:00 Imre Kaloz ka...@openwrt.org: On Sun, 26 Jul 2015 18:24:30 +0200, Piotr Dymacz pep...@gmail.com wrote: For some boards in ramips

<    1   2   3   >