Re: [OpenWrt-Devel] [PATCH] Ar7 prevent clock init race

2010-05-09 Thread Florian Fainelli
Le dimanche 9 mai 2010 05:21:46, Michael Evans a écrit : > Florian, I'm very much not a fan of the Makefile level solution you've > used. > > Is that behavior required to work regardless of multi-threading > linkers/make processes? I can see situations where it could work for > some builders all

Re: [OpenWrt-Devel] [PATCH] Ar7 prevent clock init race

2010-05-08 Thread Michael Evans
Florian, I'm very much not a fan of the Makefile level solution you've used. Is that behavior required to work regardless of multi-threading linkers/make processes? I can see situations where it could work for some builders all the time, some builders none of the time, and some builders intermitt

Re: [OpenWrt-Devel] [PATCH] Ar7 prevent clock init race

2010-05-08 Thread Florian Fainelli
Hi Michael, Le samedi 8 mai 2010 02:08:56, Michael J. Evans a écrit : > Change ar7_init_clocks to a core level function, removing a race condition. > > Both ar7_init_clocks and ar7_register_devices were using arch_initcall. > However ar7_register_devices depended on values changed by ar7_init_clo

[OpenWrt-Devel] [PATCH] Ar7 prevent clock init race

2010-05-07 Thread Michael J. Evans
Change ar7_init_clocks to a core level function, removing a race condition. Both ar7_init_clocks and ar7_register_devices were using arch_initcall. However ar7_register_devices depended on values changed by ar7_init_clocks. Also add a printk so that the resulting effect is obvious. Signed-off-by