Re: [OpenWrt-Devel] [PATCH] Hotplug automount fixes/enhancements

2010-02-01 Thread Stefan Monnier
> To be honest I'm not sure how useful the unmount in hotplug really is > anyway...usually if it's called it mean the device has already been > removed, I think. But if you don't unmount, then you're left with some "zombie" mount, which still refers to the device name and can lead to problems (min

Re: [OpenWrt-Devel] [PATCH] Hotplug automount fixes/enhancements

2010-01-30 Thread Daniel Dickinson
On Sat, 2010-01-30 at 12:47 +0100, edgar.sol...@web.de wrote: > (stability) > Quite a chunk of code. Did you write it from scratch? Yes > How thoroughly is this tested by now? Well I've tested a number of scenarios / code paths, but there is probably something I've missed. > Does this work with

Re: [OpenWrt-Devel] [PATCH] Hotplug automount fixes/enhancements

2010-01-30 Thread edgar . soldin
(stability) Quite a chunk of code. Did you write it from scratch? How thoroughly is this tested by now? Does this work with kernel 2.4? Lot's of users are stuck to these kernels. (packaging) I don't mean to be picky, but wouldn't it make sense to keep code that depends on specific package with tha

Re: [OpenWrt-Devel] [PATCH] Hotplug automount fixes/enhancements

2010-01-29 Thread Marc Abrams
hehe... good job. marc. On Fri, Jan 29, 2010 at 5:13 PM, Daniel Dickinson wrote: > The attached patch replaces the current /etc/hotplug.d/block/10-mount > and adds a shared shell script 'library' that, with this patch, is used > by hotplug automount and fstab, and will be used by the rootfs on

[OpenWrt-Devel] [PATCH] Hotplug automount fixes/enhancements

2010-01-29 Thread Daniel Dickinson
The attached patch replaces the current /etc/hotplug.d/block/10-mount and adds a shared shell script 'library' that, with this patch, is used by hotplug automount and fstab, and will be used by the rootfs on external storage package that I am working on as well. You can turn automount completely o