Hi,
I have updated the patch as Philip and Jo-Philipp suggested.
Signed-off-by: Tathagata Das
---
diff -Naur a/scripts/download.pl b/scripts/download.pl
--- a/scripts/download.pl 2012-04-05 18:59:13.0 +0530
+++ b/scripts/download.pl 2012-04-06 11:27:12.0 +0530
@@ -9
On 4/4/12 12:47 PM, Jo-Philipp Wich wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Hi Philipp,
>
> in principle I aggree but I've seen Perl distributions without
> Digest::MD5 available by default, so shelling out to call "md5sum"
> sounds ok to me.
>
> ~ Jow
Your call. I'm just t
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Philipp,
in principle I aggree but I've seen Perl distributions without
Digest::MD5 available by default, so shelling out to call "md5sum"
sounds ok to me.
~ Jow
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi, you can optimize out the temporary dl file.
> diff -Naur a/scripts/download.pl b/scripts/download.pl
> --- a/scripts/download.pl 2012-04-04 13:19:27.0 +0530
> +++ b/scripts/download.pl 2012-04-04 13:20:34.0 +0530
> @@ -9,6
More comments...
On 4/4/12 3:37 AM, Tathagata Das wrote:
> Hi,
> I have updated the patch as Philip and Jo-Philipp suggested.
>
> Thanks Philip and Jo-Philipp for your feedback.
>
> Signed-off-by: Tathagata Das
>
> ---
>
> diff -Naur a/scripts/download.pl b/scripts/download.pl
> --- a/scrip
Hi,
I have updated the patch as Philip and Jo-Philipp suggested.
Thanks Philip and Jo-Philipp for your feedback.
Signed-off-by: Tathagata Das
---
diff -Naur a/scripts/download.pl b/scripts/download.pl
--- a/scripts/download.pl 2012-04-04 13:19:27.0 +0530
+++ b/scripts/download.p
Inline...
On 4/2/12 6:06 AM, Tathagata Das wrote:
> Hi,
> I have modified the patch as John suggested. This patch will only copy a
> single file from local repository. If more than one instance of the same file
> exists in the subfolders then it will throw an error. I have used latest
> trunk
While the existing perl code isn't the best either, yours is extremely
inefficient, you should rework it using native functions.
> + system("find $cache -follow -name $filename 2>/dev/null 1>>
> temp.dls");
perldoc -f open
> + my $lines = `cat temp.dls | wc -l`;
perldoc -
Hi,
I have modified the patch as John suggested. This patch will only copy a
single file from local repository. If more than one instance of the same file
exists in the subfolders then it will throw an error. I have used latest trunk
(revision 31050) to test this patch.
Thanks John for your fe