Re: [OpenWrt-Devel] [PATCH] ar71xx: check for stuck DMA on AR724x & fix sirq storm after recovery

2016-01-13 Thread Felix Fietkau
Hi Conn, On 2016-01-10 05:20, Conn O'Griofa wrote: > Hi Felix, > > It appears that my hunch was correct, and both are necessary. The > following patch works 100% fine; when the dma stuck condition occurs, > recovery now completes without any link adjust or any other output > from the kernel log*.

Re: [OpenWrt-Devel] [PATCH] ar71xx: check for stuck DMA on AR724x & fix sirq storm after recovery

2016-01-09 Thread Conn O'Griofa
Hi Felix, On 08/01/16 23:34, Conn O'Griofa wrote: I tried replacing netif_start_queue(dev) with ag71xx_hw_start(ag) in ag71xx_hw_enable. With this change, when the DMA stuck issue occurs, there's no longer any tx timeouts logged, but the interface stops responding. Perhaps it's also necessary

Re: [OpenWrt-Devel] [PATCH] ar71xx: check for stuck DMA on AR724x & fix sirq storm after recovery

2016-01-08 Thread Conn O'Griofa
On 08/01/16 19:17, Conn O'Griofa wrote: * In ag71xx_hw_enable, netif_start_queue is issued. Since this function is used for the fast restart, that should probably be changed to netif_wake_queue so that the kernel will check for anything pending in the queue to be sent (which is certain to be

Re: [OpenWrt-Devel] [PATCH] ar71xx: check for stuck DMA on AR724x & fix sirq storm after recovery

2016-01-08 Thread Conn O'Griofa
On 08/01/16 18:48, Conn O'Griofa wrote: Unfortunately, your proposed patch doesn't work. When I trigger the timeout condition, a tx timeout occurs and the interface doesn't recover correctly: I'm not able to test recompiles for a few hours at least, but: * After your patch failed, I already

Re: [OpenWrt-Devel] [PATCH] ar71xx: check for stuck DMA on AR724x & fix sirq storm after recovery

2016-01-08 Thread Conn O'Griofa
On 08/01/16 16:49, Felix Fietkau wrote: Thanks for investigating this further. Please try this patch: Unfortunately, your proposed patch doesn't work. When I trigger the timeout condition, a tx timeout occurs and the interface doesn't recover correctly: [ 249.075582] [ cut here

Re: [OpenWrt-Devel] [PATCH] ar71xx: check for stuck DMA on AR724x & fix sirq storm after recovery

2016-01-08 Thread Felix Fietkau
On 2016-01-08 06:26, Conn O'Griofa wrote: > Hi, > > I'm proposing the following patch to resolve ticket #18922 fully. > > With the current master revision, when a tx timeout condition occurs, > the interface recovers successfully, but a soft irq storm occurs > (causing ksoftirqd to peg the CPU, d

[OpenWrt-Devel] [PATCH] ar71xx: check for stuck DMA on AR724x & fix sirq storm after recovery

2016-01-07 Thread Conn O'Griofa
Hi, I'm proposing the following patch to resolve ticket #18922 fully. With the current master revision, when a tx timeout condition occurs, the interface recovers successfully, but a soft irq storm occurs (causing ksoftirqd to peg the CPU, due to this goto being called without end: https://gi