Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-15 Thread Rafał Miłecki
On 12 May 2015 at 19:31, Rafał Miłecki zaj...@gmail.com wrote: On 12 May 2015 at 15:10, Hante Meuleman meule...@broadcom.com wrote: Added two functions to the bcm47xx_nvram module to get and release copies of the complete nvram contents. This can be used by for example brcmfmac to get complete

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-13 Thread Felix Fietkau
On 2015-05-13 09:48, Hante Meuleman wrote: Initially I made the free an inline from header file, but it doesn't compile out of the box as it needs the definition for kfree and not all c files which include this header file had this, as I don't like the inclusion of header files from header

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-13 Thread Rafał Miłecki
On 13 May 2015 at 18:45, Felix Fietkau n...@openwrt.org wrote: On 2015-05-13 09:48, Hante Meuleman wrote: Initially I made the free an inline from header file, but it doesn't compile out of the box as it needs the definition for kfree and not all c files which include this header file had

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-13 Thread Felix Fietkau
On 2015-05-13 20:14, Hante Meuleman wrote: Bloated? Seriously? Putting the lines in either C or H and either have an additional include or a prototype (both 1 line). Having the function in the .c file along with the EXPORT_SYMBOL makes the kernel size bigger. Including the header file with an

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-13 Thread Ian Kent
On Wed, 2015-05-13 at 06:34 +0200, Rafał Miłecki wrote: On 13 May 2015 at 03:49, Ian Kent ra...@themaw.net wrote: On Tue, 2015-05-12 at 19:31 +0200, Rafał Miłecki wrote: On 12 May 2015 at 15:10, Hante Meuleman meule...@broadcom.com wrote: Added two functions to the bcm47xx_nvram module to

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-13 Thread Hante Meuleman
in the c file. -Original Message- From: Felix Fietkau [mailto:n...@openwrt.org] Sent: dinsdag 12 mei 2015 22:03 To: Hante Meuleman; OpenWrt Development List Subject: Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents. On 2015-05-12 15:10, Hante Meuleman

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-12 Thread Felix Fietkau
On 2015-05-12 15:10, Hante Meuleman wrote: Added two functions to the bcm47xx_nvram module to get and release copies of the complete nvram contents. This can be used by for example brcmfmac to get complete nvram contents which will after some parsing be sent to device. Signed-off-by:

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-12 Thread Rafał Miłecki
On 12 May 2015 at 15:10, Hante Meuleman meule...@broadcom.com wrote: Added two functions to the bcm47xx_nvram module to get and release copies of the complete nvram contents. This can be used by for example brcmfmac to get complete nvram contents which will after some parsing be sent to

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-12 Thread Ian Kent
On Tue, 2015-05-12 at 19:31 +0200, Rafał Miłecki wrote: On 12 May 2015 at 15:10, Hante Meuleman meule...@broadcom.com wrote: Added two functions to the bcm47xx_nvram module to get and release copies of the complete nvram contents. This can be used by for example brcmfmac to get complete

[OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-12 Thread Hante Meuleman
Added two functions to the bcm47xx_nvram module to get and release copies of the complete nvram contents. This can be used by for example brcmfmac to get complete nvram contents which will after some parsing be sent to device. Signed-off-by: Hante Meuleman meule...@broadcom.com --- diff --git

Re: [OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

2015-05-12 Thread Rafał Miłecki
On 13 May 2015 at 03:49, Ian Kent ra...@themaw.net wrote: On Tue, 2015-05-12 at 19:31 +0200, Rafał Miłecki wrote: On 12 May 2015 at 15:10, Hante Meuleman meule...@broadcom.com wrote: Added two functions to the bcm47xx_nvram module to get and release copies of the complete nvram contents.