[OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Ugur DOGRU
This patch is for firewall/iptables. Most of it is to fix some hush script problems. Adds also some SPI rule to firewall script. diff -ruN package/firewall/files/20-firewall package-after/firewall/files/20-firewall --- package/firewall/files/20-firewall2009-10-06 15:41:25.0 +030

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Malte S. Stretz
On Tuesday 20 October 2009 14:58:49 Ugur DOGRU wrote: > This patch is for firewall/iptables. Most of it is to fix some hush > script problems. >[...] As most other init/hotplug scripts don't work with hush as well, I wonder why you went for the firewall only :) What you "fixed" are actually not

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Malte. > [...] > Maybe you should just add the 50k and use ash instead? As far as I know is "hush" a requirement of the platform (no mmu) and I think "ash" does not work on non-mmu + non-fork platforms. ~ JoW -BEGIN PGP SIGNATURE- Version

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. What about "emulating" local with something like the following? local() { eval "$1=''"; } This way you can keep the current scripts and handle the not-implemented local gracefully. ~ JoW -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GN

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Florian Fainelli
Hi, On Tuesday 20 October 2009 17:48:34 Jo-Philipp Wich wrote: > Hi. > > What about "emulating" local with something like the following? > > local() { eval "$1=''"; } > > This way you can keep the current scripts and handle the not-implemented > local gracefully. I definitively prefer that solu

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The following function supports multiple args like the original "local". if ! type "local" >/dev/null; then local() { for _v in $*; do eval "$_v=''"; done } fi If you add that to /etc/profile (is that supported by hus

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Felix Fietkau
Jo-Philipp Wich wrote: > The following function supports multiple args like the original "local". > > if ! type "local" >/dev/null; then > local() { > for _v in $*; do eval "$_v=''"; done > } > fi > > > If you add that to /etc/profile (is that supported by hush?) then i

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Ugur Dogru
witch" mechanism between ash/hush is the solution to "isolate" different behaviour of shells. regards ugur -Original Message- From: openwrt-devel-boun...@lists.openwrt.org on behalf of Malte S. Stretz Sent: Tue 20.10.2009 16:51 To: OpenWrt Development List Subject: Re: [

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Ugur DOGRU
Good idea. but, not sure that "type" supported by hush. ugur Jo-Philipp Wich wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The following function supports multiple args like the original "local". if ! type "local" >/dev/null; then local() { for _v in $*; do eva

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-10-20 Thread Bayram Kurumahmut
...@lists.openwrt.org on behalf of Florian Fainelli Sent: Tue 10/20/2009 09:03 To: openwrt-devel@lists.openwrt.org Subject: Re: [OpenWrt-Devel] [PATCH] firewall/iptables Hi, On Tuesday 20 October 2009 17:48:34 Jo-Philipp Wich wrote: > Hi. > > What about "emulating" local with something

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-12-08 Thread Ugur DOGRU
Hi, After getting busybox 1.15.2, "local" macro is not a problem now. So I removed all modifications that removes local. To remind it, these changes are for ubicom32 platform, but for all no-mmu platforms in general. As ash cannot run on no-mmu system, we are using hush instead. There are st

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-12-08 Thread Bastian Bittorf
* Ugur DOGRU [08.12.2009 13:40]: > > 1/ hush needs "eval" to substitute string. > 2/ hush doesn't handle line concatenation : "\" > 3/ hush crashes if two scripts include each other. (uci_firewall.sh and > /etc/hotplug.d/iface/20-firewall includes each other) Thanks for your work - is there any

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-12-09 Thread Felix Fietkau
On 2009-12-08 1:36 PM, Ugur DOGRU wrote: > > Hi, > > After getting busybox 1.15.2, "local" macro is not a problem now. So I > removed all modifications that removes local. > To remind it, these changes are for ubicom32 platform, but for all > no-mmu platforms in general. > As ash cannot run on

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-12-10 Thread Ugur DOGRU
Felix Fietkau wrote: On 2009-12-08 1:36 PM, Ugur DOGRU wrote: Hi, After getting busybox 1.15.2, "local" macro is not a problem now. So I removed all modifications that removes local. To remind it, these changes are for ubicom32 platform, but for all no-mmu platforms in general. As ash can

Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-12-21 Thread Ugur DOGRU
Hi Felix, I am attaching two scripts that showing problems I reported. there are script results below, that I got. I am using BusyBox v1.15.3 from latest trunk code(r18874). Thanks ugur /tmp # ./test_sh1.sh WITHOUT_EVAL: $proto WITH_EVAL: tcp /tmp # *