Re: [OpenWrt-Devel] [PATCH] firewall: Fix Wformat-nonliteral warning

2019-12-01 Thread Rosen Penev
> On Dec 1, 2019, at 5:55 AM, Jonas Gorski wrote: > > Hi, > >> On Fri, 29 Nov 2019 at 22:06, Rosen Penev wrote: >> >> Allows GCC to check the formats by switching to a define, which is a >> constant expression. >> >> Fixes: >> >> warning: format not a string literal, argument types not

Re: [OpenWrt-Devel] [PATCH] firewall: Fix Wformat-nonliteral warning

2019-12-01 Thread Jonas Gorski
Hi, On Fri, 29 Nov 2019 at 22:06, Rosen Penev wrote: > > Allows GCC to check the formats by switching to a define, which is a > constant expression. > > Fixes: > > warning: format not a string literal, argument types not checked > [-Wformat-nonliteral] > 207 | snprintf(buf, sizeof(buf), tmpl,

[OpenWrt-Devel] [PATCH] firewall: Fix Wformat-nonliteral warning

2019-11-29 Thread Rosen Penev
Allows GCC to check the formats by switching to a define, which is a constant expression. Fixes: warning: format not a string literal, argument types not checked [-Wformat-nonliteral] 207 | snprintf(buf, sizeof(buf), tmpl, include->path); Signed-off-by: Rosen Penev --- includes.c | 10