Hi,
nitpick inline
John
On 13/07/2015 16:16, Stephan Maka wrote:
> This is very useful for trimming images towards 4 MiB flash size.
>
> Signed-off-by: Stephan Maka
> ---
> tools/firmware-utils/src/mktplinkfw.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletion
On Mon, Jul 13, 2015 at 6:04 PM, Jonathan Bennett wrote:
> So, the real problem is that for some reason, my system is ignoring the make
> error.
I think there was a discussion some time ago that images that are "too
large" should not break the whole image-builder (for nightlies,
release-builds, et
My comments weren't a critique of your patch, and probably belong in a
separate thread, or even a bug report on dev.openwrt.org.
Apparently the behavior my machine is showing is not the normal or intended
behavior. On my machine (Fedora 22, but also had the issue in Fedora 21, if
I remember correc
Jonathan Bennett wrote:
> Tested and seems to work as intended. However, I think the image too big
> messages should be printed at the default verbosity.
The patch doesn't change any levels.
> Currently, if make fails to generate the final image, it doesn't give any
> message to acknowledge, and
Tested and seems to work as intended. However, I think the image too big
messages should be printed at the default verbosity.
Currently, if make fails to generate the final image, it doesn't give any
message to acknowledge, and appears to have succeeded, there are just
"mysteriously" missing files
This is very useful for trimming images towards 4 MiB flash size.
Signed-off-by: Stephan Maka
---
tools/firmware-utils/src/mktplinkfw.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tools/firmware-utils/src/mktplinkfw.c
b/tools/firmware-utils/src/mkt
