[OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap redux

2018-08-03 Thread Christian Lamparter
Jonas Gorski commented on the previous patch: |This is actually the wrong fix and papers over an issue in one of our |local patches. | |We intentionally allow regmap to be built as a module, see | |/target/linux/generic/hack-4.14/259-regmap_dynamic.patch |[...] |[The regulator code] optionally

Re: [OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap

2018-08-03 Thread Jonas Gorski
On 3 August 2018 at 18:00, Christian Lamparter wrote: > diff --git a/package/kernel/linux/modules/other.mk > b/package/kernel/linux/modules/other.mk > index dd037cf86c..7e18a21db3 100644 > --- a/package/kernel/linux/modules/other.mk > +++ b/package/kernel/linux/modules/other.mk > @@ -718,7

Re: [OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap

2018-08-03 Thread Christian Lamparter
On Thursday, August 2, 2018 11:43:50 AM CEST Jonas Gorski wrote: > On 1 August 2018 at 22:44, Christian Lamparter wrote: >> On Wednesday, August 1, 2018 3:21:00 PM CEST Jonas Gorski wrote: >>> On 30/07/18 22:33, Christian Lamparter wrote: This patch fixes the a compile issue that was

Re: [OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap

2018-08-02 Thread Jonas Gorski
On 1 August 2018 at 22:44, Christian Lamparter wrote: > On Wednesday, August 1, 2018 3:21:00 PM CEST Jonas Gorski wrote: >> On 30 July 2018 at 22:35, John Crispin wrote: >> > On 30/07/18 22:33, Christian Lamparter wrote: >> >> >> >> This patch fixes the a compile issue that was triggered by >>

Re: [OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap

2018-08-01 Thread Christian Lamparter
On Wednesday, August 1, 2018 3:21:00 PM CEST Jonas Gorski wrote: > On 30 July 2018 at 22:35, John Crispin wrote: > > On 30/07/18 22:33, Christian Lamparter wrote: > >> > >> This patch fixes the a compile issue that was triggered by > >> apm821xx/sata when kmod-regmap was selected. > >> > >> The

Re: [OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap

2018-08-01 Thread Jonas Gorski
On 30 July 2018 at 22:35, John Crispin wrote: > > > On 30/07/18 22:33, Christian Lamparter wrote: >> >> This patch fixes the a compile issue that was triggered by >> apm821xx/sata when kmod-regmap was selected. >> >> The CONFIG_REGMAP is declared in drivers/base/regmap/Kconfig >> as type "bool"

Re: [OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap

2018-07-30 Thread John Crispin
On 30/07/18 22:33, Christian Lamparter wrote: This patch fixes the a compile issue that was triggered by apm821xx/sata when kmod-regmap was selected. The CONFIG_REGMAP is declared in drivers/base/regmap/Kconfig as type "bool" and not "tristate". Hence the symbol should never be set to

[OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap

2018-07-30 Thread Christian Lamparter
This patch fixes the a compile issue that was triggered by apm821xx/sata when kmod-regmap was selected. The CONFIG_REGMAP is declared in drivers/base/regmap/Kconfig as type "bool" and not "tristate". Hence the symbol should never be set to module, as this confuses the #if CONFIG_REGMAP guards in