Before this patch, if we specify a plugin specific option through `pppd_options` in /etc/config/network, e.g. `rp_pppoe_verbose 1`, pppd would quit with the following error in log.
Wed Oct 9 09:42:58 2013 daemon.notice netifd: GORG (1689): /usr/sbin/pppd: unrecognized option 'rp_pppoe_verbose' Wed Oct 9 09:42:58 2013 daemon.err pppd[1689]: unrecognized option 'rp_pppoe_verbose' Wed Oct 9 09:42:58 2013 daemon.notice netifd: GORG (1689): pppd version 2.4.5 Wed Oct 9 09:42:58 2013 daemon.notice netifd: GORG (1689): Usage: /usr/sbin/pppd [ options ], where options are: This is due to the requirement that function add_option() should be called by the plugin_init() function first before pppd can parse those options. Signed-off-by: Yousong Zhou <yszhou4t...@gmail.com> --- package/network/services/ppp/files/ppp.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/package/network/services/ppp/files/ppp.sh b/package/network/services/ppp/files/ppp.sh index 02b4055..284d44c 100755 --- a/package/network/services/ppp/files/ppp.sh +++ b/package/network/services/ppp/files/ppp.sh @@ -55,7 +55,7 @@ ppp_generic_setup() { ip-down-script /lib/netifd/ppp-down \ ipv6-down-script /lib/netifd/ppp-down \ ${mtu:+mtu $mtu mru $mtu} \ - $pppd_options "$@" + "$@" $pppd_options } ppp_generic_teardown() { -- 1.7.2.5 _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel