[OpenWrt-Devel] [PATCH] procd: instance: Support deleting stopped instances

2019-03-13 Thread Kristian Evensen
procd currently does not support deleting a stopped instance. The reason is that we return in instance_stop(), if pending is set to false. This patch adds a new function, instance_delete(), which does the necessary clean-up of an instance. instance_delete() is called before we return in instance_st

Re: [OpenWrt-Devel] [PATCH] procd: instance: Support deleting stopped instances

2019-04-04 Thread Hans Dedecker
On Wed, Mar 13, 2019 at 4:44 PM Kristian Evensen wrote: > > procd currently does not support deleting a stopped instance. The reason > is that we return in instance_stop(), if pending is set to false. This > patch adds a new function, instance_delete(), which does the necessary > clean-up of an in

Re: [OpenWrt-Devel] [PATCH] procd: instance: Support deleting stopped instances

2019-04-06 Thread Kristian Evensen
Hi Hans, On Thu, Apr 4, 2019 at 10:59 PM Hans Dedecker wrote: > instance_delete should only be called when halt is set to true similar > as in instance_exit Thanks for the feedback. Just so I make sure I understand correctly, do you mean that the conditional should look something like this? 57

Re: [OpenWrt-Devel] [PATCH] procd: instance: Support deleting stopped instances

2019-04-06 Thread Hans Dedecker
On Sat, Apr 6, 2019 at 12:27 PM Kristian Evensen wrote: > > Hi Hans, > > On Thu, Apr 4, 2019 at 10:59 PM Hans Dedecker wrote: > > instance_delete should only be called when halt is set to true similar > > as in instance_exit > > Thanks for the feedback. Just so I make sure I understand correctly,