[OpenWrt-Devel] [PATCH] runqueue: Fix the callbacks order in runqueue_task_kill()

2019-06-21 Thread Alban Bedel
Since commit 11e8afea (runqueue should cal the complete handler from more places) the call to the complete() callback has been moved to runqueue_task_complete(). However in runqueue_task_kill() runqueue_task_complete() is called before the kill() callback. This will result in a use after free if t

Re: [OpenWrt-Devel] [PATCH] runqueue: Fix the callbacks order in runqueue_task_kill()

2019-07-01 Thread John Crispin
On 21/06/2019 17:38, Alban Bedel wrote: Since commit 11e8afea (runqueue should cal the complete handler from more places) the call to the complete() callback has been moved to runqueue_task_complete(). However in runqueue_task_kill() runqueue_task_complete() is called before the kill() callback

Re: [OpenWrt-Devel] [PATCH] runqueue: Fix the callbacks order in runqueue_task_kill()

2019-07-01 Thread Alban
On Mon, 1 Jul 2019 15:48:47 +0200 John Crispin wrote: > On 21/06/2019 17:38, Alban Bedel wrote: > > Since commit 11e8afea (runqueue should cal the complete handler from > > more places) the call to the complete() callback has been moved to > > runqueue_task_complete(). However in runqueue_task_k

Re: [OpenWrt-Devel] [PATCH] runqueue: Fix the callbacks order in runqueue_task_kill()

2019-07-01 Thread John Crispin
On 01/07/2019 16:23, Alban wrote: On Mon, 1 Jul 2019 15:48:47 +0200 John Crispin wrote: On 21/06/2019 17:38, Alban Bedel wrote: Since commit 11e8afea (runqueue should cal the complete handler from more places) the call to the complete() callback has been moved to runqueue_task_complete().

Re: [OpenWrt-Devel] [PATCH] runqueue: Fix the callbacks order in runqueue_task_kill()

2020-03-11 Thread Petr Štetiar
Alban [2019-07-01 16:23:42]: Hi, sorry for the late response, but I've just noticed, that it's related to libubox and got interested. I would use "PATCH libubox" subject next time so it's more clear at first sight. > No, TBH I haven't tested this, but as there is no documentation I had > to go