Re: [OpenWrt-Devel] [PATCH 1/2] scripts: fix recursive dependencies that might be caused by using conditional dependencies.

2014-12-23 Thread Yousong Zhou
On 22 December 2014 at 18:29, Yousong Zhou wrote: > `kmod-ipt-ipset' has a `DEPENDS' value of > `@(!(TARGET_ps3||TARGET_pxcab)||BROKEN)'. > Recursive dependency will occur if another package conditionally depends > on it with something like `+PACKAGE_dnsmasq_full_ipset:kmod-ipt-ipset' > which wil

Re: [OpenWrt-Devel] [PATCH 1/2] scripts: fix recursive dependencies that might be caused by using conditional dependencies.

2014-12-22 Thread Yousong Zhou
On 23 December 2014 at 09:38, Yousong Zhou wrote: > Should be `=` in this case. But the patch now looks wrong anyway. I Should be `eq' ! Dizzy in the morning, sorry. > will try digging through it. ___ openwrt-devel mailing list openwrt-devel@lists.o

Re: [OpenWrt-Devel] [PATCH 1/2] scripts: fix recursive dependencies that might be caused by using conditional dependencies.

2014-12-22 Thread Yousong Zhou
On 22 December 2014 at 22:42, Felix Fietkau wrote: > This doesn't look right to me. It seems to be overwriting $condition. > Did you mean eq instead of =? Should be `=` in this case. But the patch now looks wrong anyway. I will try digging through it. yousong ___

Re: [OpenWrt-Devel] [PATCH 1/2] scripts: fix recursive dependencies that might be caused by using conditional dependencies.

2014-12-22 Thread Felix Fietkau
On 2014-12-22 11:29, Yousong Zhou wrote: > `kmod-ipt-ipset' has a `DEPENDS' value of > `@(!(TARGET_ps3||TARGET_pxcab)||BROKEN)'. > Recursive dependency will occur if another package conditionally depends > on it with something like `+PACKAGE_dnsmasq_full_ipset:kmod-ipt-ipset' > which will produce

[OpenWrt-Devel] [PATCH 1/2] scripts: fix recursive dependencies that might be caused by using conditional dependencies.

2014-12-22 Thread Yousong Zhou
`kmod-ipt-ipset' has a `DEPENDS' value of `@(!(TARGET_ps3||TARGET_pxcab)||BROKEN)'. Recursive dependency will occur if another package conditionally depends on it with something like `+PACKAGE_dnsmasq_full_ipset:kmod-ipt-ipset' which will produce the following kconfig content. config PACK