Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: enable LEDS_TRIGGER_MTD support

2018-12-03 Thread John Crispin
On 03/12/2018 09:37, Florian Eckert wrote: Hello John this is a very specific feature and I dont see any devices in tree using the driver. it'll increase the image size and we have several small flashed units in the target. cant you simplly make it AutoProbe during preinit ? there is next to

Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: enable LEDS_TRIGGER_MTD support

2018-12-03 Thread Florian Eckert
Hello John this is a very specific feature and I dont see any devices in tree using the driver. It is also correct that no image use this trigger per default. But it is still possible for someone to put this trigger on a user defined LED if he wants. it'll increase the image size and we ha

Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: enable LEDS_TRIGGER_MTD support

2018-12-03 Thread Florian Eckert
Hello John this is a very specific feature and I dont see any devices in tree using the driver. it'll increase the image size and we have several small flashed units in the target. cant you simplly make it AutoProbe during preinit ? there is next to no flash activity until preinit anyway. I

Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: enable LEDS_TRIGGER_MTD support

2018-12-02 Thread John Crispin
On 30/11/2018 00:48, Mathias Kresin wrote: 29/11/2018 14:25, Florian Eckert: Enable mtd led trigger for lantiq devices by default to show MTD activity Hi, this is a very specific feature and I dont see any devices in tree using the driver. it'll increase the image size and we have several s

Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: enable LEDS_TRIGGER_MTD support

2018-11-29 Thread Mathias Kresin
29/11/2018 14:25, Florian Eckert: Enable mtd led trigger for lantiq devices by default to show MTD activity Signed-off-by: Florian Eckert --- target/linux/lantiq/config-4.14 | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/lantiq/config-4.14 b/target/linux/lantiq/config-4.14

[OpenWrt-Devel] [PATCH 2/2] lantiq: enable LEDS_TRIGGER_MTD support

2018-11-29 Thread Florian Eckert
Enable mtd led trigger for lantiq devices by default to show MTD activity Signed-off-by: Florian Eckert --- target/linux/lantiq/config-4.14 | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/lantiq/config-4.14 b/target/linux/lantiq/config-4.14 index 055a428792..938aafc1f5 100644 --