Re: [OpenWrt-Devel] [PATCH 2/2] ppp: fix o_special option printing

2014-05-11 Thread Yousong Zhou
>>> ++ printer(arg, "%q", p); >>> + } else if (opt->flags & OPT_A2LIST) { >>> + struct option_value *ovp; >>> + >>> -- >>> 1.9.0 >>> ___ >>> openwrt-devel mailing list >>> openwrt-devel@lists.openwrt.org >>&g

Re: [OpenWrt-Devel] [PATCH 2/2] ppp: fix o_special option printing

2014-05-11 Thread Nathan Hintz
-- >> 1.9.0 >> ___ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ---- > From: yszhou4t...@gm

Re: [OpenWrt-Devel] [PATCH 2/2] ppp: fix o_special option printing

2014-05-06 Thread Yousong Zhou
Hi, Nathan. On 7 May 2014 13:25, Nathan Hintz wrote: > > PPPD crashes (SEGV) when the 'dump' or 'dryrun' options are specified and > an option defined internally as "o_special" with an option flag of > "OPT_A2STRVAL" is used. The crash occurs because the option value is not > saved when the para

[OpenWrt-Devel] [PATCH 2/2] ppp: fix o_special option printing

2014-05-06 Thread Nathan Hintz
PPPD crashes (SEGV) when the 'dump' or 'dryrun' options are specified and an option defined internally as "o_special" with an option flag of "OPT_A2STRVAL" is used. The crash occurs because the option value is not saved when the parameter is processed, but is then referenced when printed. Additio