Re: [OpenWrt-Devel] [PATCH 2/3] ramips: Add base-files for HiWiFi HC5x61 models

* Comman Kang [28.09.2015 17:37]: > Mostly done, except this one > > >+ hiwifi-hc5*61) > >+ __fac_mac=`strings /dev/mtd7 | grep 'fac_mac = > >..:..:..:..:..:..'` > >+ lan_mac=`expr "$__fac_mac" : '.*\(..:..:..:..:..:..\)' | tr > >'[A-Z]'

Re: [OpenWrt-Devel] [PATCH 2/3] ramips: Add base-files for HiWiFi HC5x61 models

Hello, 2015-09-28 16:52 GMT+02:00 Comman Kang : > Mostly done, except this one > >>+ hiwifi-hc5*61) >>+ __fac_mac=`strings /dev/mtd7 | grep 'fac_mac = >>..:..:..:..:..:..'` >>+ lan_mac=`expr "$__fac_mac" : '.*\(..:..:..:..:..:..\)' | tr

Re: [OpenWrt-Devel] [PATCH 2/3] ramips: Add base-files for HiWiFi HC5x61 models

Mostly done, except this one >+ hiwifi-hc5*61) >+ __fac_mac=`strings /dev/mtd7 | grep 'fac_mac = >..:..:..:..:..:..'` >+ lan_mac=`expr "$__fac_mac" : '.*\(..:..:..:..:..:..\)' | tr >'[A-Z]' '[a-z]'` Is that really needed? >+ [ -n "$lan_mac" ] ||

Re: [OpenWrt-Devel] [PATCH 2/3] ramips: Add base-files for HiWiFi HC5x61 models

Hello, Please, see my comments inline, below. PS. Sorry for being so pedantic :) Cheers, Piotr 2015-09-28 12:46 GMT+02:00 Comman Kang : > HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com. > These models have similar hardware specs(MT7620A + 128M DDR2 +

[OpenWrt-Devel] [PATCH 2/3] ramips: Add base-files for HiWiFi HC5x61 models

HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com. These models have similar hardware specs(MT7620A + 128M DDR2 + 16M flash). This patch adds support for them. The original author is Justin Liu (rss...@gmail.com). I ported the patch to trunk and submitted it here with