[OpenWrt-Devel] [PATCH 2/5] ar71xx: Clear bits in ath79_setup_qca955x_eth_cfg

2016-03-08 Thread Sven Eckelmann
From: Sven Eckelmann Some u-boot versions for QCA955x set currently not cleared bits depending on the used link speed. This breaks the rx/tx under OpenWrt. The mach-*.c file is responsible to select the correct configuration bits and thus the ath79_setup_qca955x_eth_cfg has to clear the unset. S

Re: [OpenWrt-Devel] [PATCH 2/5] ar71xx: Clear bits in ath79_setup_qca955x_eth_cfg

2016-03-19 Thread John Crispin
On 17/03/2016 09:12, Sven Eckelmann wrote: > On Wednesday 16 March 2016 23:47:02 John Crispin wrote: > [...] >> this seems to break boards that rely on the bits being set byt the >> bootloader and dont explicitly set them in the kernel. i'll revert the >> series when i am at my work pc tomorrow.

Re: [OpenWrt-Devel] [PATCH 2/5] ar71xx: Clear bits in ath79_setup_qca955x_eth_cfg

2016-03-19 Thread Sven Eckelmann
On Wednesday 16 March 2016 23:47:02 John Crispin wrote: [...] > this seems to break boards that rely on the bits being set byt the > bootloader and dont explicitly set them in the kernel. i'll revert the > series when i am at my work pc tomorrow. Thats why I've Cc'ed the authors of the other mach-

Re: [OpenWrt-Devel] [PATCH 2/5] ar71xx: Clear bits in ath79_setup_qca955x_eth_cfg

2016-03-19 Thread John Crispin
On 08/03/2016 18:39, Sven Eckelmann wrote: > From: Sven Eckelmann > > Some u-boot versions for QCA955x set currently not cleared bits depending > on the used link speed. This breaks the rx/tx under OpenWrt. The mach-*.c > file is responsible to select the correct configuration bits and thus the

Re: [OpenWrt-Devel] [PATCH 2/5] ar71xx: Clear bits in ath79_setup_qca955x_eth_cfg

2016-03-19 Thread John Crispin
On 17/03/2016 09:21, Sven Eckelmann wrote: > On Thursday 17 March 2016 09:14:55 John Crispin wrote: >>> Now I have to move the function to each mach file which correctly sets the >>> ETH_CFG to avoid problems caused by the u-boot presets. This requires that >>> you still keep the patch for the QC

Re: [OpenWrt-Devel] [PATCH 2/5] ar71xx: Clear bits in ath79_setup_qca955x_eth_cfg

2016-03-19 Thread Sven Eckelmann
On Thursday 17 March 2016 09:14:55 John Crispin wrote: > > Now I have to move the function to each mach file which correctly sets the > > ETH_CFG to avoid problems caused by the u-boot presets. This requires that > > you still keep the patch for the QCA955X_ETH_CFG_* definition. > > > > so i'll k