Re: [OpenWrt-Devel] [PATCH 3/8] brcm2708: split target config into subtargets

2015-07-14 Thread John Crispin
although this is not common practice i find the default way of handling config files sub optimal and error prone. this is why i do what you proposed for ramips already. lets see if anyone else complains otherise i am fine with this change On 14/07/2015 20:15, Álvaro Fernández Rojas wrote: > Sign

Re: [OpenWrt-Devel] [PATCH 3/8] brcm2708: split target config into subtargets

2015-07-14 Thread Álvaro Fernández Rojas
Nope, just "make kernel_menuconfig". Anyway, I think we should separate the config because there are many differences between both subtargets. El 14/07/2015 a las 20:48, John Crispin escribió: > How did you call menuconfig ... using "make kernel_menuconfig > CONFIG_TARGET=subtarget" ? > > On 14/

Re: [OpenWrt-Devel] [PATCH 3/8] brcm2708: split target config into subtargets

2015-07-14 Thread John Crispin
How did you call menuconfig ... using "make kernel_menuconfig CONFIG_TARGET=subtarget" ? On 14/07/2015 20:33, Álvaro Fernández Rojas wrote: > With the previous setup if you called kernel_menuconfig it resulted in > totally breaking the target config for both subtargets. > > El 14/07/2015 a las 2

Re: [OpenWrt-Devel] [PATCH 3/8] brcm2708: split target config into subtargets

2015-07-14 Thread Álvaro Fernández Rojas
With the previous setup if you called kernel_menuconfig it resulted in totally breaking the target config for both subtargets. El 14/07/2015 a las 20:31, Rafał Miłecki escribió: > On 14 July 2015 at 20:15, Álvaro Fernández Rojas wrote: >> Signed-off-by: Álvaro Fernández Rojas > > And some expl

Re: [OpenWrt-Devel] [PATCH 3/8] brcm2708: split target config into subtargets

2015-07-14 Thread Rafał Miłecki
On 14 July 2015 at 20:15, Álvaro Fernández Rojas wrote: > Signed-off-by: Álvaro Fernández Rojas And some explanation *why*? I guess it may be obvious for you (and John?) but would be nice to include such info for other ppl :) ___ openwrt-devel mailing

[OpenWrt-Devel] [PATCH 3/8] brcm2708: split target config into subtargets

2015-07-14 Thread Álvaro Fernández Rojas
Signed-off-by: Álvaro Fernández Rojas --- target/linux/brcm2708/bcm2708/config-3.18| 326 target/linux/brcm2708/bcm2708/config-default | 4 - target/linux/brcm2708/bcm2709/config-3.18| 358 +++ target/linux/brcm2708/bcm2709/config-default