Re: [OpenWrt-Devel] [PATCH procd 3/4] ujail: use const, stop using extern

2015-11-24 Thread John Crispin
ok, subject and description are not consistent. please split this up properly. one kind of change / patch On 23/11/2015 09:09, Etienne Champetier wrote: > Hi > Le 23 nov. 2015 08:19, "John Crispin" > a écrit : >> >> Hi, >> >> subject relates to extern but then the patch

Re: [OpenWrt-Devel] [PATCH procd 3/4] ujail: use const, stop using extern

2015-11-23 Thread Etienne Champetier
Hi Le 23 nov. 2015 08:19, "John Crispin" a écrit : > > Hi, > > subject relates to extern but then the patch adds const. please make the > description consistent with the content > The subject do start with "use const" I will improve it in v2 > John > > On 23/11/2015 01:39, Etienne CHAMPE

Re: [OpenWrt-Devel] [PATCH procd 3/4] ujail: use const, stop using extern

2015-11-22 Thread John Crispin
Hi, subject relates to extern but then the patch adds const. please make the description consistent with the content John On 23/11/2015 01:39, Etienne CHAMPETIER wrote: > extern for function declaration in '.h' doesn't make sense > > Signed-off-by: Etienne CHAMPETIER > --- > jail/elf.

[OpenWrt-Devel] [PATCH procd 3/4] ujail: use const, stop using extern

2015-11-22 Thread Etienne CHAMPETIER
extern for function declaration in '.h' doesn't make sense Signed-off-by: Etienne CHAMPETIER --- jail/elf.c | 28 +++- jail/elf.h | 10 +- 2 files changed, 20 insertions(+), 18 deletions(-) diff --git a/jail/elf.c b/jail/elf.c index 34a5aca..a26aa0b 100644 --- a/