Re: [OpenWrt-Devel] [PATCH v3 2/7] ath79: dev-eth: initialize clock for id 0 on AR934X

2015-07-09 Thread Guenther Kelleter
Hi > -Original Message- > From: John Crispin [mailto:blo...@openwrt.org] > Sent: Thursday, July 09, 2015 8:32 AM > To: Guenther Kelleter; openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH v3 2/7] ath79: dev-eth: initialize clock > for id 0

Re: [OpenWrt-Devel] [PATCH v3 2/7] ath79: dev-eth: initialize clock for id 0 on AR934X

2015-07-08 Thread John Crispin
Hi, looking closer at the code i noticed that you need to do this as ath79_mdio1_data is not initialized to 0 properly. the reason being that it is not static and that in turn is because the header file declares it as extern yet there are no users. i would suggest you drop this patch and instead

[OpenWrt-Devel] [PATCH v3 2/7] ath79: dev-eth: initialize clock for id 0 on AR934X

2015-07-07 Thread Günther Kelleter
Signed-off-by: Günther Kelleter --- target/linux/ar71xx/files/arch/mips/ath79/dev-eth.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/linux/ar71xx/files/arch/mips/ath79/dev-eth.c b/target/linux/ar71xx/files/arch/mips/ath79/dev-eth.c index ff94e2e..c7524be 10064