On 04/12/18 04:53 PM, Petr Štetiar wrote:
Please try to follow DRY principles and don't copy the same code over
again. I mean something like this:
er_move_config() {
local dev="$1"
mount -t vfat "$dev" /mnt
[ -f /mnt/sysupgrade.tgz ] && mv -f /mnt/sysupgrade.tgz
Jonathan Thibault [2018-12-04 14:59:32]:
Hi,
sorry, that I've missed previous review rounds.
> diff --git a/target/linux/octeon/base-files/lib/preinit/79_move_config
> b/target/linux/octeon/base-files/lib/preinit/79_move_config
> index ec63d9f5ff..470cbfe005 100644
> ---
---
target/linux/octeon/base-files/lib/preinit/79_move_config | 5 +
target/linux/octeon/base-files/lib/upgrade/platform.sh| 5 +
2 files changed, 10 insertions(+)
diff --git a/target/linux/octeon/base-files/lib/preinit/79_move_config
