Re: [OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-31 Thread Felix Fietkau
On 2014-01-16 13:40, Sven Eckelmann wrote: From: Matti Laakso malaa...@elisanet.fi This patch introduces 802.11ac support to base-files, mac80211 and hostapd. The split of VHT160 in two 80 MHz bands is not yet supported, since it requires an additional user supplied parameter for the

Re: [OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-31 Thread Sven Eckelmann
On Friday 31 January 2014 03:54:19 Felix Fietkau wrote: --- a/package/base-files/files/sbin/wifi +++ b/package/base-files/files/sbin/wifi @@ -72,7 +72,7 @@ prepare_key_wep() { wifi_fixup_hwmode() { local device=$1 local default=$2 - local hwmode hwmode_11n +

Re: [OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-31 Thread Sven Eckelmann
On Friday 31 January 2014 06:06:58 Felix Fietkau wrote: [...] I think all of the above changes are unnecessary. Because of your next suggestion or is there another reason? Because it's touching legacy code that will not be used for 802.11ac drivers. wifi_fixup_hwmode is not called from

Re: [OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-31 Thread Matti Laakso
I actually want to get rid of ht_capab as well, because it's annoying to deal with wrt. UI, config changes, etc. It also makes it more annoying to port configs between devices (capabilities might be different). I would prefer enabling all capabilities by default (aside from the mode related

Re: [OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-31 Thread Rafał Miłecki
2014-01-31 Sven Eckelmann s...@open-mesh.com: I think reusing htmode instead of introducing vhtmode would be a better choice, especially since it never makes sense to configure both separately. So we would change it to just use VHT40, VHT80, VHT160 and someone could later introduce options to

Re: [OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-31 Thread Rafał Miłecki
2014-01-31 Felix Fietkau n...@openwrt.org: I think we should probably introduce a new option that avoids the overload of mode and band into one single option. We can keep backwards compatibility for 11n. I am not quite sure what you want to say here. You seem to want to have 11n and band

Re: [OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-31 Thread Bastian Bittorf
* Rafał Miłecki zaj...@gmail.com [31.01.2014 18:20]: On the other way, it doesn't make much sense to switch into 5GHz and 2GHz, as this can be determined using just a channel number... not really. some channels are available in 2 and 5 GHz band. (e.g. channel 7,8,9,11,12) bye, bastian

Re: [OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-31 Thread Rafał Miłecki
2014-01-31 Bastian Bittorf bitt...@bluebottle.com: * Rafał Miłecki zaj...@gmail.com [31.01.2014 18:20]: On the other way, it doesn't make much sense to switch into 5GHz and 2GHz, as this can be determined using just a channel number... not really. some channels are available in 2 and 5 GHz

[OpenWrt-Devel] [PATCHv2 1/2] wifi: Introduce 802.11ac support

2014-01-16 Thread Sven Eckelmann
From: Matti Laakso malaa...@elisanet.fi This patch introduces 802.11ac support to base-files, mac80211 and hostapd. The split of VHT160 in two 80 MHz bands is not yet supported, since it requires an additional user supplied parameter for the channel of the second band. Signed-off-by: Matti