Re: [OpenWrt-Devel] Changeset 29355 - OpenVPN option enable and Luci

2011-11-30 Thread Sven Roederer
So maybe the question is: "is the change of the option required or should we stay at 'enable'?" Sven signature.asc Description: This is a digitally signed message part. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openw

Re: [OpenWrt-Devel] Changeset 29355 - OpenVPN option enable and Luci

2011-11-30 Thread Sven Roederer
The changelog stats: r29167 | nico | 2011-11-16 10:44:00 packages/openvpn: use new service functions, change 'enable' option to 'enabled' like most other services are using So the cause is more cosmetic / consistency of options. Am Mittwoch, 30. November 2011 schrieb Philip Prindeville: > I agr

Re: [OpenWrt-Devel] Changeset 29355 - OpenVPN option enable and Luci

2011-11-30 Thread Jo-Philipp Wich
Current LuCI covers both backfire and trunk. Applying your fix will break backfire, not applying your fix will break trunk. Merging current OpenVPN to Backfire will break existing configs, just accepting enable and enabled breaks nothing - easy choice. ~ Jow ___

Re: [OpenWrt-Devel] Changeset 29355 - OpenVPN option enable and Luci

2011-11-29 Thread Philip Prindeville
I agree. Having the same option represented 2 different ways can break a lot of stuff... and it's just confusing. Why exactly did it need to be changed? Not sure I understand where this came from... On 11/29/11 4:17 PM, Sven Roederer wrote: > Hi, > > in r29355 a patch was made to accept the

[OpenWrt-Devel] Changeset 29355 - OpenVPN option enable and Luci

2011-11-29 Thread Sven Roederer
Hi, in r29355 a patch was made to accept the "option enable" and "option enabled" in config-file. Since r29167 the "option enable" was renamed to "option enabled". This change caused luci-app-openvpn to not show up the correct state (see ticket #10473). I think it's not the smartest way to hav