Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

Hi, On Sun, Sep 1, 2019 at 1:52 PM Russell Senior wrote: > > "Jonas" == Jonas Gorski writes: > >> It contains a patch at the end titled: "[PATCH] base-files: pad > >> root.squashfs to 64KiB in ubi volumes" This is another approach that > >> just deals with the UBI+squashfs issue but works

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

On Sun, 1 Sep 2019 at 13:52, Russell Senior wrote: > > > "Jonas" == Jonas Gorski writes: > > >> It contains a patch at the end titled: "[PATCH] base-files: pad > >> root.squashfs to 64KiB in ubi volumes" This is another approach that > >> just deals with the UBI+squashfs issue but works with

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

> "Jonas" == Jonas Gorski writes: >> It contains a patch at the end titled: "[PATCH] base-files: pad >> root.squashfs to 64KiB in ubi volumes" This is another approach that >> just deals with the UBI+squashfs issue but works with >> "-nopad". Soo do we all agree there? Jonas> a) 64k

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

On Sat, 31 Aug 2019 at 15:31, Christian Lamparter wrote: > > Hello, > > On Saturday, August 31, 2019 2:09:55 PM CEST Jonas Gorski wrote: > > On Sat, 31 Aug 2019 at 01:19, Christian Lamparter > > wrote: > > > > > > On Friday, August 30, 2019 11:10:54 PM CEST Russell Senior wrote: > > > > >

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

Hello, On Saturday, August 31, 2019 2:09:55 PM CEST Jonas Gorski wrote: > On Sat, 31 Aug 2019 at 01:19, Christian Lamparter wrote: > > > > On Friday, August 30, 2019 11:10:54 PM CEST Russell Senior wrote: > > > > "Christian" == Christian Lamparter writes: > > > > > > Christian> Ok. > > > >

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

Hi, On Sat, 31 Aug 2019 at 01:19, Christian Lamparter wrote: > > On Friday, August 30, 2019 11:10:54 PM CEST Russell Senior wrote: > > > "Christian" == Christian Lamparter writes: > > > > Christian> Ok. > > > > Christian> I did push a patch titled: "build: remove harmful -nopad > >

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

On Friday, August 30, 2019 11:10:54 PM CEST Russell Senior wrote: > > "Christian" == Christian Lamparter writes: > > Christian> Ok. > > Christian> I did push a patch titled: "build: remove harmful -nopad > Christian> option from mksquashfs" > Christian> >

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

> "Christian" == Christian Lamparter writes: Christian> Ok. Christian> I did push a patch titled: "build: remove harmful -nopad Christian> option from mksquashfs" Christian> Christian> so,

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

On Thursday, August 29, 2019 1:55:25 PM CEST Russell Senior wrote: > > >> Fwiw, I took a little closer look at the squashfs code. I still don't > >> quite understand it, but I sprinkled some printk()'s and got a better > >> idea of what is happening. > >> > >> With a root.squashfs of 6428672

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

>> Fwiw, I took a little closer look at the squashfs code. I still don't >> quite understand it, but I sprinkled some printk()'s and got a better >> idea of what is happening. >> >> With a root.squashfs of 6428672 bytes, we get the error in a call: > > Actually, the 6428672 bytes was from a

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

> Fwiw, I took a little closer look at the squashfs code. I still don't > quite understand it, but I sprinkled some printk()'s and got a better > idea of what is happening. > > With a root.squashfs of 6428672 bytes, we get the error in a call: Actually, the 6428672 bytes was from a later

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

Fwiw, I took a little closer look at the squashfs code. I still don't quite understand it, but I sprinkled some printk()'s and got a better idea of what is happening. With a root.squashfs of 6428672 bytes, we get the error in a call:

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

trimming a bit for easier reading ... > [Fixed Mathias Email] > > > [...] > > > OpenWrt's mksquashfs for the rootfs (which is usually > > > squashfs) is instructed to skip the padding via the nopad > > > option because the rootfs will be padded by functions like > > > pad-rootfs to the

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

[Fixed Mathias Email] On Sunday, August 25, 2019 8:16:48 AM CEST Russell Senior wrote: > > On Saturday, August 24, 2019 2:18:55 AM CEST Russell Senior wrote: > > > > What's happening here is that mksquashfs4 is being told > > > > through the "-nopad" option to "do not pad filesystem to a > > > >

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

Some comments inline below ... > On Saturday, August 24, 2019 2:18:55 AM CEST Russell Senior wrote: > > > "Christian" == Christian Lamparter writes: > > > > > I've posted a similar message to the bugreport: > > > > > > > I should

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

On Saturday, August 24, 2019 2:18:55 AM CEST Russell Senior wrote: > > "Christian" == Christian Lamparter writes: > > > I've posted a similar message to the bugreport: > > > > I should have filed the bug first and linked it in my

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

> "Russell" == Russell Senior writes: > "Christian" == Christian Lamparter writes: Russell> It's mostly inferred from the fact that I saw the error and Russell> kernel panic, and glancing at the kernel squashfs code. I am Russell> not pretending to understand completely how the

Re: [OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

> "Christian" == Christian Lamparter writes: > I've posted a similar message to the bugreport: > I should have filed the bug first and linked it in my patch. > What's happening here is that mksquashfs4 is being told > through the

[OpenWrt-Devel] Squashfs breakage lottery with UBI WAS: [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

On Thursday, August 22, 2019 1:00:21 PM CEST Russell Senior wrote: > > Using pad-squashfs ensures that the root.squashfs is assigned sufficient > LEBs on UBI such that all reads of the rootfs succeed, in order to avoid > read failures and kernel panics. > > This fixes one such kernel panic