Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread Philip Prindeville
On 2/15/11 1:20 PM, Felix Fietkau wrote: On 2011-02-15 10:11 PM, Philip Prindeville wrote: On 2/15/11 12:18 PM, Felix Fietkau wrote: On 2011-02-15 8:09 PM, Philip Prindeville wrote: On 2/15/11 2:13 AM, Ferenc Wagner wrote: Peter Wagnerwrites: - [ -n "$leasefile" ]&&[ -e "$leas

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread Felix Fietkau
On 2011-02-15 10:11 PM, Philip Prindeville wrote: > On 2/15/11 12:18 PM, Felix Fietkau wrote: >> On 2011-02-15 8:09 PM, Philip Prindeville wrote: >>> On 2/15/11 2:13 AM, Ferenc Wagner wrote: Peter Wagner writes: > - [ -n "$leasefile" ]&& [ -e "$leasefile" ] || touch "$leasef

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread Philip Prindeville
On 2/15/11 12:18 PM, Felix Fietkau wrote: On 2011-02-15 8:09 PM, Philip Prindeville wrote: On 2/15/11 2:13 AM, Ferenc Wagner wrote: Peter Wagner writes: - [ -n "$leasefile" ]&& [ -e "$leasefile" ] || touch "$leasefile" + [ -n "$leasefile" ]&& ( [ -e "$leasefile" ] || touch "

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread Felix Fietkau
On 2011-02-15 8:09 PM, Philip Prindeville wrote: > On 2/15/11 2:13 AM, Ferenc Wagner wrote: >> Peter Wagner writes: >> >>> - [ -n "$leasefile" ]&& [ -e "$leasefile" ] || touch "$leasefile" >>> + [ -n "$leasefile" ]&& ( [ -e "$leasefile" ] || touch "$leasefile" ) >> Looks like this is

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread Peter Wagner
Another version of the patch was allready commited - look here https://dev.openwrt.org/changeset/25540 Am Dienstag, 15. Februar 2011, 20:09:44 schrieb Philip Prindeville: > On 2/15/11 2:13 AM, Ferenc Wagner wrote: > > Peter Wagner writes: > >> - [ -n "$leasefile" ]&& [ -e "$leasefile" ] |

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread Philip Prindeville
On 2/15/11 2:13 AM, Ferenc Wagner wrote: Peter Wagner writes: - [ -n "$leasefile" ]&& [ -e "$leasefile" ] || touch "$leasefile" + [ -n "$leasefile" ]&& ( [ -e "$leasefile" ] || touch "$leasefile" ) Looks like this is fixed already by commit 15fba44a (but see point 6 of http://my

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread edgar . soldin
i see to reflect the date change the file is copied to jffs.. makes sense, so the touch alone is more expensive due to the nature of the overlaying fs :) .. thanks ede On 15.02.2011 12:50, Peter Wagner wrote: > no its not about what is more expensive but someone in the development > channel >

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread Peter Wagner
no its not about what is more expensive but someone in the development channel ment, that a touch on a squashfs with jffs overlay will create a new file on the jffs overlay even when the file existed on the squashfs partition... Am Dienstag, 15. Februar 2011, 11:20:47 schrieb edgar.sol...@web.de

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread edgar . soldin
On 15.02.2011 11:13, Ferenc Wagner wrote: > Peter Wagner writes: > >> - [ -n "$leasefile" ] && [ -e "$leasefile" ] || touch "$leasefile" >> + [ -n "$leasefile" ] && ( [ -e "$leasefile" ] || touch "$leasefile" ) > > Looks like this is fixed already by commit 15fba44a (but see point 6

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-15 Thread Ferenc Wagner
Peter Wagner writes: > - [ -n "$leasefile" ] && [ -e "$leasefile" ] || touch "$leasefile" > + [ -n "$leasefile" ] && ( [ -e "$leasefile" ] || touch "$leasefile" ) Looks like this is fixed already by commit 15fba44a (but see point 6 of http://mywiki.wooledge.org/BashPitfalls and the r

Re: [OpenWrt-Devel] dnsmasq leasefile fix

2011-02-14 Thread Peter Wagner
updated patch - increase PKG_RELEASE too Am Montag, 14. Februar 2011, 20:14:58 schrieben Sie: > hi > > when i start dnsmasq i get this error > > /etc/init.d/dnsmasq start > touch: : No such file or directory > > because i didnt define leasefile in the config file ... > > this shouldnt happen a

[OpenWrt-Devel] dnsmasq leasefile fix

2011-02-14 Thread Peter Wagner
hi when i start dnsmasq i get this error /etc/init.d/dnsmasq start touch: : No such file or directory because i didnt define leasefile in the config file ... this shouldnt happen as the statement is [ -n "$leasefile" ] && [ -e "$leasefile" ] || touch "$leasefile" if $leasefile="" it will exe