Re: [OpenWrt-Devel] fstools / always fires 'uci commit' each reboot

2015-01-29 Thread Peter Lawler
On 30/01/15 06:23, Bastian Bittorf wrote: > * Lars Kruse [29.01.2015 20:06]: >> or even better (this does not hide errors in "block detect"): >> [ -f /etc/config/fstab ] || block detect > /etc/config/fstab >> >> (I do not see the need for the subshell here - thus I removed the brackets) > > than

Re: [OpenWrt-Devel] fstools / always fires 'uci commit' each reboot

2015-01-29 Thread Bastian Bittorf
* Lars Kruse [29.01.2015 20:06]: > or even better (this does not hide errors in "block detect"): > [ -f /etc/config/fstab ] || block detect > /etc/config/fstab > > (I do not see the need for the subshell here - thus I removed the brackets) thanks to jow, there was a hotfix with r44180 for this:

Re: [OpenWrt-Devel] fstools / always fires 'uci commit' each reboot

2015-01-28 Thread Lars Kruse
Hi, > [..] > 1) > can we change that behaviour for this single script? > (delete it during first run). I guess, that script's execution should be considered successful, even if /etc/config/fstab already exists. Thus the author just failed to make sure that the exit code of that script reflects th

[OpenWrt-Devel] fstools / always fires 'uci commit' each reboot

2015-01-28 Thread Bastian Bittorf
we detected a strange problem in our community-network, which can be tracked down to 'package/system/fstools/files/fstab.default' which is later installed to '/etc/uci-defaults/10-fstab' including this: [ ! -f /etc/config/fstab ] && ( block detect > /etc/config/fstab ) in our routers there is alw