Re: [OpenWrt-Devel] procd: patch v3 to support busybox mkfs.ext2

2016-07-02 Thread John Crispin
Hi, few comments 1) the patch needs to be split into 2, ext2 change/lzo change 2) send them inline please and not as attachement 3) the V3 needs to be in the subject prefix [PATCH V3] procd: ... 4) the Signed-off-by: line is missing John On 03/07/2016 08:14, Luke McKee wrote: > To quote

Re: [OpenWrt-Devel] procd: patch v3 to support busybox mkfs.ext2

2016-07-02 Thread Luke McKee
To quote Arjen: If the only reason to switch to ext2 is to remove the journal, why not just add -O ^has_journal to the mount options? That's not a mount option. That's a tune2fs option. Journaling isn't the the only problem. The biggest problem is BLOAT. You need libext2+e2fsprogs in