Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-26 Thread Rosen Penev
On Sun, Sep 26, 2021 at 11:31 AM Rui Salvaterra wrote: > > Hi, David, > > On Sun, 26 Sept 2021 at 12:37, David Bauer wrote: > > > > Does this mean parts of this patch are already applied upstream? > > Yes, the ag71xx_ring section. > > > Also are there already performance numbers available? > >

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-26 Thread Rui Salvaterra
Hi, David, On Sun, 26 Sept 2021 at 12:37, David Bauer wrote: > > Does this mean parts of this patch are already applied upstream? Yes, the ag71xx_ring section. > Also are there already performance numbers available? Rosen has performance numbers comparing ar71xx to ath79 DSA including this

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-26 Thread David Bauer
Hi Rui, Hi Rosen, On 9/19/21 12:38, Rui Salvaterra wrote: The ag71xx_ring changes are already part of the upstream driver. However, since we're not using it at all yet, let's apply this to our driver for the time being, as David explicitly requests performance numbers before applying it

RE: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-25 Thread Adrian Schmutzler
[PATCH] ath79/ag71xx: rearrange ag71xx structs to remove > holes > > Hi, Adrian, > > On Fri, 24 Sept 2021 at 22:28, Adrian Schmutzler > wrote: > > > > Commit title prefix should be "ath79: ag71xx:" or just "ath79:". > > To be honest, it

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-25 Thread Rui Salvaterra
Hi, Adrian, On Fri, 24 Sept 2021 at 22:28, Adrian Schmutzler wrote: > > Commit title prefix should be "ath79: ag71xx:" or just "ath79:". To be honest, it makes more sense to me to have " ath79/ag71xx:", as it conveys the same information requiring one character less (and this format has often

RE: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-24 Thread Adrian Schmutzler
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Rui Salvaterra > Sent: Sonntag, 19. September 2021 12:39 > To: openwrt-devel@lists.openwrt.org > Cc: ros...@gmail.com; Rui Salvaterra > Subject: [PATCH] at

[PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-19 Thread Rui Salvaterra
From: Rosen Penev Remove cacheline_aligned attribute to ring structs. This actually causes holes in the ag71xx struct as well as lower performance. Rearrange struct members to fall within respective cachelines. The RX ring struct now does not share a cacheline with the TX ring. The NAPI