[PATCH] fw4: fix ipset comment field from bool to string

comment is documented as a string in the man page. Ref: https://github.com/openwrt/luci/pull/6187#issuecomment-1374506633 Signed-off-by: Paul Dee --- root/usr/share/ucode/fw4.uc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/root/usr/share/ucode/fw4.uc b/root/usr/share/ucod

Re: [PATCH] fw4: fix ipset comment field from bool to string

Any takers? ping jo wich? On 2023-01-07 17:00, Paul D wrote: comment is documented as a string in the man page. Ref: https://github.com/openwrt/luci/pull/6187#issuecomment-1374506633 Signed-off-by: Paul Dee ---  root/usr/share/ucode/fw4.uc | 2 +-  1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH] fw4: fix ipset comment field from bool to string

Hi, the patch was whitespace mangled and didn't apply. After fixing it up manually, the Signed-off-by didn't match the author. Also the fixed option wasn't use anywhere so the fix was rather incomplete (or not useful by itself). It is superseded by https://git.openwrt.org/39e8c70 now. Regards, J