Re: [PATCH] netifd: system-linux: add dev_type info for ubus network.device status

2022-01-11 Thread Philip Prindeville
> On Dec 7, 2021, at 5:26 AM, Jo-Philipp Wich wrote: > > Hi, > >> I have now taken a look at your suggestion. >> Unfortunately, I found that not all network interfaces have set the DEVTYPE >> attribute set in their uevent file. I have not yet found any information >> who sets this value.

Re: [PATCH] netifd: system-linux: add dev_type info for ubus network.device status

2022-01-11 Thread Philip Prindeville
This is probably after the fact, but... > On Dec 6, 2021, at 3:15 AM, Florian Eckert wrote: > > Every network device has a type. This is stored in the sysfs under > '/sys/class/net//type' as a number and can be queried. > > This commit adds this information as a string to the ubus. > 'ubus

Re: [PATCH] netifd: system-linux: add dev_type info for ubus network.device status

2021-12-07 Thread Jo-Philipp Wich
Hi, > I have now taken a look at your suggestion. > Unfortunately, I found that not all network interfaces have set the DEVTYPE > attribute set in their uevent file. I have not yet found any information > who sets this value. Does this do the driver or the subsystem? afair it is set by the

Re: [PATCH] netifd: system-linux: add dev_type info for ubus network.device status

2021-12-07 Thread Florian Eckert
Hello Jo imho these types are not that useful in practice (e.g. tap devices etc. are all reported as "ethernet". Maybe expose /sys/class/net/$devname/uevent DEVTYP= instead. I have now taken a look at your suggestion. Unfortunately, I found that not all network interfaces have set the

Re: [PATCH] netifd: system-linux: add dev_type info for ubus network.device status

2021-12-06 Thread Jo-Philipp Wich
Hi, imho these types are not that useful in practice (e.g. tap devices etc. are all reported as "ethernet". Maybe expose /sys/class/net/$devname/uevent DEVTYP= instead. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel

[PATCH] netifd: system-linux: add dev_type info for ubus network.device status

2021-12-06 Thread Florian Eckert
Every network device has a type. This is stored in the sysfs under '/sys/class/net//type' as a number and can be queried. This commit adds this information as a string to the ubus. 'ubus call network.device status' { ... "eth0": { "dev_type": "ETHER", ... } Signed-off-by: