Re: [PATCH] treewide: remove execute bit and shebang from board.d files

2021-02-26 Thread Ye Holmes
On Fri, 26 Feb 2021 14:52:07 +0100, Adrian Schmutzler wrote: > Can somebody enlighten me what we achieve with the $() enclosing > the sourcing command? Compared to the results a moment ago, $(. XXX) does try to evaluate output from XXX script: root@OpenWrt:/# cat /tmp/source.sh #!/bin/sh $(. /tmp

Re: [PATCH] treewide: remove execute bit and shebang from board.d files

2021-02-26 Thread Ye Holmes
Very interesting indeed. I find the mailing-list is really good place where developers can learn a variety of stuff. I tested the two scripts with bash, the results are effectively the same. It seems that $(. XXX) does try to evaluate the output from XXX, but does not do it very well. --- root@Ope

[PATCH] treewide: remove execute bit and shebang from board.d files

2021-02-26 Thread Adrian Schmutzler
So far, board.d files were having execute bit set and contained a shebang. However, they are just sourced in board_detect, with an apparantly unnecessary check for execute permission beforehand. Replace this check by one for existance and make the board.d files "normal" files, as would be expected