Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-12 Thread Birger Koblitz
Hi, On 12.12.21 20:51, Sander Vanheule wrote: > Hi Sebastian, > > On Sun, 2021-12-12 at 12:38 +0100, Sebastian Gottschall wrote: >> >>> I have not experienced a single lock-up when booting with this patch, but I >>> also >>> didn't >>> stress-test the machine or even used the switch part. Do you

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-12 Thread Sander Vanheule
Hi Sebastian, On Sun, 2021-12-12 at 12:38 +0100, Sebastian Gottschall wrote: > > > I have not experienced a single lock-up when booting with this patch, but I > > also > > didn't > > stress-test the machine or even used the switch part. Do you guys have more > > details on > > why > > it locks

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-12 Thread Sebastian Gottschall
I have not experienced a single lock-up when booting with this patch, but I also didn't stress-test the machine or even used the switch part. Do you guys have more details on why it locks up, or how exactly these lock-ups can be resolved? so far we found out it was related to the ethernet dri

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-12 Thread Sander Vanheule
Hi Sebastian, On Sun, 2021-12-12 at 00:40 +0100, Sebastian Gottschall wrote: > > > I've provided a patch below that enables VPE support for RTL839x. Since > > RTL930x uses > > the > > same CPU architecture, I expect it to also bring up both threads there. > > Like you note > > RTL930x requires

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-11 Thread Sebastian Gottschall
I've provided a patch below that enables VPE support for RTL839x. Since RTL930x uses the same CPU architecture, I expect it to also bring up both threads there. Like you note RTL930x requires a specific clocksource driver, but it should be possible to run your current code for that on top of

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-11 Thread Sander Vanheule
Hi Birger, On Fri, 2021-12-10 at 13:30 +0100, Birger Koblitz wrote: > Hi, > > On 09.12.21 22:26, Sander Vanheule wrote: > > This patch series is intended to reduce the maintenance burden, without > > introducing > > breaking changes to devices already in OpenWrt. No promises are made for > > ou

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-10 Thread Birger Koblitz
Hi, On 09.12.21 22:26, Sander Vanheule wrote: > This patch series is intended to reduce the maintenance burden, without > introducing > breaking changes to devices already in OpenWrt. No promises are made for > out-of-tree code. This patch will unfortunately considerably increase the maintenance

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-09 Thread Sander Vanheule
Hi Birger, On Thu, 2021-12-09 at 13:26 +0100, Birger Koblitz wrote: > Hi, > > thanks for the quick reply. Thank you for the input! > On 09.12.21 10:38, Sander Vanheule wrote: > > Hi Birger, > > > > > > > > I would suggest to use sub-targets for these platforms with optimized > > > compiler se

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-09 Thread Birger Koblitz
Hi, thanks for the quick reply. On 09.12.21 10:38, Sander Vanheule wrote: > Hi Birger, > >> >> I would suggest to use sub-targets for these platforms with optimized >> compiler settings and SMP/single processor selected correctly for each, >> see https://github.com/BrainSlayer/pie/commits/pie-5.

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-09 Thread Sander Vanheule
Hi Birger, On Thu, 2021-12-09 at 08:19 +0100, Birger Koblitz wrote: > Hi Sander and Hiroshi, > > great work! A very big step to clean up this platform. Because this changes > the fundamentals of the target I have some suggestions and questions. Thanks! I was expecting some comments from you :-)

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-09 Thread Bjørn Mork
Sander Vanheule writes: > To reduce the maintenance burden of the realtek target in OpenWrt, Hiroshi and > I have worked on these patches to switch to the upstream platform. Some > downstream code is maintained, primarily for compatibility with the current > downstream-only networking drivers. Th

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-08 Thread Birger Koblitz
Hi Sander and Hiroshi, great work! A very big step to clean up this platform. Because this changes the fundamentals of the target I have some suggestions and questions. There are actually 4 RTL platforms which we now know how to support and you are taking care of the first 3 in your patch to make

[PATCH 00/13] Switch realtek target to upstream platform

2021-12-08 Thread Sander Vanheule
To reduce the maintenance burden of the realtek target in OpenWrt, Hiroshi and I have worked on these patches to switch to the upstream platform. Some downstream code is maintained, primarily for compatibility with the current downstream-only networking drivers. There should be no functional change