Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-23 Thread Jo-Philipp Wich
Hi, > I mean I know they are gigantic corner case where you can build an entire > house in the corner... But what are the drawbacks of such small fix? The > NULL check one for example seems pretty important... Adding that null check there seems redundant, any code path that could lead to blob_n

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Christian Marangi
On Sun, Jul 17, 2022 at 01:48:41AM +0200, Ansuel Smith wrote: > Hi, > some background about this. > > I'm trying to improve our CI system more and more by finally adding > support for real > EXTERNAL_TOOLCHAIN_SUPPORT... I'm running (and abusing) the github CI > to make sure everything works and a

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Christian Marangi
On Sun, Jul 17, 2022 at 02:54:24AM -0700, Rosen Penev wrote: > On Sun, Jul 17, 2022 at 2:29 AM Christian Marangi > wrote: > > > > On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > > > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > > > > > Hi, > > > > some background abo

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Christian Marangi
On Sun, Jul 17, 2022 at 02:50:36AM -0700, Rosen Penev wrote: > On Sun, Jul 17, 2022 at 2:29 AM Christian Marangi > wrote: > > > > On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > > > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > > > > > Hi, > > > > some background abo

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Rosen Penev
On Sun, Jul 17, 2022 at 2:29 AM Christian Marangi wrote: > > On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > > > Hi, > > > some background about this. > > > > > > I'm trying to improve our CI system more and more by fina

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Rosen Penev
On Sun, Jul 17, 2022 at 2:29 AM Christian Marangi wrote: > > On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > > > Hi, > > > some background about this. > > > > > > I'm trying to improve our CI system more and more by fina

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Christian Marangi
On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > Hi, > > some background about this. > > > > I'm trying to improve our CI system more and more by finally adding > > support for real > > EXTERNAL_TOOLCHAIN_SUPPORT... I'm runn

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-16 Thread Rosen Penev
On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > Hi, > some background about this. > > I'm trying to improve our CI system more and more by finally adding > support for real > EXTERNAL_TOOLCHAIN_SUPPORT... I'm running (and abusing) the github CI > to make sure everything works and all compi

Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-16 Thread Ansuel Smith
Hi, some background about this. I'm trying to improve our CI system more and more by finally adding support for real EXTERNAL_TOOLCHAIN_SUPPORT... I'm running (and abusing) the github CI to make sure everything works and all compiles correctly... While testing it I notice a specific target fails