Re: OpenWrt One / project update

2024-04-11 Thread Felix Fietkau
On 11.04.24 10:15, Ivan Ivanov wrote: SOC: MediaTek MT7981B , Wi-Fi: MediaTek MT7976C Are these Mediateks capable of working without any binary blobs, at least in theory? (i.e. some existent reverse-engineering research) If not, why have they been chosen in particular? IMHO the "OpenWRT One"

Re: hostapd size issue

2024-04-05 Thread Felix Fietkau
On 05.04.24 05:12, e9hack wrote: Hi, I face a strange issue about the size of hostapd. If I build hostapd-openssl only, the size of the hostapd binary is 1061680 bytes. If I add wpad-openssl as module in addition, the size of hostapd is 798664 bytes only. The dependencies in hostapd's

Re: xz inadequate for a long term tarball reproducibility? [Was: [openwrt/openwrt] unetd: fix PKG_MIRROR_HASH]

2024-04-03 Thread Felix Fietkau
On 03.04.24 15:41, Petr Štetiar wrote: LEDE Commits [2024-04-03 07:29:21]: Hi, thanks a lot for a great commit message, really appreciate it! :-) Just to get a complete picture, I've additional questions, sorry. nbd pushed a commit to openwrt/openwrt.git, branch main:

Re: Conclusions from CVE-2024-3094 (libxz disaster)

2024-03-31 Thread Felix Fietkau
On 31.03.24 01:07, Elliott Mitchell wrote: On Sat, Mar 30, 2024 at 03:30:49PM +, Daniel Golle wrote: unchanged. Git has a lot of security built-in, and by using tarballs as a base for our package builds we are basically throwing all that away, for the sake of saving a negligible amount of

Re: here we are again: real name 'discussion'

2024-03-26 Thread Felix Fietkau
On 26.03.24 14:39, Paul D wrote: We have quorum/consensus on this issue. Is it too much to ask that everyone now follow it, or at least have this token 'vote'? Where did you see the quorum/consensus? I looked at the links and couldn't find it. Triggered by the yggdrasil additions of

Re: Question to recent Qualcomm CVEs

2024-02-26 Thread Felix Fietkau
On 26.02.24 11:45, Tanjeff Moos wrote: Hi all, Qualcomm has bugs in the closed-source firmware for their WLAN and LTE hardware. The Qualcomm bulletin[1] says "Patches are being actively shared with OEMs". Were these bugfixes made available for OpenWRT? Is there an established procedure for

Re: [VOTE] New member proposal: Robimarko (Robert Marko)

2024-01-31 Thread Felix Fietkau
On 30.01.24 19:15, Christian Marangi (Ansuel) wrote: Robert is active in OpenWrt since 2017 and with some recent stats, he has more than 310 commits merged in OpenWrt. He also have uncounted Reviewed-by tag on various PR and merged commits and generally helps in everything related to IPQ

Re: realtek/rtl838x: regression in f909059b74 caused by procd segfault in libubox

2024-01-26 Thread Felix Fietkau
On 26.01.24 20:15, Dustin Howett wrote: I am seeing this on x86/64-glibc as well. It looks like procd is falling over in udebug_entry_vprintf at the *second* vprintf after udebug_buf_alloc. This appears to occur when there are log messages longer than the minimum allocation size (128) and we

Future of the broadcom-wl package?

2024-01-26 Thread Felix Fietkau
Hi, does anybody still care about the broadcom-wl package in OpenWrt? I think it would be nice if we could get rid of it, along with the code support and abstraction for different wireless drivers. It would also allow us to rewrite iwinfo in ucode with nl80211 as the only supported API, which

Re: Radios for LibreRouter 2

2024-01-23 Thread Felix Fietkau
Hi, On 23.01.24 10:54, G10h4ck wrote: Hi all! At Altermundi we have been (mostly silently) advancing with LibreRouter 2 project, we have now some prototype at hand and started testing also radios, we need that the radio works good with OpenWrt and that at least have good 802.11s support in the

Re: hostapd crash

2024-01-13 Thread Felix Fietkau
On 13.01.24 16:58, e9hack wrote: Am 13.01.2024 um 16:47 schrieb Felix Fietkau: On 13.01.24 16:32, e9hack wrote: Thanks, this does fix the exception. Now I see the reale error: Sat Jan 13 15:52:30 2024 daemon.err hostapd: Could not set interface phy1-ap8 flags (UP): Resource busy Sat Jan 13

Re: hostapd crash

2024-01-13 Thread Felix Fietkau
On 13.01.24 16:32, e9hack wrote: Thanks, this does fix the exception. Now I see the reale error: Sat Jan 13 15:52:30 2024 daemon.err hostapd: Could not set interface phy1-ap8 flags (UP): Resource busy Sat Jan 13 15:52:31 2024 daemon.err hostapd: Failed to add BSS (BSSID=xx:xx:xx:xx:xx:xx) Sat

Re: hostapd crash

2024-01-13 Thread Felix Fietkau
Hi, On 13.01.24 11:28, e9hack wrote: Hi, I did add one more AP to my wifi config for testing. This results in hostapd not starting for this device: Thu Jan 11 13:59:12 2024 daemon.notice hostapd: Exception in ubus function: left-hand side expression is null In __iface_pending_next(), file

Re: libubox compile issue

2023-11-28 Thread Felix Fietkau
On 28.11.23 17:00, e9hack wrote: Hi, since commit 'libubox: update to Git HEAD (2023-11-27)', I've trouble to compile libubox: [43/46] Building C object CMakeFiles/jshn.dir/jshn.c.o [44/46] Linking C executable jshn FAILED: jshn : && /data/src/LEDE/RT-AX53U-5.15.x/staging_dir/host/bin/gcc -O2

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-11-24 Thread Felix Fietkau
On 25.11.23 03:28, Elliott Mitchell wrote: On Fri, Nov 24, 2023 at 01:53:01PM +0100, Jonas Gorski wrote: > > I'm fine with the cp -l change, but I think adding all remaining modules > > to the rootfs is not something we should do by default (maybe opt-in?) > > Perhaps. This could also be

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-11-17 Thread Felix Fietkau
On 17.11.23 22:31, Elliott Mitchell wrote: On Fri, Nov 17, 2023 at 05:20:33PM +0100, Felix Fietkau wrote: On 11.11.23 01:21, Elliott Mitchell wrote: > This removes the requirement for to create a package for all modules. > Now devices can simply specify in-tree drivers/other to be

Re: [PATCH 07/20] kernel: copy all built kernel modules to root filesystem image

2023-11-17 Thread Felix Fietkau
On 11.11.23 01:21, Elliott Mitchell wrote: This removes the requirement for to create a package for all modules. Now devices can simply specify in-tree drivers/other to be built as modules and they will be present in the resultant image. Signed-off-by: Elliott Mitchell It seems to me that

Re: netifd issue

2023-11-10 Thread Felix Fietkau
On 10.11.23 15:21, e9hack wrote: Too fast. I did reboot with the old version again. The patched version does work. Fix pushed, thanks for testing! - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: netifd issue

2023-11-10 Thread Felix Fietkau
On 10.11.23 13:59, Felix Fietkau wrote: On 09.11.23 22:31, Hannu Nyman wrote: e9hack kirjoitti 9.11.2023 klo 17.32: I face a strange behaviour since commit 516ab774cc16d4b04b3b17a067cbf2649f1adaeb (system-linux: fix race condition on bringing up wireless devices). After a reboot or a full

Re: netifd issue

2023-11-10 Thread Felix Fietkau
On 09.11.23 22:31, Hannu Nyman wrote: e9hack kirjoitti 9.11.2023 klo 17.32: I face a strange behaviour since commit 516ab774cc16d4b04b3b17a067cbf2649f1adaeb (system-linux: fix race condition on bringing up wireless devices). After a reboot or a full restart of hostapd via 'wifi down; sleep

Re: wpa_supplicant and switch to ucode

2023-09-21 Thread Felix Fietkau
On 21.09.23 20:00, André Valentin wrote: Hi! I just tested the current 23.05rc tree with the new hostapd patches and noticed that 802.1x on wired interfaces does now work anymore. Until now it was really easy to use the running wpa_supplicant with that, i just added a config with: ubus

[PATCH/RFT 23.05 4/4] netifd: update to the latest version

2023-08-30 Thread Felix Fietkau
netifd: fix disabling radio via config if reconf is being used Signed-off-by: Felix Fietkau (cherry picked from commit 09fd59938b673ca10d4b3c46d32f18164bcdb21a) --- package/network/config/netifd/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/network/config

[PATCH/RFT 23.05 1/4] ucode: update to the latest version

2023-08-30 Thread Felix Fietkau
ftypes c7d84aae0969 Merge pull request #153 from jow-/lib-sort-object-support Signed-off-by: Felix Fietkau (cherry picked from commit 9419a50242f81b73bae2b1105c0e370385682ad1) --- package/utils/ucode/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/utils

[PATCH/RFT 23.05 2/4] ubus: update to the latest version

2023-08-30 Thread Felix Fietkau
f787c97b3489 libubus: add missing uloop_fd_delete call in ubus_shutdown Signed-off-by: Felix Fietkau (cherry picked from commit fdadfb633f8906478974aefbbc84fee1bf508e2f) --- package/system/ubus/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/system

Re: Hostapd won't build after rebase yesterday

2023-08-11 Thread Felix Fietkau
On 11.08.23 17:58, Philip Prindeville wrote: I'm seeing the following breakage in hostapd: ../src/ap/ucode.c: In function 'uc_hostapd_iface_start': ../src/ap/ucode.c:337:23: error: 'struct hostapd_config' has no member named 'he_oper_centr_freq_seg0_idx'; did you mean

Re: trouble with hostapd

2023-08-07 Thread Felix Fietkau
On 06.08.23 17:29, e9hack wrote: Am 04.08.2023 um 13:01 schrieb Felix Fietkau: Can you please build hostapd with CONFIG_WPA_MSG_MIN_PRIORITY=0 in the OpenWrt .config, add -d to the hostapd command in /etc/init.d/wpad Afterwards, please show me the relevant log part with the full context

Re: trouble with hostapd

2023-08-04 Thread Felix Fietkau
On 03.08.23 20:17, e9hack wrote: Am 03.08.2023 um 18:51 schrieb Felix Fietkau: On 03.08.23 15:34, e9hack wrote: Am 03.08.2023 um 14:35 schrieb Felix Fietkau: thanks for reporting this. Unfortunately I can't reproduce it myself based on your description. Can you please let me know what device

Re: trouble with hostapd

2023-08-03 Thread Felix Fietkau
On 03.08.23 15:34, e9hack wrote: Am 03.08.2023 um 14:35 schrieb Felix Fietkau: thanks for reporting this. Unfortunately I can't reproduce it myself based on your description. Can you please let me know what device you are using, and send me the config that reproduces this issue? I'm using

Re: trouble with hostapd

2023-08-03 Thread Felix Fietkau
Hi, On 03.08.23 11:17, e9hack wrote: I've trouble with 5GHz since the last changes related to hostapd. After boot or after a sequence 'wifi down; sleep 30; wifi' the 2GHz starts only. The 5GHz doesn't start. It looks like, that ACS isn't started. If I modify a value in the config related to

Re: kernel-headers: platform/target patches are not applied

2023-07-27 Thread Felix Fietkau
Hi Martin, On 27.07.23 13:23, Martin Schiller wrote: When preparing the kernel sources to build the kernel headers, currently only the patches from the generic folder are applied, but not from the actual selected target. This is basically understandable if one assumes that one wants to use a

Re: [netifd PATCH] bridge: always insert new member if allocated on hotplug add

2023-06-24 Thread Felix Fietkau
On 24.06.23 14:34, Christian Marangi wrote: Fix Coverity Defect 1532481 reporting a Resource leak when !bm->node.avl.key is false in bridge_hotplug_add. While this situation is almost impossible, code can be refactored to mute the defect and make it clear that we insert only when a new member

Re: [PATCH] mac80211: always use mac80211 loss detection

2023-06-23 Thread Felix Fietkau
On 23.06.23 12:29, David Bauer wrote: Hi Felix, On 6/23/23 08:55, Felix Fietkau wrote: On 18.05.23 11:19, David Bauer wrote: ath10k does not report excessive loss in case of broken block-ack sessions. The loss is communicated to the host-os, but ath10k does not trigger a low-ack events

Re: [PATCH] mac80211: always use mac80211 loss detection

2023-06-23 Thread Felix Fietkau
On 18.05.23 11:19, David Bauer wrote: ath10k does not report excessive loss in case of broken block-ack sessions. The loss is communicated to the host-os, but ath10k does not trigger a low-ack events by itself. The mac80211 framework for loss detection however detects this circumstance well in

Re: [PATCH 2/9] kernel: change CONFIG_HW_RANDOM default to y

2023-05-01 Thread Felix Fietkau
On 29.04.23 08:08, Elliott Mitchell wrote: On Fri, Apr 28, 2023 at 10:29:29AM -0600, Philip Prindeville wrote: Why isn't this migrating upwards into target/linux/generic/config-5.15 and target/linux/generic/config-5.10 in that case? And for the platforms where it was turned off, like

Re: [PATCH 0/9] (mostly) x86 kernel configuration adjustments

2023-04-29 Thread Felix Fietkau
On 29.04.23 02:50, Elliott Mitchell wrote: On Thu, Apr 27, 2023 at 05:38:18AM +0200, Stefan Lippers-Hollmann wrote: On 2023-04-26, Elliott Mitchell wrote: > On Thu, Apr 27, 2023 at 01:11:13AM +0200, Stefan Lippers-Hollmann wrote: > > On 2023-04-26, Elliott Mitchell wrote: > > [...] > > > > > >

Re: mt7622: belkin-rt3200: r22602-42eeb22450: Kernel panic: kernel stack overflow

2023-04-21 Thread Felix Fietkau
On 21.04.23 09:11, Petr Štetiar wrote: Hi, I've just noticed, that daily CI runtime testing job on belkin-rt3200 failed[1] due to following: Insufficient stack space to handle exception! ESR: 0x9647 -- DABT (current EL) FAR: 0xffc008c47fe0 Task stack:

Re: OpenWrt Next Generation Ideas

2023-03-31 Thread Felix Fietkau
On 31.03.23 18:55, Arınç ÜNAL wrote: On 31.03.2023 19:45, Felix Fietkau wrote: On 31.03.23 18:40, Arınç ÜNAL wrote: I just thought of this. Why don't we just, for example, 'make mt7621_defconfig && make mod2noconfig', then compile normally with kernel module packages. This way,

Re: OpenWrt Next Generation Ideas

2023-03-31 Thread Felix Fietkau
On 31.03.23 18:40, Arınç ÜNAL wrote: I just thought of this. Why don't we just, for example, 'make mt7621_defconfig && make mod2noconfig', then compile normally with kernel module packages. This way, OpenWrt compiles a kernel with the least amount of kernel modules (or rather, it compiles the

Re: OpenWrt Next Generation Ideas

2023-03-31 Thread Felix Fietkau
On 31.03.23 18:22, Arınç ÜNAL wrote: On 31.03.2023 19:04, Felix Fietkau wrote: On 31.03.23 14:52, Arınç ÜNAL wrote: On 31.03.2023 14:33, Daniel Golle wrote: Hi! On Fri, Mar 31, 2023 at 12:44:12PM +0300, Arınç ÜNAL wrote: Hi all, These are the ideas I've been thinking about for the future

Re: OpenWrt Next Generation Ideas

2023-03-31 Thread Felix Fietkau
On 31.03.23 14:52, Arınç ÜNAL wrote: On 31.03.2023 14:33, Daniel Golle wrote: Hi! On Fri, Mar 31, 2023 at 12:44:12PM +0300, Arınç ÜNAL wrote: Hi all, These are the ideas I've been thinking about for the future of OpenWrt for a while. It looks complete enough to share it with all of you. I'm

Re: [libnl-tiny PATCH] attr: add NLA_S8

2023-03-30 Thread Felix Fietkau
On 30.03.23 11:47, Nick wrote: On 3/30/23 11:43, Nick wrote: On 3/19/23 20:25, Hauke Mehrtens wrote: On 3/15/23 14:37, Nick Hainke wrote: NLA_S8 is used by newer hostapd versions. Signed-off-by: Nick Hainke ---   attr.c |  1 +   include/netlink/attr.h | 35

Re: [PATCH] netifd: exclude 20-smp-packet-steering on bcm53xx

2023-02-02 Thread Felix Fietkau
On 02.02.23 17:06, Rafał Miłecki wrote: From: Rafał Miłecki bcm53xx comes with custom (more optimized) packet steering. A race between two scripts was resulting in varying network performance. Ref: fcbd39689ebf ("bcm53xx: enable & setup packet steering") Signed-off-by: Rafał Miłecki --- Is

Re: [PATCH] x86: use mkfs.fat, sed, mmd and mcopy from staging_dir

2023-01-20 Thread Felix Fietkau
On 20.01.23 12:42, Florian Eckert wrote: Hello Felix, During image generation, the host tools should not be used but the tools from the staging_dir. - mkfs.fat - sed - mmd - mcopy Why is this necessary? $STAGING_DIR_HOST/bin should already be in $PATH before the host system parts. I only

Re: [PATCH] x86: use mkfs.fat, sed, mmd and mcopy from staging_dir

2023-01-20 Thread Felix Fietkau
On 20.01.23 09:36, Florian Eckert wrote: During image generation, the host tools should not be used but the tools from the staging_dir. - mkfs.fat - sed - mmd - mcopy Why is this necessary? $STAGING_DIR_HOST/bin should already be in $PATH before the host system parts. - Felix

Re: backport mac80211

2022-12-13 Thread Felix Fietkau
On 12.12.22 15:24, e9hack wrote: Hi, backports-6.1-rc8 build fails for ath9k due to a missing dependency: Fixed, thanks. I added the dependency to kmod-ath9k-common instead, since that's the module that actually depends on kmod-random-core. - Felix

Re: [RFC] dropping of $(AUTORELEASE) feature

2022-11-13 Thread Felix Fietkau
Hi, I have another idea that might simplify the mess of dealing with PKG_RELEASE handling. 1. we use AUTORELEASE for all packages in master 2. when creating a release branch, all PKG_RELEASE lines are changed to something like 22.03-1 3. we write a script that can automatically edit a series

Re: Bridge-vlan bug? (mt7621/DSA)

2022-08-09 Thread Felix Fietkau
On 09.08.22 15:13, Thibaut wrote: Le 6 août 2022 à 11:58, Thibaut a écrit : Le 6 août 2022 à 00:50, Mark Mentovai a écrit : Thibaut wrote: I’m experiencing a strange bug on Yuncore AX820 (mt7621/mt7905/mt7975, DSA-enabled) when using a bridge-vlan setup. This bug affects at least

Re: [PATCH netifd] interface: support "zone" config option

2022-07-27 Thread Felix Fietkau
On 27.07.22 07:34, Rafał Miłecki wrote: From: Rafał Miłecki Many protocol handlers support "zone" option independently and they pass it in the "data". Then it's read e.g. by a firewall[34]. Add support for "zone" directly to the netifd so: 1. It works for all protocols 2. Handlers don't have

Re: [PATCH] airoha: Add new target platform

2022-07-26 Thread Felix Fietkau
Hi Daniel, On 26.07.22 08:46, Daniel Danzberger wrote: Airoha is a new ARM platform based on Cortex A7 which has recently been merged into linux-next. This support is based mostly on those linux-next commits backported for kernel 5.15. Patches: 1 - platform support = linux-next 2 - clock

Re: Optimizing kernel compilation / alignments for network performance

2022-05-05 Thread Felix Fietkau
On 05.05.22 18:04, Andrew Lunn wrote: you'll see that most used functions are: v7_dma_inv_range __irqentry_text_end l2c210_inv_range v7_dma_clean_range bcma_host_soc_read32 __netif_receive_skb_core arch_cpu_idle l2c210_clean_range fib_table_lookup There is a lot of cache management functions

Re: [PATCH/RFC] kernel-defaults.mk: get rid of BuildID

2022-04-05 Thread Felix Fietkau
On 05.04.22 20:51, Daniel Golle wrote: On Tue, Apr 05, 2022 at 05:05:43PM +0200, Felix Fietkau wrote: On 05.04.22 03:14, Daniel Golle wrote: > When building the Linux kernel, the linker generates a hash of all > versions of tools involved in a build called BuildID in ELF header. > Th

Re: [PATCH/RFC] kernel-defaults.mk: get rid of BuildID

2022-04-05 Thread Felix Fietkau
On 05.04.22 03:14, Daniel Golle wrote: When building the Linux kernel, the linker generates a hash of all versions of tools involved in a build called BuildID in ELF header. This breaks reproducibility accross different buildhosts eventhough OpenWrt builds the toolchain from source -- the

Re: [PATCH] image: let mksquashfs4 use all processors

2022-02-19 Thread Felix Fietkau
On 19.02.22 16:54, Stijn Tintel wrote: Drop the -processors argument from the mksquashfs4 call, so it will use all available processors. This dramatically reduces the time to create squashfs filesystems. The times below are observed when building an image for my main router, the WatchGuard

Re: [PATCH 1/3] kernel: 5.10: recover 88E6060 switches support

2021-12-17 Thread Felix Fietkau
On 2021-12-17 10:13, Sergey Ryazanov wrote: On Fri, Dec 17, 2021 at 11:52 AM Felix Fietkau wrote: On 2021-12-16 23:29, Sergey Ryazanov wrote: Support for mvswich driver (Marvell 88E6060 switches) build has been missed during the initial v5.10 kernel introduction. But it is required

Re: [PATCH 1/3] kernel: 5.10: recover 88E6060 switches support

2021-12-17 Thread Felix Fietkau
with the new kernel. Compile tested only with the ath25 target. Fixes: b10d604459 ("kernel: add linux 5.10 support") CC: Felix Fietkau Signed-off-by: Sergey Ryazanov There is an upstream DSA driver for 88e6060, I think we should try to use that one instead.

Re: Upstreaming hostapd patches 300-noscan.patch and 360-ctrl_iface_reload.patch

2021-12-16 Thread Felix Fietkau
Hi Arnout, On 2021-12-16 18:00, Arnout Vandecappelle wrote:  Since I want to use these features outside of OpenWrt, I'd like to upstream the patches 300-noscan.patch and 360-ctrl_iface_reload.patch to hostap.  First of all, I'd like confirmation from you that it's OK to redistribute those

Re: [PATCH] mediatek: bmt: use generic mtd api

2021-12-04 Thread Felix Fietkau
On 2021-12-04 15:24, Chuanhong Guo wrote: BMT replaces nand-specific ops for erasing and writing, but the mtk-snand driver only implements generic mtd api. Replace erase, block_isbad, block_markbad in mtd_info for generic mtd drivers. Fixes: b600aee3ed ("mediatek: attach bmt to the new snand

Re: zram-swap: default to lzo instead of lzo-rle compression

2021-12-01 Thread Felix Fietkau
On 2021-12-01 00:27, Sven Roederer wrote: Am Montag, 29. November 2021, 10:57:37 CET schrieb Rui Salvaterra: Hi, Sven, On Sun, 28 Nov 2021 at 01:40, Sven Roederer wrote: > Rui, not sure if to call it a bug. At the end there is a hardcoded default > algo in the module, that is used initially

Re: [RFC PATCH] treewide: drop librt and libpthread packages

2021-11-19 Thread Felix Fietkau
On 2021-11-18 12:58, Jo-Philipp Wich wrote: Since OpenWrt's main libc library, musl, does not provide separate shared object files for libpthread and librt, the existing binary packages for them are empty placeholders which provide no runtime functionality and frequently cause confusion among

Re: dnsmasq ubus bug

2021-11-10 Thread Felix Fietkau
Hi, On 2021-11-10 00:16, Hartmut Birr wrote: I've trouble with this commit: dnsmasq: add support for monitoring and modifying dns lookup results via ubus I've two dnsmasq instances configured. After this commit, one instance does crash: Tue Nov 9 23:39:21 2021 daemon.crit dnsmasq[1]:

Re: [PATCH 1/2] interface-ip: copy more info for target host route

2021-10-27 Thread Felix Fietkau
On 2021-10-26 23:59, luizl...@gmail.com wrote: From: Luiz Angelo Daros de Luca interface_ip_add_target_route was adding a host route without copying other confs like type, source, online). The result was that this: unreachable 192.168.0.9 metric 123 was being converted to:

Re: hostapd: ubus inteface crashes hostapd?

2021-10-21 Thread Felix Fietkau
On 2021-10-21 11:31, Nick wrote: Is someone massively utilizing the ubus interface from hostapd? I'm doing this with dawn and I saw that blocktrron already fixed some infinity loop. However, currently DAWN is crashing the hostapd. I make extensive use of the get_clients, all subscriptions,

Re: RFC: toolchain for building eBPF modules within the OpenWrt build system

2021-10-18 Thread Felix Fietkau
On 2021-10-18 15:37, Florian Eckert wrote: I'd suggest to require a preinstalled host toolchain for the time being. How about requiring a preinstalled host toolchain by default, but building it from source on buildbot? I wouldn't make it dependent on whether openwrt compiles on the buildbot

Re: RFC: toolchain for building eBPF modules within the OpenWrt build system

2021-10-17 Thread Felix Fietkau
On 2021-10-04 15:20, Jo-Philipp Wich wrote: Hi Felix, I'd suggest to require a preinstalled host toolchain for the time being. How about requiring a preinstalled host toolchain by default, but building it from source on buildbot? If we rely on the toolchain on the host, the builds might

Re: handling of blob_buf_free?

2021-10-13 Thread Felix Fietkau
On 2021-10-13 11:32, Nick wrote: > Does it make a difference in terms of performance to use stack buffers? > I switched now to using stack buffers, since for me it makes the code > more readable not having to deal with several buffers and possible race > conditions. (but just my view on the

Re: handling of blob_buf_free?

2021-10-13 Thread Felix Fietkau
On 2021-10-13 07:53, Nick wrote: > Since I saw there were some new patches, e.g., procd, fixing > blob_buf_free() calls. > I asked several months ago: "Should you call blob_buf_free() after > calling blob_buf_init()?" >

RFC: toolchain for building eBPF modules within the OpenWrt build system

2021-10-03 Thread Felix Fietkau
Hi, I recently spent some time digging into what's needed for proper eBPF build support in OpenWrt. Here's what I found so far: Most out-of-tree eBPF based projects fork some of the BPF related kernel headers from various different kernel versions and manually maintain those forks. These

Re: kernel: add a bridge feature for filtering BPDU packets on ports

2021-09-28 Thread Felix Fietkau
On 2021-09-28 13:49, Andre Heider wrote: > On 28/09/2021 12:20, Andre Heider wrote: >> fyi brport/proxyarp was still "0" too, which probably means that the >> netidf condition "if (up && ifname != vif->ifname)" doesn't eval to true >> as that's the only spot setting "dev->wireless_proxyarp". >

Re: Wifi bug

2021-09-27 Thread Felix Fietkau
On 2021-09-27 18:30, Hannu Nyman wrote: > Felix Fietkau kirjoitti 27.9.2021 klo 19.17: >> On 2021-09-27 17:45, Hannu Nyman wrote: >>> Felix Fietkau kirjoitti 27.9.2021 klo 13.59: >>>> On a crash, it should drop a .core file to /tmp. Please copy that to >>

Re: Wifi bug

2021-09-27 Thread Felix Fietkau
On 2021-09-27 17:45, Hannu Nyman wrote: > Felix Fietkau kirjoitti 27.9.2021 klo 13.59: >> On a crash, it should drop a .core file to /tmp. Please copy that to >> your build host and use ./scripts/remote-gdb to obtain a backtrace from >> it. I'd like to know, which line of code

Re: Wifi bug

2021-09-27 Thread Felix Fietkau
On 2021-09-27 13:33, e9hack wrote: > Am 27.09.2021 um 12:59 schrieb Felix Fietkau: >> >> Hi, >> >> >> On 2021-09-26 14:48, e9hack wrote: >>> Do you see a page fault from netifd in the log? If it does crash, it is >>> restarted by procd. Thi

Re: Wifi bug

2021-09-27 Thread Felix Fietkau
Hi, On 2021-09-26 14:48, e9hack wrote: > Do you see a page fault from netifd in the log? If it does crash, it is > restarted by procd. This does restart the network stack. If I start netifd > with strace, I got this lines immediately before the page fault: > >

Re: uci: unnecessary write accesses

2021-09-21 Thread Felix Fietkau
On 2021-09-21 13:19, Florian Eckert wrote: > > I have written a small shell script, to track write access to the > '/etc/config' directory. > For this task I am using the inotify-tool package [1]. > I am using the inotifywait tool to add the watchers [2] with a small > shell script and log them

Re: WDS stopped working in 21.02, looking for bug in netifd

2021-09-21 Thread Felix Fietkau
On 2021-09-20 22:56, Daniel Haid wrote: > Felix, I took the last openwrt snapshot and compiled netifd from master > with your patch applied and installed it. > > Result: > After boot wlan0.sta1 was DOWN. > After "/etc/init.d/network restart" it was UP and the connection worked! > After another

Re: WDS stopped working in 21.02, looking for bug in netifd

2021-09-20 Thread Felix Fietkau
On 2021-09-20 16:46, Daniel Haid wrote: > I have continued investigating. > > After all, it seems that the interface being down is just a symptom. > > I summarize my current findings: > > With the 21.02 netifd version, there seems to be a bug concerting WDS. > The bug has the following effect:

Re: Broken ARP broadcast on master (commit 0f688797)

2021-09-06 Thread Felix Fietkau
> On 6. Sep 2021, at 02:03, David Bauer wrote: > > Hi Felix, > > updating my Wireless APs (ath9k+ath10k / mt7603+mt7915) broke ARP broadcast > delivery to clients > connected to the radios with SW rate control. > > Bisecting this problem revealed commit 0f688797 ("mac80211: add missing >

Re: [PATCH] Revert "initd: fix off-by-one error in mkdev.c"

2021-08-31 Thread Felix Fietkau
On 2021-08-31 10:25, vinc...@systemli.org wrote: > From: Nick Hainke > > This reverts commit 8eb1d783cca6e0d501dd3a2f94262ffc36ae6482. > > This line reads a symbolic link into the string buffer "buf". > len = readlink(buf2, buf, sizeof(buf)); > The commit replaced now > buf[len] =

Re: [PATCH] uhttpd: add config option for json_script

2021-08-24 Thread Felix Fietkau
not possible as it would render all other uhttpd > instances unusable. > > Signed-off-by: Stijn Tintel Acked-by: Felix Fietkau ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 21.02] Revert "netifd: update to the latest version"

2021-07-26 Thread Felix Fietkau
On 2021-07-26 17:09, Petr Štetiar wrote: > Petr Štetiar [2021-07-26 17:01:32]: > >> This reverts commit 089efd61e9a6cdc0ea39c184d37bc8ebbe03175c as it >> breaks LAN network on at least mvebu/turris-omnia device. >> >> Confirmed-by: Josef Schlehofer >> Signed-off-by: Petr Štetiar >> --- >> >>

Re: OpenWrt 21.02 status

2021-07-17 Thread Felix Fietkau
On 2021-07-17 17:45, Hauke Mehrtens wrote: > Hi, > > In general the 21.02-rc3 looks good, but we still have some problems. > > Currently we still have these problem: > > - IPv6 broken with flow offloading (according to reports, potentially > related to hw flow offloading) > - PPPoE allegedly

Re: [PATCH] ubus: add a private field to event handlers

2021-07-14 Thread Felix Fietkau
On 2021-07-13 13:57, louis_hamp...@sercomm.com wrote: > > This is particularly useful in multithreaded non-C FFI, where > additional context from where the event handler was registered may be > critical to ensuring the output of the event is sent to the right > location. > > Signed-off-by: Louis

Re: wrong activation of internal radius server

2021-06-04 Thread Felix Fietkau
Hi Hartmut, On 2021-06-04 15:22, e9hack wrote: > OpenWrt has been supporting hostapd's internal radius server for a few days. > For several years there has been a line in the init-script that activates the > internal radius server too. I think this is wrong (from hostapd.sh): > > [ -n

Re: [PATCH V2 netifd] interface: rename "ifname" attribute to "device"

2021-05-25 Thread Felix Fietkau
On 2021-05-24 15:35, Rafał Miłecki wrote: > From: Rafał Miłecki > > Interfaces need to be assigned to devices. For that purpose a "device" > option should be more accurate than "ifname" one. > > For backward compatibility add a temporary config translation. > > Config example: > > config

Re: [PATCH netifd] interface: rename "ifname" attribute to "device"

2021-05-22 Thread Felix Fietkau
On 2021-05-17 16:49, Rafał Miłecki wrote: > From: Rafał Miłecki > > Interfaces need to be assigned to devices. For that purpose a "device" > option should be more accurate than "ifname" one. > > For backward compatibility add a temporary config translation. > > Config example: > > config

Re: netifd: redesigning UCI config & interfaces

2021-05-13 Thread Felix Fietkau
Hi Rafał, Thanks for the proposal On 2021-05-13 15:58, Rafał Miłecki wrote: > Current /etc/config/network design and netifd implementation are quite a > bit messy: > 1. There is no clear layer 2 vs. layer 3 distinction I think aside from a few legacy compatibility hacks (e.g. the infamous

Re: FRAG Attacks (new vuln for wifi)

2021-05-13 Thread Felix Fietkau
On 2021-05-13 11:10, Mirko Parthey wrote: > On Thu, May 13, 2021 at 05:57:01AM +0200, Felix Fietkau wrote: >> >> > Regarding ath10k-ct, what kernel-versions of the ath10k-ct driver need >> >> > to be patched? >> >> > Is 4.19 the oldest that o

Re: FRAG Attacks (new vuln for wifi)

2021-05-12 Thread Felix Fietkau
On 2021-05-13 01:45, Nick Lowe wrote: >> > Regarding ath10k-ct, what kernel-versions of the ath10k-ct driver need to >> > be patched? >> > Is 4.19 the oldest that owrt will consume? >> I think so. 4.19 is used by OpenWrt 19.07 and I don't think we'll update >> anything older than that. > > So,

Re: FRAG Attacks (new vuln for wifi)

2021-05-12 Thread Felix Fietkau
On 2021-05-12 19:13, Ben Greear wrote: > On 5/12/21 9:00 AM, Felix Fietkau wrote: >> >> Hi, >> >> On 2021-05-12 01:34, Paul D wrote: >>> https://www.fragattacks.com/ >>> >>> https://lore.kernel.org/linux-wireless/20210511180259.159598-1

Re: FRAG Attacks (new vuln for wifi)

2021-05-12 Thread Felix Fietkau
Hi, On 2021-05-12 01:34, Paul D wrote: > https://www.fragattacks.com/ > > https://lore.kernel.org/linux-wireless/20210511180259.159598-1-johan...@sipsolutions.net/ I've merged those fixes in openwrt commit 025bd93f36c9. After some testing in master, we should backport them soon. ath10k-ct

Re: [PATCH] build: fix regression for kernels < 5.10

2021-04-13 Thread Felix Fietkau
On 2021-04-13 14:22, Sebastian Kemper wrote: > This fixes a regression introduced with commit > 5ed1e5140a80558ab47fd70410ae3242bed5becf ("build: build kernel image > before building modules/packages"). > > Before this commit the make target would always include "modules", > resulting in a

Re: [PATCH] kernel: disable crypto-hw-ccp on BCM4908

2021-04-13 Thread Felix Fietkau
On 2021-04-13 11:46, Rafał Miłecki wrote: > From: Rafał Miłecki > > CONFIG_CRYPTO_DEV_SP_CCP depends on DMA_ENGINE which depends on > DMADEVICES=y which bcm4908 doesn't need and doesn't use at this point. > > Trying to build this package on bcm4908 was causing: > ERROR: module >

Re: Regression in auto-mounting mtd squashfs partitions

2021-04-10 Thread Felix Fietkau
On 2021-04-10 16:33, Daniel Golle wrote: > On Sat, Apr 10, 2021 at 04:04:28PM +0200, Felix Fietkau wrote: >> Hi Daniel, >> >> it seems to me that your commit 2809d744 ("kernel: support FIT >> partition parser on mtdblock devices") is causing a regressio

Regression in auto-mounting mtd squashfs partitions

2021-04-10 Thread Felix Fietkau
Hi Daniel, it seems to me that your commit 2809d744 ("kernel: support FIT partition parser on mtdblock devices") is causing a regression in mounting squashfs rootfs when CONFIG_FIT_PARTITION is enabled. The following workaround fixes it, but maybe you can make a better fix, since you're more

Re: [PATCH] kernel: drop the conntrack rtcache patch

2021-04-09 Thread Felix Fietkau
lvaterra Acked-by: Felix Fietkau - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Felix Fietkau
On 2021-03-26 22:39, Eneas U de Queiroz wrote: > On Fri, Mar 26, 2021 at 4:28 PM Rosen Penev wrote: >> >> On Fri, Mar 26, 2021 at 5:55 AM Eneas U de Queiroz >> wrote: >> > >> > On Fri, Mar 26, 2021 at 6:26 AM Rosen Penev wrote: >> > > +ifeq ($(QUILT),) >> > > + mv

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Felix Fietkau
On 2021-03-26 09:55, Martin Schiller wrote: > On 2021-03-26 09:42, Felix Fietkau wrote: >> On 2021-03-26 09:34, Martin Schiller wrote: >>> On 2020-07-24 19:13, Felix Fietkau wrote: >>>> On 2020-07-24 18:44, Jo-Philipp Wich wrote: >>>>> Hi Felix, &g

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Felix Fietkau
On 2021-03-26 09:34, Martin Schiller wrote: > On 2020-07-24 19:13, Felix Fietkau wrote: >> On 2020-07-24 18:44, Jo-Philipp Wich wrote: >>> Hi Felix, >>> >>>> [...] >>>> >>>> For a simple default config, you could have this: >>

Re: [PATCH v2] ubusd: convert tx_queue to linked list

2021-03-25 Thread Felix Fietkau
On 2021-03-25 21:43, Arnout Vandecappelle wrote: > > > On 25/03/2021 10:48, Felix Fietkau wrote: >> >> On 2021-03-24 13:27, Arnout Vandecappelle (Essensium/Mind) wrote: >>> ubusd maintains a per-client tx_queue containing references to message >>> b

Re: [PATCH v2] ubusd: convert tx_queue to linked list

2021-03-25 Thread Felix Fietkau
On 2021-03-24 13:27, Arnout Vandecappelle (Essensium/Mind) wrote: > ubusd maintains a per-client tx_queue containing references to message > buffers that have not been sent yet (due to the socket blocking). This > is a fixed-size, 64-element queue. > > When more than 64 elements are queued,

Re: [PATCH] gmp: compile with -DPIC to use correct asm code

2021-03-12 Thread Felix Fietkau
On 2021-03-12 11:34, Stijn Tintel wrote: > On 11/03/2021 23:46, Eneas U de Queiroz wrote: >> The library is always compiled with $(FPIC) (-fPIC or -fpic), even for >> the static library. >> >> There are some assembly sources that decide whether or not to enable >> PIC code by checking if PIC is

  1   2   3   4   5   6   7   8   9   10   >