Re: [opnfv-tech-discuss] Add license information for files without them

2017-04-19 Thread Luke Hinds
Just found this thread again after searching my inbox for something else. So I am prototyping this at the moment. I plan to do the following... Each file that is held at gate, will be checked to see what sort of file extension it has (.py, .java, .c etc) and then a check will be made to make sur

Re: [opnfv-tech-discuss] Add license information for files without them

2017-02-21 Thread Raymond Paik
Sorry I missed this over the long weekend (here in the US). I think what Luke is suggesting is independent of the license scanning tool. If Luke's security scanning tool can be extended to flag files without license headers, that could be helpful. Of course we'd need to filter out false positive

Re: [opnfv-tech-discuss] Add license information for files without them

2017-02-20 Thread gang chi
Hi Yujun, Thanks for your feedback, I rename repo and add Apache License for itself. It is experimental and welcome to improve. Regards Justin 2017-02-19 1:27 GMT+08:00 Yujun Zhang (ZTE) : > The script works great in qtip repo[1]. Thanks a lot, Justin. > > A few comments for improvements > > >

Re: [opnfv-tech-discuss] Add license information for files without them

2017-02-18 Thread Yujun Zhang (ZTE)
+2 for gate check instead of reminding by Email. It seems Ray has used another tool for license scanning. Luke Hinds 于2017年2月19日 周日06:32写道: > If its useful we could add something to our gate to check for license > text? We are trailing a system that checks for private keys, secrets and > blobs be

Re: [opnfv-tech-discuss] Add license information for files without them

2017-02-18 Thread Luke Hinds
If its useful we could add something to our gate to check for license text? We are trailing a system that checks for private keys, secrets and blobs being pushed to repos, I could look to extend this to perform a license check too? On Sat, Feb 18, 2017 at 5:27 PM, Yujun Zhang (ZTE) wrote: > The

Re: [opnfv-tech-discuss] Add license information for files without them

2017-02-18 Thread Yujun Zhang (ZTE)
The script works great in qtip repo[1]. Thanks a lot, Justin. A few comments for improvements 1. add license to this script itself so people know how to contribute. By default, it is proprietary. 2. ignore __init__.py as indicated in OPNFV contribution guidelines[2]. A workaround is

[opnfv-tech-discuss] Add license information for files without them

2017-02-16 Thread gang chi
Hi, I think most of team has received mail from Ray who told me there are over hundred files without License in Compass4nfv repo. I think some team may have same issue with me. so I share my script to generate license header for OPNFV repos. https://github.com/Justin-chi/Lab/blob/master/add_licen