Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2021-03-15 Thread Rob Wilton (rwilton)
Hi Bo, Thanks for addressing my comments, and your work on this document. I've now requested IETF LC on this document. Regards, Rob > -Original Message- > From: Wubo (lana) > Sent: 12 March 2021 10:31 > To: Rob Wilton (rwilton) ; opsawg ; > draft-ietf-opsawg-tacacs-yang@ietf.org

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2021-03-12 Thread Wubo (lana)
Hi Rob, We have posted a -09 version that fixes the issues from you and Tom Petch. Please see below: Diff: https://www.ietf.org/rfcdiff?url2=draft-ietf-opsawg-tacacs-yang-09 Thanks, Bo -邮件原件- 发件人: Rob Wilton (rwilton) [mailto:rwil...@cisco.com] 发送时间: 2021年3月11日 19:23 收件人: Wu

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2021-03-11 Thread Rob Wilton (rwilton)
Thanks Bo. Perhaps make the choice description: "Encryption mechanism between TACACS+ client and server". Let me know when you are done, and I'll start the IETF LC. Regards, Rob > -Original Message- > From: Wubo (lana) > Sent: 11 March 2021 10:46 > To: Rob Wilton (rwilton) ; opsawg

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2021-03-11 Thread Wubo (lana)
Hi Rob, Thanks for your comments. I will submit rev-09 to resolve the issues below. For the "shared-secret", will change the leaf to: choice encryption { mandatory true; description "A choice amongst available encryption types."; case

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2021-03-10 Thread Rob Wilton (rwilton)
Hi Bo, Sorry, this doc slipped off my radar. I've provided comments inline, but I think that it is only the "shared-secret" part that needs to be resolved. > -Original Message- > From: Wubo (lana) > Sent: 19 September 2020 08:47 > To: Rob Wilton (rwilton) ; opsawg ; > draft-ietf-opsa

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-09-19 Thread Wubo (lana)
Hi Rob, Thanks for the reply. Please see inline. Best regards, Bo -邮件原件- 发件人: Rob Wilton (rwilton) [mailto:rwil...@cisco.com] 发送时间: 2020年9月15日 18:53 收件人: Wubo (lana) ; opsawg ; draft-ietf-opsawg-tacacs-yang@ietf.org 主题: RE: AD review of draft-ietf-opsawg-tacacs-yang-07 Hi Bo, Tha

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-09-15 Thread Rob Wilton (rwilton)
Hi Bo, Thanks for addressing my previous comments. Please see inline ... > -Original Message- > From: Wubo (lana) > Sent: 29 August 2020 09:40 > To: Rob Wilton (rwilton) ; opsawg ; > draft-ietf-opsawg-tacacs-yang@ietf.org > Subject: Re: AD review of draft-ietf-opsawg-tacacs-yang-07

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-09-03 Thread Wubo (lana)
-邮件原件- 发件人: tom petch [mailto:ie...@btconnect.com] 发送时间: 2020年9月3日 19:17 收件人: Wubo (lana) ; Rob Wilton (rwilton) ; opsawg ; draft-ietf-opsawg-tacacs-yang@ietf.org 主题: Re: AD review of draft-ietf-opsawg-tacacs-yang-07 From: Wubo (lana) Sent: 03 September 2020 12:11 Hi Tom, Many

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-09-03 Thread tom petch
From: Wubo (lana) Sent: 03 September 2020 12:11 Hi Tom, Many thanks for the review, will fix in the rev-09. Or leave it and treat the comments as part of IETF Last Call (which I hope will happen soon) - I am easy either way. Tom Petch Thanks, Bo -邮件原件- 发件人: tom petch [mailto:ie...

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-09-03 Thread Wubo (lana)
Hi Tom, Many thanks for the review, will fix in the rev-09. Thanks, Bo -邮件原件- 发件人: tom petch [mailto:ie...@btconnect.com] 发送时间: 2020年9月3日 0:13 收件人: Rob Wilton (rwilton) ; opsawg ; draft-ietf-opsawg-tacacs-yang@ietf.org 主题: Re: AD review of draft-ietf-opsawg-tacacs-yang-07 Looking

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-09-02 Thread tom petch
Looking at -08 Title suggest /yang/YANG/ leaf vrf-instance might benefit from a reference to RFC8529 (ie I did not know where to look:-) security /cause the device vulnerable to attacks/make the device vulnerable to attacks/ IANA Namespace /yang: ietf/yang:ietf/ Tom Petch

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-08-29 Thread Wubo (lana)
Hi Rob, v-08 is posted, to address most of the your comments in the two AD reviews. https://www.ietf.org/rfcdiff?url2=draft-ietf-opsawg-tacacs-yang-08 There are still some comments to confirm with you. 3. "shared-secret", should that be put under a choice statement? Is it likely that alternat

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-08-21 Thread Wubo (lana)
Hi Rob, Many thanks for your another thorough AD review, and I will consider these comments along with previous ones. Regards, Bo -邮件原件- 发件人: Rob Wilton (rwilton) [mailto:rwil...@cisco.com] 发送时间: 2020年8月20日 18:38 收件人: opsawg ; draft-ietf-opsawg-tacacs-yang@ietf.org 主题: RE: AD revie

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-08-20 Thread Rob Wilton (rwilton)
Ok, my bad. It seems that I had already done an AD review of this document :-) Bo, there may be some additional comments that you would like to consider below in your -08 update. Regards, Rob > -Original Message- > From: Rob Wilton (rwilton) > Sent: 20 August 2020 11:23 > To: opsawg

[OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-08-20 Thread Rob Wilton (rwilton)
Hi, This is my AD review of draft-ietf-opsawg-tacacs-yang-07. Sorry that it has been a little while in coming. Thank you for this document, I believe that it is in good shape. I've given my slightly more significant comments first, followed by some editorial comments. COMMENTS: "Section 3"

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-07-15 Thread Wubo (lana)
s you have suggested. Please also see the replies in-line below for some comments to be confirmed. Thanks, Bo -邮件原件- 发件人: OPSAWG [mailto:opsawg-boun...@ietf.org] 代表 Rob Wilton (rwilton) 发送时间: 2020年7月11日 0:53 收件人: draft-ietf-opsawg-tacacs-yang@ietf.org 抄送: opsawg 主题: [OPSAWG] AD review

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-07-11 Thread Rob Wilton (rwilton)
Hi Joe, Review comments also attached as txt file. Thanks, Rob > -Original Message- > From: Joe Clarke (jclarke) > Sent: 10 July 2020 23:15 > To: Rob Wilton (rwilton) > Cc: draft-ietf-opsawg-tacacs-yang@ietf.org; opsawg > Subject: Re: AD review of draft-ietf-opsawg-tacacs-yang-07

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-07-10 Thread Joe Clarke (jclarke)
Thanks, Rob. Maybe it’s just me, but your email is truncated as you can see below. I also didn’t see any attachment. Joe > On Jul 10, 2020, at 12:52, Rob Wilton (rwilton) wrote: > > Apologies for the delay, but please find my AD review of the TACACS+ YANG > module draft. > > I would like t

[OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

2020-07-10 Thread Rob Wilton (rwilton)
Apologies for the delay, but please find my AD review of the TACACS+ YANG module draft. I would like to thank the authors for their work on this document, and the WG for providing reviews and input in this document. I believe that the document is in good shape but propose some minor changes to