Re: [OPSAWG] Yangdoctors early review of draft-ietf-opsawg-ac-lxsm-lxnm-glue-04

2024-02-09 Thread mohamed . boucadair
Hi Martin, all, FWIW, the proposed changes are now implemented in the public version: https://datatracker.ietf.org/doc/html/draft-ietf-opsawg-ac-lxsm-lxnm-glue-06. Cheers, Med > -Message d'origine- > De : BOUCADAIR Mohamed INNOV/NET > Envoyé : jeudi 25 janvier 2024 13:56 > À : 'Martin

Re: [OPSAWG] Yangdoctors early review of draft-ietf-opsawg-ac-lxsm-lxnm-glue-04

2024-01-25 Thread mohamed . boucadair
Hi Martin, Thank you for the follow-up. Fixed the nits in the yang file. Also updated the module to make use of the new groupings for referencing purposes instead of the broken typedefs in the ac-ntw: https://author-tools.ietf.org/api/iddiff?iddiff?doc_1=draft-ietf-opsawg-ac-lxsm-lxnm-glue&u

Re: [OPSAWG] Yangdoctors early review of draft-ietf-opsawg-ac-lxsm-lxnm-glue-04

2024-01-24 Thread Martin Björklund
mohamed.boucad...@orange.com wrote: > Hi Martin, > > Thanks for the review. > > FWIW, a new version that fixes the nit you reported and other minor pending > we had is available online: > https://author-tools.ietf.org/iddiff?url2=draft-ietf-opsawg-ac-lxsm-lxnm-glue-05 That was quick! However,

Re: [OPSAWG] Yangdoctors early review of draft-ietf-opsawg-ac-lxsm-lxnm-glue-04

2024-01-24 Thread mohamed . boucadair
Hi Martin, Thanks for the review. FWIW, a new version that fixes the nit you reported and other minor pending we had is available online: https://author-tools.ietf.org/iddiff?url2=draft-ietf-opsawg-ac-lxsm-lxnm-glue-05 Cheers, Med > -Message d'origine- > De : Martin Björklund via Data

[OPSAWG] Yangdoctors early review of draft-ietf-opsawg-ac-lxsm-lxnm-glue-04

2024-01-24 Thread Martin Björklund via Datatracker
Reviewer: Martin Björklund Review result: Ready with Nits This is a very short, and from a YANG-perspective simple, module. It looks good, and I also found one nit: s/provisionned/provisioned/g /martin ___ OPSAWG mailing list OPSAWG@ietf.org https://w