Hi Per,
Great news that you've been able to find a way. Quite a simple change
in the end. The trick is knowing exactly what bits to tweak... even I
didn't know this in this instance!
Robert.
On Tue, Mar 3, 2009 at 7:59 PM, Per Fahlberg wrote:
> Hi,
>
> For the record I've found a way to get t
Hi,
For the record I've found a way to get things working the way I want it,
by changing the culling mask of the culling set at the back of the
projection culling stack, small feature culling can now be both enabled
and disabled for subgraphs. The code for my callback looks like this now
(the
Hi Per,
Unfortunately this is too a niche a part of the OSG to provide an
answer off the top of my head.
Rober.
On Mon, Mar 2, 2009 at 8:01 PM, Per Fahlberg wrote:
> Hi Robert,
>
> Ok, so if I change the mask of the current CullingSet in a cull callback,
> should it only affect the culling of t
Hi Robert,
Ok, so if I change the mask of the current CullingSet in a cull
callback, should it only affect the culling of the node that the
callback is attached to and not the nodes below in the scenegraph?
If I change the culling mode of the cull visitor in a cull callback,
should it affect
Hi Per,
I'm a bit rusty on this topic, too many topics coming flying by each
day that niche stuff drops out of focus quite quickly...
Something I can answer right away is to to explain the relationship
between the CullingSet CullingMode and CullingMask. The Mode is the
base mode that specifies w
A correction, my earlier proposed fix also solves this problem if the
cull callback is changed to also modify the culling mode of the cull
visitor, so that the callback reads something like this:
...
osg::CullSettings::CullingMode cullVisitorCullingMode =
cv->getCullingMode();
osg::CullingSe
Hi Robert,
I've been busy with other work and only now been able to try your
proposed change and found that it doesn't quite work as expected. When I
run the attached modified osgscribe example with the attached
box-sphere.osg model the small feature culling only culls the entire
model, i.e.
Hi Per,
On Wed, Jan 28, 2009 at 8:55 PM, Per Fahlberg wrote:
> I don't really understand how this is not a bug since it is possible to
> switch small feature culling on for a subgraph but not switch it off?
The scene graph itself doesn't support switching off small feature
culling in a subgraph.
Hi Robert,
Thank you for looking into this issue.
Robert Osfield wrote:
Hi Per,
I've quite a bit of head scratching about what was going on a couple
of things dawned on me:
1) The way to implement localization of small feature culling is to
disable it globally and then just enable it for
Hi Per,
I've quite a bit of head scratching about what was going on a couple
of things dawned on me:
1) The way to implement localization of small feature culling is to
disable it globally and then just enable it for
the subgraphs that need it. This avoid problems with subgraphs
being culled
Hi Per,
I've just applied your patch and found that it initially seems to
work, but breaks once I do several simple zoom in/zoom out movements,
randomly the second cow disappears at the same time as the original
one, and even when the second cow doesn't disppaer right away it does
eventually get c
Hi Per,
FYI, I'm back on the case of the toggling small feature culling in
subgraphs. I'm able to reproduce the bug with your example, and
should be able to resolve the best way to solve the problem in the
next hour or two.
Robert.
On Mon, Dec 15, 2008 at 2:23 PM, Per Fahlberg wrote:
> Hi Robe
Hi Robert,
Ok, thanks, I guess I misinterpreted your earlier response, I will await
your wider review then, please let me know if I can be of any help.
Regards,
Per
Robert Osfield wrote:
Hi Per,
On Sat, Dec 20, 2008 at 7:50 PM, Per Fahlberg wrote:
I've noticed that my fix didn't make i
Hi Per,
On Sat, Dec 20, 2008 at 7:50 PM, Per Fahlberg wrote:
> I've noticed that my fix didn't make it into the 2.7.8 release and just
> wanted to check if there was a problem with it and that it isn't forgotten.
As I mentioned in my reply, the patch doesn't feel right, and to me
suggest design
Hi Robert,
I've noticed that my fix didn't make it into the 2.7.8 release and just
wanted to check if there was a problem with it and that it isn't forgotten.
Regards,
Per
Robert Osfield wrote:
Hi Per,
I've just done a quick review of your changes and it does feel balanced to me.
Is CullVi
Hi Robert,
In CullVisitor when culling it uses the current CullingSet when checking
for small feature culling, that is why i changed both the current
CullingSet and the settings in CullVisitor in my callback, so that the
current node isn't culled by small feature culling as well as the
subgra
Hi Per,
I've just done a quick review of your changes and it does feel balanced to me.
Is CullVisitor checking the current setting of
SmallFeatureCullingPixelSize() from the current CullingSet or
CullStack? If so then you own callback should be setting current
CullingSet rather than the CullStack
Hi Robert,
I've found a way to get it working by slightly modifying CullStack.cpp
and by also changing my cull callback. When pushing the CullingSet in
CullStack I have added updating the cull mask in the new CullingSet. I
needed to change both the cull visitors culling mode and the current
C
Hi Per,
It sounds like you'll need to directly manipulator or push new
settings on the stack in CullVisitor.
Robert.
On Mon, Dec 15, 2008 at 10:12 AM, Per Fahlberg wrote:
> Hi Robert,
>
> I've traced the problem down now and it seems the culling mode that the
> CullVisitor uses is correct but t
Hi Robert,
I've traced the problem down now and it seems the culling mode that the
CullVisitor uses is correct but the one in the CullingSet is incorrect.
This is due to the CullingSet being updated in
CullStack::pushProjectionMatrix which is called early on in culling, and
when I change the
Hi Robert,
Thanks for confirming that I'm not doing anything wrong, I'll try to dig
deeper to see what might be wrong.
Regards,
Per
Robert Osfield wrote:
Hi Per,
On Tue, Dec 2, 2008 at 11:34 AM, Per Fahlberg <[EMAIL PROTECTED]> wrote:
Perhaps I wasn't clear in my question so I will try
Hi Per,
On Tue, Dec 2, 2008 at 11:34 AM, Per Fahlberg <[EMAIL PROTECTED]> wrote:
> Perhaps I wasn't clear in my question so I will try once more, is there a
> way to disable small feature culling for just a subgraph not the entire
> scene?
The only way is is use a cull callback to cache the previ
Hi,
Perhaps I wasn't clear in my question so I will try once more, is there
a way to disable small feature culling for just a subgraph not the
entire scene?
Regards,
Per
Per Fahlberg wrote:
Hi,
I'm trying to disable small feature culling for a subgraph, but so far
I have not been able to
Hi,
I'm trying to disable small feature culling for a subgraph, but so far I
have not been able to disable it with other than calling
setCullingActive(false) on the leaf geodes. The leaf geodes are actually
shared between several subgraphs and I don't want to disable small
feature culling for
24 matches
Mail list logo
