Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-14 Thread Daniel Emminizer, Code 5773
. Thanks, - Dan > -Original Message- > From: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On > Behalf Of Robert Osfield > Sent: Thursday, June 14, 2018 4:10 AM > To: OpenSceneGraph Users > Subject: Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-14 Thread Robert Osfield
H Dan et. al, On Thu, 14 Jun 2018 at 08:25, Robert Osfield wrote: > Perhaps another approach would be to just warn the user that the > Binding hasn't been set prior to the Geometry::set*Array() call, or do > a belt and braces of treat an BIND_UNDEFINED binding as a > BIND_PER_VERTEX to force a

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-14 Thread Robert Osfield
Hi Daniel, On Wed, 13 Jun 2018 at 23:29, Daniel Emminizer, Code 5773 wrote: > I don't know enough about the inner workings to know if this is a dumb idea > -- but could you perhaps detect the problem during cull (VBO attachment is > NULL but array exists and is non-empty), then call >

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-13 Thread Daniel Emminizer, Code 5773
> -Original Message- > From: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On > Behalf Of Robert Osfield > Sent: Wednesday, June 13, 2018 3:28 PM > To: OpenSceneGraph Users > Subject: Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays > > I am moving towards t

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-13 Thread Robert Osfield
I am moving towards the idea that we may only be able to catch on the fly bad usage and disable the arrays that don't have a VBO assigned when trying to render with VAO, and emit a warning. this will be better than having an application crash. I'm going to re-factor the existing places in the OSG

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-13 Thread Daniel Emminizer, Code 5773
gt; To: OpenSceneGraph Users > Subject: Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays > > Hi Dan, et. al, > > I haven't yet got to bottom of this issue, but so far it looks like > doing the Array::setBinding(Array::BIND_PER_VERTEX) call later than > the array itself i

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-13 Thread Robert Osfield
Hi All, I've started investigating what is happening in the VertexArrayState that is passing the array data to OpenGL. When things are all set up correctly w.r.t VBO assignment to the Arrays we get: VertexArrayState::setArray(VertexArrayDispatch, new_array=0x1092250 vbo=0x7f583c09d210

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-13 Thread Robert Osfield
Hi Dan, et. al, I haven't yet got to bottom of this issue, but so far it looks like doing the Array::setBinding(Array::BIND_PER_VERTEX) call later than the array itself is assigned to the geometry bypasses the mechanism that osg::Geometry uses to make sure all the arrays that need a VBO have one

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-13 Thread Robert Osfield
ther (and > if I did, I would only call it at startup, not on each geometry creation). > > Are we running the same main.cpp? I'm attaching my original just in case. > > Thanks, > > - Dan > > > > > -Original Message- > > From: osg-users [mailto

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-13 Thread Daniel Emminizer, Code 5773
nal Message- > From: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On > Behalf Of Robert Osfield > Sent: Wednesday, June 13, 2018 7:45 AM > To: OpenSceneGraph Users > Subject: Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays > > Hi Dan et. al, > > I have

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-13 Thread Robert Osfield
Hi Dan et. al, I have had another look into this issue, looked at Dan's workaround and used Dan's test example to see investigate what might be going on. I have checked in a fix: https://github.com/openscenegraph/OpenSceneGraph/commit/673292b995115c6ca9a3cc82c26e05023f504774 This allows

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-11 Thread Daniel Emminizer, Code 5773
m: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On > Behalf Of Robert Osfield > Sent: Monday, June 11, 2018 10:48 AM > To: OpenSceneGraph Users > Subject: Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays > > Hi Daniel, > > Thanks for looking

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-11 Thread Daniel Emminizer, Code 5773
:26 AM To: OpenSceneGraph Users Subject: Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays Hi Daniel, I don't understand why your modification to addPrimitiveSet() resolves your issue with the openflight plugin, as it's called before the proper array bindings have been set (src\osgPlugins\Open

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-11 Thread Robert Osfield
my immediate crash out of FLT and most of > the other use cases I've encountered. > > Thanks, > > - Dan > > > > > -Original Message- > > From: Daniel Emminizer, Code 5773 > > Sent: Monday, June 04, 2018 8:45 AM > > To: OpenSceneGraph Users

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-11 Thread Voerman, L.
binary compatibility and > is fairly straightforward, and helps my immediate crash out of FLT and most > of the other use cases I've encountered. > > Thanks, > > - Dan > > > > > -----Original Message- > > From: Daniel Emminizer, Code 5773 > > Sent: Monda

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-11 Thread Daniel Emminizer, Code 5773
age- > From: Daniel Emminizer, Code 5773 > Sent: Monday, June 04, 2018 8:45 AM > To: OpenSceneGraph Users > Subject: RE: [osg-users] VBO Bug with 3.6.1 and Normal Arrays > > Hi Robert, > > The file you sent is identical to the one I sent. Was that intentional? You > also

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-04 Thread Daniel Emminizer, Code 5773
alf Of Robert Osfield > Sent: Sunday, June 03, 2018 6:11 AM > To: OpenSceneGraph Users > Subject: Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays > > Hi Dan, > > On 1 June 2018 at 16:01, Daniel Emminizer, Code 5773 > wrote: > > Attached is a demo of the probl

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-03 Thread Robert Osfield
On 3 June 2018 at 11:11, Robert Osfield wrote: > Hi Dan, > > On 1 June 2018 at 16:01, Daniel Emminizer, Code 5773 > wrote: >> Attached is a demo of the problem that generates a console warning. More >> complex scenes can cause crashes. The red triangle has the problem, but the >> green one

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-03 Thread Robert Osfield
Hi Dan, On 1 June 2018 at 16:01, Daniel Emminizer, Code 5773 wrote: > Attached is a demo of the problem that generates a console warning. More > complex scenes can cause crashes. The red triangle has the problem, but the > green one does not. I have built the example, and to help with test

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-01 Thread Brad Colbert
Could this be why I'm not getting my colors? Cheers, Brad On Fri, Jun 1, 2018 at 8:51 AM, Robert Osfield wrote: > Hi Dan, > > Thanks for the explanation and example to reproduce the bug... Guess > it looks like we'll need to make 3.6.2 rather sooner than I was > hoping, it'll be one a month at

Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-01 Thread Robert Osfield
Hi Dan, Thanks for the explanation and example to reproduce the bug... Guess it looks like we'll need to make 3.6.2 rather sooner than I was hoping, it'll be one a month at this rate... Robert. On 1 June 2018 at 16:01, Daniel Emminizer, Code 5773 wrote: > Hi Robert, > > Oops -- I sent this

[osg-users] VBO Bug with 3.6.1 and Normal Arrays

2018-06-01 Thread Daniel Emminizer, Code 5773
Hi Robert, Oops -- I sent this earlier today but apparently to the bounces list; that explains the confusion on GitHub -- my mistake. This was supposedly sent right before I posted the PR. Here's the original text: I think I found a bug in 3.6.1. I am loading a FLT model and it's causing a