Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-25 Thread Robert Osfield
Hi Franz, On Mon, Feb 25, 2008 at 3:41 PM, Melchior FRANZ <[EMAIL PROTECTED]> wrote: > > BTW, for future submissions could you send whole files rather a diff, > > as per the instructions on: > > I sent the whole files to osg-submissions, as the instructions say. > This here was only for people

Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-25 Thread Melchior FRANZ
* Robert Osfield -- Monday 25 February 2008: > Do you have a new set of changes pending? Are the ones from 21st Feb > the latest and definitive set to review? > BTW, for future submissions could you send whole files rather a diff, > as per the instructions on: I sent the whole files to osg-subm

Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-25 Thread Robert Osfield
HI Franz, On Thu, Feb 7, 2008 at 5:18 PM, Melchior FRANZ <[EMAIL PROTECTED]> wrote: > * Melchior FRANZ -- Thursday 07 February 2008: > > > And it works here with my patch, while first tests have shown > > that FocusOut, LeaveNotify, and KeymapNotify weren't triggered > > at all (which is suspici

Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-21 Thread Melchior FRANZ
I've meanwhile submitted a fix. In case someone wants to try it and is not subscribed to osg-submissions, it's available here: http://members.aon.at/mfranz/X11-kbd-fix.diff.bz2 [2.6 kB] This patch does additionally have a compilation warning fixed that didn't occur on my system, and it impro

Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-07 Thread Melchior FRANZ
* Melchior FRANZ -- Thursday 07 February 2008: > And it works here with my patch, while first tests have shown > that FocusOut, LeaveNotify, and KeymapNotify weren't triggered > at all (which is suspicious). It was the event mask, of course. :-) UnmapNotify is sent on window minimizing and shadin

Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-07 Thread Melchior FRANZ
* Melchior FRANZ -- Thursday 07 February 2008: > I never use alt+tab, No, wait. I use it all the time! Only it's Meta-Tab here. And it works here with my patch, while first tests have shown that FocusOut, LeaveNotify, and KeymapNotify weren't triggered at all (which is suspicious). Still investiga

Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-07 Thread Melchior FRANZ
* till busch -- Thursday 07 February 2008: > ulrich hertlein said something about "KeymapNotify which is > generated after every EnterNotify and FocusIn". something > like this might be a better place? I never use alt+tab, so I didn't notice. Don't know yet about KeymapNotify, but we don't want t

Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-07 Thread till busch
hi melchior, i believe UmapNotify is not the right place to do this (or at least not the only place that you should consider). the bug also appears when changing focus with alt+tab (in kde). ulrich hertlein said something about "KeymapNotify which is generated after every EnterNotify and Focus

Re: [osg-users] X11 keyboard bug (+ fix)

2008-02-06 Thread Melchior FRANZ
Thanks to all who replied. I've now written a cleaner fix. The focus on modifiers was silly. After we lose all releases on a "window hide" event, not only modifier releases, we also have to fake-release all of them. What made the most sense to me was to maintain a keyStateMap which keeps track of t