Re: [OSRM-talk] New v5.23.0 release

2020-10-18 Thread Michael Bell
> But that change actually breaks the intended change - binary exchange > protocol. Fair point. It breaks the new interface. An alternative could be to offer the old and new interfaces together. That will resolve the breaking change and not introduce a new one. But there would be two ways to

Re: [OSRM-talk] New v5.23.0 release

2020-10-18 Thread Denis Chapligin
Actually i just realized, that i've made a patch for libosrmc a year ago: https://github.com/daniel-j-h/libosrmc/pull/17 I'll ask the libosrmc maintainter to check it one more time. вс, 18 окт. 2020 г. в 19:55, Denis Chapligin : > But that change actually breaks the intended change - binary

Re: [OSRM-talk] New v5.23.0 release

2020-10-18 Thread Denis Chapligin
But that change actually breaks the intended change - binary exchange protocol. вс, 18 окт. 2020 г. в 08:37, Michael Bell : > I've had a go at reverting the breaking change: > https://github.com/Project-OSRM/osrm-backend/pull/5860 > I was able to compile libosrmc against it. > > Michael > > On

Re: [OSRM-talk] New v5.23.0 release

2020-10-18 Thread Julien Coupey
Thanks a lot Daniel, Denis and Michael for your answers. Michael, I did not go through the details of your changes in PR #5860, but I gave a go at building and installing. I can confirm that the dowstream compilation problem reported in #5741 is gone with your changes. Regards Julien On