> But that change actually breaks the intended change - binary exchange
> protocol.
Fair point. It breaks the new interface.
An alternative could be to offer the old and new interfaces together.
That will resolve the breaking change and not introduce a new one.
But there would be two ways to ret
Actually i just realized, that i've made a patch for libosrmc a year ago:
https://github.com/daniel-j-h/libosrmc/pull/17
I'll ask the libosrmc maintainter to check it one more time.
вс, 18 окт. 2020 г. в 19:55, Denis Chapligin :
> But that change actually breaks the intended change - binary exc
But that change actually breaks the intended change - binary exchange
protocol.
вс, 18 окт. 2020 г. в 08:37, Michael Bell :
> I've had a go at reverting the breaking change:
> https://github.com/Project-OSRM/osrm-backend/pull/5860
> I was able to compile libosrmc against it.
>
> Michael
>
> On Th
Thanks a lot Daniel, Denis and Michael for your answers.
Michael, I did not go through the details of your changes in PR #5860,
but I gave a go at building and installing. I can confirm that the
dowstream compilation problem reported in #5741 is gone with your changes.
Regards
Julien
On 18/1
I've had a go at reverting the breaking change:
https://github.com/Project-OSRM/osrm-backend/pull/5860
I was able to compile libosrmc against it.
Michael
On Thu, 15 Oct 2020 at 17:14, Denis Chapligin wrote:
>
> IIRC you had some idea of hiding that change and unbreaking the API by
> templating
IIRC you had some idea of hiding that change and unbreaking the API by
templating ResultT type. If you can explain your idea I can probably
implement it.
чт, 15 окт. 2020 г. в 17:43, Daniel Patterson via OSRM-talk <
osrm-talk@openstreetmap.org>:
> Dammit, sorry Julien, I'd forgotten about that is
Dammit, sorry Julien, I'd forgotten about that issue - I'm not using the
libosrm bindings directly, so this change slipped my mind.
If someone has time to fix the interface, we can release 5.24.0 to address
it, and mark 5.23.0 as a dud. The interface change clearly breaks semver
rules as it's not
Hi Daniel and all
Thanks for your work on this release, and all the various recent
contributions that made it possible. It's great to see a new OSRM
version, first one in a long time!
I'd like to ask for a clarification though, if possible, on the status
of libosrm regarding this new version
Hello all,
Well, after a long hiatus, I've finally had time to cut a new release.
I've bundled up a bunch of the changes that have been submitted over the
last couple of years, and tagged 5.23.0, and cleaned up the
changelog/master branch which had been left dangling in an unclear state
for a wh
