Re: [PATCH] zfs: activate compression

2016-06-20 Thread Nadav Har'El
Great, thanks. Benoit, can you please resend your patch with some of Raphael's quotes - or your own justification - so that in the future we won't forget why we did this change? Would have been nice to do what Glauber suggested (try some workload that can't benefit from compression, e.g., Cassandr

Re: [PATCH] zfs: activate compression

2016-06-20 Thread Raphael Carvalho
On Mon, Jun 20, 2016 at 8:17 PM, Nadav Har'El wrote: > Hi Benoit, can you please say a few words on why, or why not, to enable > compression? > > Is it a tradeoff, e.g., good for slow disks but bad for fast disks? Is > good for some applications but bad for others? > > I believe our default was m

Re: [PATCH] zfs: activate compression

2016-06-20 Thread Nadav Har'El
Hi Benoit, can you please say a few words on why, or why not, to enable compression? Is it a tradeoff, e.g., good for slow disks but bad for fast disks? Is good for some applications but bad for others? I believe our default was made "off" for a reason. Raphael, do you perhaps remember why? --